You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "cshuo (via GitHub)" <gi...@apache.org> on 2026/04/29 12:37:51 UTC
[PR] feat(flink): Support stream RLI writing for simple bucket index [hudi]
cshuo opened a new pull request, #18645:
URL: https://github.com/apache/hudi/pull/18645
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the changes
(or) link to an issue by including `Closes #<issue-number>` for context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in behavior.
Followed by a detailed log of all the changes. Highlight if any code was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
If medium or high, explain what verification was done to mitigate the risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4575217856
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 97 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95817 +133
- Misses 37032 37117 +85
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <0.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344092601
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.65%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|6|
>|spark-java-tests|18|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 60.65% -7.43%
+ Complexity 28913 25798 -3115
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 85393 -10302
- Misses 37026 47937 +10911
+ Partials 7851 7460 -391
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <0.00%> (-17.00%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `73.32% <50.00%> (-10.54%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [559 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344133524
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.77%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 66.77% -1.31%
+ Complexity 28913 28350 -563
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94013 -1682
- Misses 37026 38892 +1866
- Partials 7851 7885 +34
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.82% <0.00%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <0.00%> (-0.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [227 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344028674
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.00%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|5|
>|spark-java-tests|18|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 48.00% -20.07%
+ Complexity 28913 16756 -12157
=============================================
Files 2518 2026 -492
Lines 140572 114469 -26103
Branches 17422 14668 -2754
=============================================
- Hits 95695 54954 -40741
- Misses 37026 53571 +16545
+ Partials 7851 5944 -1907
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.20% <0.00%> (-15.45%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <0.00%> (-12.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1580 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349716047
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.66%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 38 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|5|
>|spark-scala-tests|17|6|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.66% -20.41%
+ Complexity 28909 17022 -11887
=============================================
Files 2518 2047 -471
Lines 140572 116955 -23617
Branches 17422 15205 -2217
=============================================
- Hits 95684 55745 -39939
- Misses 37032 55086 +18054
+ Partials 7856 6124 -1732
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.04% <0.00%> (-16.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344308524
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 68.04% -0.03%
- Complexity 28913 28945 +32
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
+ Hits 95695 95802 +107
- Misses 37026 37120 +94
- Partials 7851 7868 +17
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <0.00%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344263441
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.03%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 68.03% -0.04%
- Complexity 28913 28944 +31
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
+ Hits 95695 95792 +97
- Misses 37026 37129 +103
- Partials 7851 7869 +18
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.13%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349437970
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 64.90%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 64.90% -3.16%
+ Complexity 28909 27607 -1302
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 91388 -4296
- Misses 37032 41521 +4489
- Partials 7856 7888 +32
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <0.00%> (-17.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.10% <0.00%> (-0.60%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [406 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165384074
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/RecordLevelIndexBackend.java:
##########
@@ -19,125 +19,378 @@
package org.apache.hudi.sink.partitioner.index;
import org.apache.hudi.client.common.HoodieFlinkEngineContext;
-import org.apache.hudi.common.data.HoodieListData;
+import org.apache.hudi.common.config.HoodieCommonConfig;
import org.apache.hudi.common.data.HoodiePairData;
+import org.apache.hudi.common.model.FileSlice;
import org.apache.hudi.common.model.HoodieRecordGlobalLocation;
+import org.apache.hudi.common.serialization.DefaultSerializer;
import org.apache.hudi.common.table.HoodieTableMetaClient;
-import org.apache.hudi.common.util.HoodieDataUtils;
+import org.apache.hudi.common.util.DefaultSizeEstimator;
+import org.apache.hudi.common.util.ValidationUtils;
import org.apache.hudi.common.util.VisibleForTesting;
-import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.OptionsResolver;
import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
import org.apache.hudi.metadata.HoodieTableMetadata;
+import org.apache.hudi.metadata.MetadataPartitionType;
import org.apache.hudi.sink.event.Correspondent;
+import org.apache.hudi.sink.utils.PeriodicActionExecutor;
+import org.apache.hudi.util.FlinkWriteClients;
import org.apache.hudi.util.StreamerUtil;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.flink.configuration.Configuration;
+import java.io.Closeable;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
/**
- * An implementation of {@link IndexBackend} based on the record level index in metadata table.
+ * Partition-scoped index backend backed by partitioned record level index.
+ *
+ * <p>The backend keeps a lazy cache per data partition. Each cache maps record keys owned by the
+ * current Flink assign subtask to the file group id stored in the partitioned RLI. New records are
+ * added to the cache after bucket assignment, while existing records keep their original RLI routing.
+ *
+ * <p>Partition caches are evicted lazily: checkpoint completion only advances the safe eviction
+ * watermark, and cleanup happens when the total in-memory cache size exceeds
+ * {@link FlinkOptions#INDEX_RLI_CACHE_SIZE}.
*/
@Slf4j
-public class RecordLevelIndexBackend implements MinibatchIndexBackend {
- @VisibleForTesting
- @Getter
- private final RecordIndexCache recordIndexCache;
+public class RecordLevelIndexBackend implements PartitionedIndexBackend {
+
private final Configuration conf;
+ private final HoodieWriteConfig writeConfig;
private final HoodieTableMetaClient metaClient;
+ private final boolean isInsertOverwrite;
+ private final long maxCacheSizeInBytes;
+ private final BootstrapFilter bootstrapFilter;
private HoodieTableMetadata metadataTable;
- public RecordLevelIndexBackend(Configuration conf, long initCheckpointId) {
- this.metaClient = StreamerUtil.createMetaClient(conf);
+ @Getter
+ private final Map<String, BucketCache> partitionBucketCaches = new LinkedHashMap<>(16, 0.75f, true);
+ private long currentCheckpointId = -1L;
+ private long minRetainedCheckpointId = Long.MIN_VALUE;
+ private final PeriodicActionExecutor memoryCheckExecutor = new PeriodicActionExecutor();
+
+ /**
+ * Creates a partitioned RLI backend with custom ownership filtering.
+ *
+ * <p>This constructor is used by simple bucket index, whose write ownership is determined by
+ * partition and bucket file id rather than Flink record-key key groups.
+ *
+ * @param conf Flink write configuration
+ * @param bootstrapFilter filter for deciding whether a bootstrapped RLI record belongs to this task
+ */
+ public RecordLevelIndexBackend(Configuration conf, BootstrapFilter bootstrapFilter) {
this.conf = conf;
- this.recordIndexCache = new RecordIndexCache(conf, initCheckpointId);
+ this.writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, false, false);
+ this.metaClient = StreamerUtil.createMetaClient(conf);
+ this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(conf);
+ this.maxCacheSizeInBytes = conf.get(FlinkOptions.INDEX_RLI_CACHE_SIZE) * 1024 * 1024;
+ this.bootstrapFilter = bootstrapFilter;
reloadMetadataTable();
}
@Override
- public HoodieRecordGlobalLocation get(String recordKey) throws IOException {
- return get(Collections.singletonList(recordKey)).get(recordKey);
+ public String get(String partitionPath, String recordKey) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ return cache.getFileGroupId(recordKey);
}
@Override
- public void update(String recordKey, HoodieRecordGlobalLocation recordGlobalLocation) {
- recordIndexCache.update(recordKey, recordGlobalLocation);
+ public void update(String partitionPath, String recordKey, String fileId) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ cache.putRecordKey(recordKey, fileId, false);
+ memoryCheckExecutor.runIfNecessary(() -> cleanIfNecessary(0L, partitionPath));
}
+ /**
+ * Records the latest checkpoint id seen by this assign subtask.
+ *
+ * <p>New record-key mappings written after this point are tagged with the checkpoint id so lazy
+ * eviction can avoid removing partition caches that may still be needed for recovery.
+ *
+ * @param checkpointId checkpoint id from the bucket assign operator
+ */
@Override
- public Map<String, HoodieRecordGlobalLocation> get(List<String> recordKeys) throws IOException {
- // use a linked hash map to keep the natural order.
- Map<String, HoodieRecordGlobalLocation> keysAndLocations = new LinkedHashMap<>();
- List<String> missedKeys = new ArrayList<>();
- for (String key: recordKeys) {
- HoodieRecordGlobalLocation location = recordIndexCache.get(key);
- if (location == null) {
- missedKeys.add(key);
- }
- // insert anyway even the location is null to keep the natural order.
- keysAndLocations.put(key, location);
- }
- if (!missedKeys.isEmpty()) {
- HoodiePairData<String, HoodieRecordGlobalLocation> recordIndexData =
- metadataTable.readRecordIndexLocationsWithKeys(HoodieListData.eager(missedKeys));
- List<Pair<String, HoodieRecordGlobalLocation>> recordIndexLocations = HoodieDataUtils.dedupeAndCollectAsList(recordIndexData);
- recordIndexLocations.forEach(keyAndLocation -> {
- recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue());
- keysAndLocations.put(keyAndLocation.getKey(), keyAndLocation.getValue());
- });
- }
- return keysAndLocations;
+ public void onCheckpoint(long checkpointId) {
+ this.currentCheckpointId = checkpointId;
}
+ /**
+ * Advances the lazy eviction watermark after a completed checkpoint.
+ *
+ * <p>The watermark is derived from the minimum inflight checkpoint so caches that may still be
+ * needed for recovery are retained. Metadata table state is reloaded after the coordinator has
+ * committed or advanced instants for the completed checkpoint.
+ *
+ * @param correspondent writer coordinator correspondent used to query inflight instants
+ * @param completedCheckpointId completed checkpoint id reported by Flink
+ */
@Override
- public void update(List<Pair<String, HoodieRecordGlobalLocation>> recordKeysAndLocations) throws IOException {
- recordKeysAndLocations.forEach(keyAndLocation -> recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue()));
+ public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointId) {
+ Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
+ updateEvictableCkp(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointId));
+ metaClient.reloadActiveTimeline();
+ reloadMetadataTable();
}
- @Override
- public void onCheckpoint(long checkpointId) {
- recordIndexCache.addCheckpointCache(checkpointId);
+ private BucketCache getOrBootstrapPartition(String partitionPath) {
+ BucketCache cache = partitionBucketCaches.get(partitionPath);
+ if (cache != null) {
+ return cache;
+ }
+
+ cache = isInsertOverwrite ? createBucketCache(partitionPath) : bootstrapPartition(partitionPath);
+ partitionBucketCaches.put(partitionPath, cache);
+ cleanIfNecessary(0L, partitionPath);
+ return cache;
}
- @Override
- public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointID) {
- Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
- log.info("Inflight instants and the corresponding checkpoints: {}, notified completed checkpoints: {}",
- inflightInstants, completedCheckpointID);
- // if there are no inflight instants,
- // the latest completed checkpoint id is used as the minimum checkpoint id,
- // since the streaming write operator always uses previous checkpoint id to request the new instant.
- recordIndexCache.markAsEvictable(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointID));
- this.metaClient.reloadActiveTimeline();
- reloadMetadataTable();
+ private BucketCache bootstrapPartition(String partitionPath) {
+ BucketCache cache = createBucketCache(partitionPath);
+ if (!metaClient.getTableConfig().isMetadataPartitionAvailable(MetadataPartitionType.RECORD_INDEX)) {
+ log.info("Record index is not available yet. Start partitioned RLI cache empty for partition {}", partitionPath);
+ return cache;
+ }
+
+ try {
+ Map<String, List<FileSlice>> partitionedFileGroups =
+ metadataTable.getBucketizedFileGroupsForPartitionedRLI(MetadataPartitionType.RECORD_INDEX);
+ List<FileSlice> fileSlices = partitionedFileGroups.get(partitionPath);
+ if (fileSlices == null || fileSlices.isEmpty()) {
+ return cache;
+ }
+ HoodiePairData<String, HoodieRecordGlobalLocation> locations =
+ metadataTable.readRecordIndexLocations(fileSlicesToFilter -> fileSlices);
+ final AtomicLong totalCnt = new AtomicLong();
+ locations.forEach(locationPair -> {
+ String recordKey = locationPair.getLeft();
+ String fileId = locationPair.getRight().getFileId();
+ if (bootstrapFilter.shouldLoad(partitionPath, recordKey, fileId)) {
+ cache.putRecordKey(recordKey, fileId, true);
+ }
+ totalCnt.incrementAndGet();
+ });
+ log.info("Bootstrapped partitioned RLI cache for partition {} with {} owned records from total {} RLI records.",
+ partitionPath, cache.size(), totalCnt.get());
+ return cache;
+ } catch (Exception e) {
+ cache.close();
+ throw new HoodieException("Failed to bootstrap partitioned RLI cache for partition " + partitionPath, e);
+ }
+ }
+
+ private BucketCache createBucketCache(String partitionPath) {
+ long inferredCacheSize = inferMemorySizeForCache();
+ cleanIfNecessary(inferredCacheSize, partitionPath);
+ return newBucketCache(createSpillableMap(partitionPath, inferredCacheSize), Long.MIN_VALUE);
+ }
+
+ private ExternalSpillableMap<String, Integer> createSpillableMap(String partitionPath, long inferredCacheSize) {
+ // preserve some memory for fileId dict, assuming the average file group number as Short.MAX_VALUE, then the size will be about 1MB.
+ long maxInMemorySizeInBytes = Math.max(inferredCacheSize - BucketCache.FILE_ID_DICT_ENTRY_SIZE * Short.MAX_VALUE, 1);
+ try {
+ return new ExternalSpillableMap<>(
+ maxInMemorySizeInBytes,
+ writeConfig.getSpillableMapBasePath(),
+ new DefaultSizeEstimator<>(),
+ new DefaultSizeEstimator<>(),
+ ExternalSpillableMap.DiskMapType.ROCKS_DB,
+ new DefaultSerializer<>(),
+ writeConfig.getBoolean(HoodieCommonConfig.DISK_MAP_BITCASK_COMPRESSION_ENABLED),
+ "PartitionedRLICache-" + partitionPath);
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create partitioned RLI cache for partition " + partitionPath, e);
+ }
}
private void reloadMetadataTable() {
+ closeMetadataTable();
this.metadataTable = metaClient.getTableFormat().getMetadataFactory().create(
HoodieFlinkEngineContext.DEFAULT,
metaClient.getStorage(),
StreamerUtil.metadataConfig(conf),
conf.get(FlinkOptions.PATH));
}
+ private void updateEvictableCkp(long checkpointId) {
+ ValidationUtils.checkArgument(checkpointId >= minRetainedCheckpointId,
+ String.format("The minimum retained checkpoint id should be increased, previous: %s, received: %s",
+ minRetainedCheckpointId, checkpointId));
+ minRetainedCheckpointId = checkpointId;
+ }
+
+ private long inferMemorySizeForCache() {
+ if (partitionBucketCaches.isEmpty()) {
+ return maxCacheSizeInBytes / 2;
+ }
+ long averageMemorySize = getCurrentHeapSize() / partitionBucketCaches.size();
+ if (averageMemorySize <= 0) {
+ return maxCacheSizeInBytes / 2;
+ }
+ return averageMemorySize;
+ }
+
+ private long getCurrentHeapSize() {
+ return partitionBucketCaches.values().stream()
+ .map(BucketCache::getHeapSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ @VisibleForTesting
+ void cleanIfNecessary(long nextCacheSize, String protectedPartitionPath) {
+ while (getCurrentHeapSize() + nextCacheSize > maxCacheSizeInBytes) {
+ boolean cleaned = false;
+ Iterator<Map.Entry<String, BucketCache>> iterator = partitionBucketCaches.entrySet().iterator();
+ while (iterator.hasNext()) {
+ Map.Entry<String, BucketCache> entry = iterator.next();
+ if (entry.getKey().equals(protectedPartitionPath)) {
+ continue;
+ }
+ BucketCache cache = entry.getValue();
+ if (cache.lastUpdatedCheckpoint < minRetainedCheckpointId) {
+ cache.close();
+ iterator.remove();
+ cleaned = true;
+ log.info("Evict partitioned RLI cache for partition {}", entry.getKey());
+ break;
+ }
+ }
+ if (!cleaned) {
+ return;
Review Comment:
add some doc why we can returns early
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165373558
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/PeriodicActionExecutor.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.utils;
+
+/**
+ * Executes an action after a fixed number of record updates.
+ */
+public class PeriodicActionExecutor {
Review Comment:
SamplingActionExecutor
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/PeriodicActionExecutor.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.sink.utils;
+
+/**
+ * Executes an action after a fixed number of record updates.
+ */
+public class PeriodicActionExecutor {
+ static final int DEFAULT_RECORD_INTERVAL = 1000;
+
+ private final int interval;
+ private long recordCnt;
+
+ public PeriodicActionExecutor() {
+ this(DEFAULT_RECORD_INTERVAL);
+ }
+
+ public PeriodicActionExecutor(int interval) {
Review Comment:
stepSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344042857
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.62%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|6|
>|spark-java-tests|18|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 47.62% -20.45%
+ Complexity 28913 17013 -11900
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15205 -2217
=============================================
- Hits 95695 55702 -39993
- Misses 37026 55117 +18091
+ Partials 7851 6134 -1717
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1566 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349757198
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.11%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.11% -0.96%
+ Complexity 28909 28548 -361
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 94499 -1185
- Misses 37032 38403 +1371
- Partials 7856 7901 +45
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <0.00%> (-3.50%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [179 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349465600
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.20%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.20% -0.87%
+ Complexity 28909 28610 -299
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 94621 -1063
- Misses 37032 38264 +1232
- Partials 7856 7912 +56
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <0.00%> (-3.82%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349613142
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.94%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 50 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|30|0|
>|spark-scala-tests|17|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 44.94% -23.13%
+ Complexity 28909 8527 -20382
=============================================
Files 2518 1201 -1317
Lines 140572 62652 -77920
Branches 17422 6778 -10644
=============================================
- Hits 95684 28160 -67524
+ Misses 37032 31386 -5646
+ Partials 7856 3106 -4750
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `50.58% <0.00%> (-33.28%)` | :arrow_down: |
... and [2117 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165381532
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/RecordLevelIndexBackend.java:
##########
@@ -19,125 +19,378 @@
package org.apache.hudi.sink.partitioner.index;
import org.apache.hudi.client.common.HoodieFlinkEngineContext;
-import org.apache.hudi.common.data.HoodieListData;
+import org.apache.hudi.common.config.HoodieCommonConfig;
import org.apache.hudi.common.data.HoodiePairData;
+import org.apache.hudi.common.model.FileSlice;
import org.apache.hudi.common.model.HoodieRecordGlobalLocation;
+import org.apache.hudi.common.serialization.DefaultSerializer;
import org.apache.hudi.common.table.HoodieTableMetaClient;
-import org.apache.hudi.common.util.HoodieDataUtils;
+import org.apache.hudi.common.util.DefaultSizeEstimator;
+import org.apache.hudi.common.util.ValidationUtils;
import org.apache.hudi.common.util.VisibleForTesting;
-import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.OptionsResolver;
import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
import org.apache.hudi.metadata.HoodieTableMetadata;
+import org.apache.hudi.metadata.MetadataPartitionType;
import org.apache.hudi.sink.event.Correspondent;
+import org.apache.hudi.sink.utils.PeriodicActionExecutor;
+import org.apache.hudi.util.FlinkWriteClients;
import org.apache.hudi.util.StreamerUtil;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.flink.configuration.Configuration;
+import java.io.Closeable;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
/**
- * An implementation of {@link IndexBackend} based on the record level index in metadata table.
+ * Partition-scoped index backend backed by partitioned record level index.
+ *
+ * <p>The backend keeps a lazy cache per data partition. Each cache maps record keys owned by the
+ * current Flink assign subtask to the file group id stored in the partitioned RLI. New records are
+ * added to the cache after bucket assignment, while existing records keep their original RLI routing.
+ *
+ * <p>Partition caches are evicted lazily: checkpoint completion only advances the safe eviction
+ * watermark, and cleanup happens when the total in-memory cache size exceeds
+ * {@link FlinkOptions#INDEX_RLI_CACHE_SIZE}.
*/
@Slf4j
-public class RecordLevelIndexBackend implements MinibatchIndexBackend {
- @VisibleForTesting
- @Getter
- private final RecordIndexCache recordIndexCache;
+public class RecordLevelIndexBackend implements PartitionedIndexBackend {
+
private final Configuration conf;
+ private final HoodieWriteConfig writeConfig;
private final HoodieTableMetaClient metaClient;
+ private final boolean isInsertOverwrite;
+ private final long maxCacheSizeInBytes;
+ private final BootstrapFilter bootstrapFilter;
private HoodieTableMetadata metadataTable;
- public RecordLevelIndexBackend(Configuration conf, long initCheckpointId) {
- this.metaClient = StreamerUtil.createMetaClient(conf);
+ @Getter
+ private final Map<String, BucketCache> partitionBucketCaches = new LinkedHashMap<>(16, 0.75f, true);
+ private long currentCheckpointId = -1L;
+ private long minRetainedCheckpointId = Long.MIN_VALUE;
+ private final PeriodicActionExecutor memoryCheckExecutor = new PeriodicActionExecutor();
+
+ /**
+ * Creates a partitioned RLI backend with custom ownership filtering.
+ *
+ * <p>This constructor is used by simple bucket index, whose write ownership is determined by
+ * partition and bucket file id rather than Flink record-key key groups.
+ *
+ * @param conf Flink write configuration
+ * @param bootstrapFilter filter for deciding whether a bootstrapped RLI record belongs to this task
+ */
+ public RecordLevelIndexBackend(Configuration conf, BootstrapFilter bootstrapFilter) {
this.conf = conf;
- this.recordIndexCache = new RecordIndexCache(conf, initCheckpointId);
+ this.writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, false, false);
+ this.metaClient = StreamerUtil.createMetaClient(conf);
+ this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(conf);
+ this.maxCacheSizeInBytes = conf.get(FlinkOptions.INDEX_RLI_CACHE_SIZE) * 1024 * 1024;
+ this.bootstrapFilter = bootstrapFilter;
reloadMetadataTable();
}
@Override
- public HoodieRecordGlobalLocation get(String recordKey) throws IOException {
- return get(Collections.singletonList(recordKey)).get(recordKey);
+ public String get(String partitionPath, String recordKey) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ return cache.getFileGroupId(recordKey);
}
@Override
- public void update(String recordKey, HoodieRecordGlobalLocation recordGlobalLocation) {
- recordIndexCache.update(recordKey, recordGlobalLocation);
+ public void update(String partitionPath, String recordKey, String fileId) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ cache.putRecordKey(recordKey, fileId, false);
+ memoryCheckExecutor.runIfNecessary(() -> cleanIfNecessary(0L, partitionPath));
}
+ /**
+ * Records the latest checkpoint id seen by this assign subtask.
+ *
+ * <p>New record-key mappings written after this point are tagged with the checkpoint id so lazy
+ * eviction can avoid removing partition caches that may still be needed for recovery.
+ *
+ * @param checkpointId checkpoint id from the bucket assign operator
+ */
@Override
- public Map<String, HoodieRecordGlobalLocation> get(List<String> recordKeys) throws IOException {
- // use a linked hash map to keep the natural order.
- Map<String, HoodieRecordGlobalLocation> keysAndLocations = new LinkedHashMap<>();
- List<String> missedKeys = new ArrayList<>();
- for (String key: recordKeys) {
- HoodieRecordGlobalLocation location = recordIndexCache.get(key);
- if (location == null) {
- missedKeys.add(key);
- }
- // insert anyway even the location is null to keep the natural order.
- keysAndLocations.put(key, location);
- }
- if (!missedKeys.isEmpty()) {
- HoodiePairData<String, HoodieRecordGlobalLocation> recordIndexData =
- metadataTable.readRecordIndexLocationsWithKeys(HoodieListData.eager(missedKeys));
- List<Pair<String, HoodieRecordGlobalLocation>> recordIndexLocations = HoodieDataUtils.dedupeAndCollectAsList(recordIndexData);
- recordIndexLocations.forEach(keyAndLocation -> {
- recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue());
- keysAndLocations.put(keyAndLocation.getKey(), keyAndLocation.getValue());
- });
- }
- return keysAndLocations;
+ public void onCheckpoint(long checkpointId) {
+ this.currentCheckpointId = checkpointId;
}
+ /**
+ * Advances the lazy eviction watermark after a completed checkpoint.
+ *
+ * <p>The watermark is derived from the minimum inflight checkpoint so caches that may still be
+ * needed for recovery are retained. Metadata table state is reloaded after the coordinator has
+ * committed or advanced instants for the completed checkpoint.
+ *
+ * @param correspondent writer coordinator correspondent used to query inflight instants
+ * @param completedCheckpointId completed checkpoint id reported by Flink
+ */
@Override
- public void update(List<Pair<String, HoodieRecordGlobalLocation>> recordKeysAndLocations) throws IOException {
- recordKeysAndLocations.forEach(keyAndLocation -> recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue()));
+ public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointId) {
+ Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
+ updateEvictableCkp(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointId));
+ metaClient.reloadActiveTimeline();
+ reloadMetadataTable();
}
- @Override
- public void onCheckpoint(long checkpointId) {
- recordIndexCache.addCheckpointCache(checkpointId);
+ private BucketCache getOrBootstrapPartition(String partitionPath) {
+ BucketCache cache = partitionBucketCaches.get(partitionPath);
+ if (cache != null) {
+ return cache;
+ }
+
+ cache = isInsertOverwrite ? createBucketCache(partitionPath) : bootstrapPartition(partitionPath);
+ partitionBucketCaches.put(partitionPath, cache);
+ cleanIfNecessary(0L, partitionPath);
+ return cache;
}
- @Override
- public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointID) {
- Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
- log.info("Inflight instants and the corresponding checkpoints: {}, notified completed checkpoints: {}",
- inflightInstants, completedCheckpointID);
- // if there are no inflight instants,
- // the latest completed checkpoint id is used as the minimum checkpoint id,
- // since the streaming write operator always uses previous checkpoint id to request the new instant.
- recordIndexCache.markAsEvictable(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointID));
- this.metaClient.reloadActiveTimeline();
- reloadMetadataTable();
+ private BucketCache bootstrapPartition(String partitionPath) {
+ BucketCache cache = createBucketCache(partitionPath);
+ if (!metaClient.getTableConfig().isMetadataPartitionAvailable(MetadataPartitionType.RECORD_INDEX)) {
+ log.info("Record index is not available yet. Start partitioned RLI cache empty for partition {}", partitionPath);
+ return cache;
+ }
+
+ try {
+ Map<String, List<FileSlice>> partitionedFileGroups =
+ metadataTable.getBucketizedFileGroupsForPartitionedRLI(MetadataPartitionType.RECORD_INDEX);
+ List<FileSlice> fileSlices = partitionedFileGroups.get(partitionPath);
+ if (fileSlices == null || fileSlices.isEmpty()) {
+ return cache;
+ }
+ HoodiePairData<String, HoodieRecordGlobalLocation> locations =
+ metadataTable.readRecordIndexLocations(fileSlicesToFilter -> fileSlices);
+ final AtomicLong totalCnt = new AtomicLong();
+ locations.forEach(locationPair -> {
+ String recordKey = locationPair.getLeft();
+ String fileId = locationPair.getRight().getFileId();
+ if (bootstrapFilter.shouldLoad(partitionPath, recordKey, fileId)) {
+ cache.putRecordKey(recordKey, fileId, true);
+ }
+ totalCnt.incrementAndGet();
+ });
+ log.info("Bootstrapped partitioned RLI cache for partition {} with {} owned records from total {} RLI records.",
+ partitionPath, cache.size(), totalCnt.get());
+ return cache;
+ } catch (Exception e) {
+ cache.close();
+ throw new HoodieException("Failed to bootstrap partitioned RLI cache for partition " + partitionPath, e);
+ }
+ }
+
+ private BucketCache createBucketCache(String partitionPath) {
+ long inferredCacheSize = inferMemorySizeForCache();
+ cleanIfNecessary(inferredCacheSize, partitionPath);
+ return newBucketCache(createSpillableMap(partitionPath, inferredCacheSize), Long.MIN_VALUE);
+ }
+
+ private ExternalSpillableMap<String, Integer> createSpillableMap(String partitionPath, long inferredCacheSize) {
+ // preserve some memory for fileId dict, assuming the average file group number as Short.MAX_VALUE, then the size will be about 1MB.
+ long maxInMemorySizeInBytes = Math.max(inferredCacheSize - BucketCache.FILE_ID_DICT_ENTRY_SIZE * Short.MAX_VALUE, 1);
+ try {
+ return new ExternalSpillableMap<>(
+ maxInMemorySizeInBytes,
+ writeConfig.getSpillableMapBasePath(),
+ new DefaultSizeEstimator<>(),
+ new DefaultSizeEstimator<>(),
+ ExternalSpillableMap.DiskMapType.ROCKS_DB,
+ new DefaultSerializer<>(),
+ writeConfig.getBoolean(HoodieCommonConfig.DISK_MAP_BITCASK_COMPRESSION_ENABLED),
+ "PartitionedRLICache-" + partitionPath);
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create partitioned RLI cache for partition " + partitionPath, e);
+ }
}
private void reloadMetadataTable() {
+ closeMetadataTable();
this.metadataTable = metaClient.getTableFormat().getMetadataFactory().create(
HoodieFlinkEngineContext.DEFAULT,
metaClient.getStorage(),
StreamerUtil.metadataConfig(conf),
conf.get(FlinkOptions.PATH));
}
+ private void updateEvictableCkp(long checkpointId) {
+ ValidationUtils.checkArgument(checkpointId >= minRetainedCheckpointId,
+ String.format("The minimum retained checkpoint id should be increased, previous: %s, received: %s",
+ minRetainedCheckpointId, checkpointId));
+ minRetainedCheckpointId = checkpointId;
+ }
+
+ private long inferMemorySizeForCache() {
+ if (partitionBucketCaches.isEmpty()) {
+ return maxCacheSizeInBytes / 2;
Review Comment:
why 2 here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349469789
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.97%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.97% -0.09%
- Complexity 28909 28927 +18
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95712 +28
- Misses 37032 37220 +188
- Partials 7856 7865 +9
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.31% <0.00%> (-0.33%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349536560
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28963 +54
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95821 +137
- Misses 37032 37107 +75
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <0.00%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349863840
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95817 +133
- Misses 37032 37117 +85
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.64% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349805442
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.04% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95815 +131
- Misses 37032 37119 +87
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <0.00%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349590937
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
}, {
"hash" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741",
"triggerID" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"triggerType" : "PUSH"
}, {
"hash" : "7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e",
"triggerType" : "PUSH"
}, {
"hash" : "3587d3640ec016284e7667655820c5c6aa652999",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13743",
"triggerID" : "3587d3640ec016284e7667655820c5c6aa652999",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebe621ace81729f610a1752a63233ac53b69ff9f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741)
* 7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e UNKNOWN
* 3587d3640ec016284e7667655820c5c6aa652999 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13743)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349280199
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
}, {
"hash" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741",
"triggerID" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d13219446a416ca61eba9636c7d201817eb1502 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726)
* ebe621ace81729f610a1752a63233ac53b69ff9f Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349453923
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.09%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 65.09% -2.98%
+ Complexity 28909 27706 -1203
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 91652 -4032
- Misses 37032 41241 +4209
- Partials 7856 7904 +48
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <0.00%> (-17.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.48% <0.00%> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [377 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349464418
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.12%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.12% -0.95%
+ Complexity 28909 28564 -345
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 94508 -1176
- Misses 37032 38390 +1358
- Partials 7856 7899 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.48% <0.00%> (-4.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [175 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349470588
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.97%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.97% -0.09%
- Complexity 28909 28927 +18
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95712 +28
- Misses 37032 37220 +188
- Partials 7856 7865 +9
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.31% <0.00%> (-0.33%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [28 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349797223
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.04% -0.03%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95813 +129
- Misses 37032 37120 +88
- Partials 7856 7870 +14
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.54% <0.00%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [16 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344062026
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.66%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|6|
>|spark-java-tests|18|4|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 47.66% -20.42%
+ Complexity 28913 17022 -11891
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15205 -2217
=============================================
- Hits 95695 55743 -39952
- Misses 37026 55086 +18060
+ Partials 7851 6124 -1727
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.04% <0.00%> (-16.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1566 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4343991747
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.58%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 31 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|1|
>|spark-java-tests|18|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 46.58% -21.50%
+ Complexity 28913 15214 -13699
=============================================
Files 2518 1961 -557
Lines 140572 106898 -33674
Branches 17422 13017 -4405
=============================================
- Hits 95695 49795 -45900
- Misses 37026 51922 +14896
+ Partials 7851 5181 -2670
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.02% <0.00%> (-11.68%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `57.65% <0.00%> (-26.21%)` | :arrow_down: |
... and [1687 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344203117
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.88%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 66.88% -1.19%
+ Complexity 28913 28414 -499
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94174 -1521
- Misses 37026 38729 +1703
- Partials 7851 7887 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.82% <0.00%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <0.00%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [204 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344231919
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.26%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 67.26% -0.82%
+ Complexity 28913 28627 -286
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94700 -995
- Misses 37026 38176 +1150
- Partials 7851 7914 +63
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <0.00%> (-3.60%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349689122
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.18%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 46 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|2|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 48.18% -19.88%
+ Complexity 28909 16440 -12469
=============================================
Files 2518 2012 -506
Lines 140572 112055 -28517
Branches 17422 14120 -3302
=============================================
- Hits 95684 53999 -41685
- Misses 37032 52355 +15323
+ Partials 7856 5701 -2155
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <0.00%> (-15.53%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.97% <0.00%> (-11.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1616 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4343736119
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d13219446a416ca61eba9636c7d201817eb1502 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165376324
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -459,7 +470,8 @@ public static boolean isPopulateMetaFields(Configuration conf) {
*/
public static boolean isStreamingIndexWriteEnabled(Configuration conf) {
return conf.get(FlinkOptions.METADATA_ENABLED)
- && OptionsResolver.getIndexType(conf) == HoodieIndex.IndexType.GLOBAL_RECORD_LEVEL_INDEX
+ && (OptionsResolver.getIndexType(conf) == HoodieIndex.IndexType.GLOBAL_RECORD_LEVEL_INDEX
+ || OptionsResolver.isSimpleBucketIndexWithRecordLevelIndex(conf))
Review Comment:
so we are impl the partitioned RLI based on bucket index file group id naming convention?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165431793
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -459,7 +470,8 @@ public static boolean isPopulateMetaFields(Configuration conf) {
*/
public static boolean isStreamingIndexWriteEnabled(Configuration conf) {
return conf.get(FlinkOptions.METADATA_ENABLED)
- && OptionsResolver.getIndexType(conf) == HoodieIndex.IndexType.GLOBAL_RECORD_LEVEL_INDEX
+ && (OptionsResolver.getIndexType(conf) == HoodieIndex.IndexType.GLOBAL_RECORD_LEVEL_INDEX
+ || OptionsResolver.isSimpleBucketIndexWithRecordLevelIndex(conf))
Review Comment:
yes, `RecordLevelIndexBackend` is using dictionary encoding for the bucket assign cache, which is used to reduce storage cost both for the streaming rli for simple bucket index, and the following pr for dynamic bucket support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349447982
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 65.04% -3.02%
+ Complexity 28909 27674 -1235
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 91587 -4097
- Misses 37032 41319 +4287
- Partials 7856 7891 +35
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <0.00%> (-17.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <0.00%> (-0.30%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [381 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349705031
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.38%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 41 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|3|
>|spark-scala-tests|17|5|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.38% -20.69%
+ Complexity 28909 16871 -12038
=============================================
Files 2518 2047 -471
Lines 140572 116955 -23617
Branches 17422 15205 -2217
=============================================
- Hits 95684 55419 -40265
- Misses 37032 55506 +18474
+ Partials 7856 6030 -1826
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <0.00%> (-16.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.74% <0.00%> (-11.97%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1571 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349768787
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.16%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.16% -0.91%
+ Complexity 28909 28584 -325
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 94565 -1119
- Misses 37032 38331 +1299
- Partials 7856 7907 +51
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.32% <0.00%> (-3.32%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [168 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349849906
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95817 +133
- Misses 37032 37117 +85
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.64% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344170934
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.82%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 66.82% -1.26%
+ Complexity 28913 28382 -531
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94078 -1617
- Misses 37026 38814 +1788
- Partials 7851 7898 +47
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.82% <0.00%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.48% <0.00%> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [223 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344140986
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.77%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 66.77% -1.31%
+ Complexity 28913 28350 -563
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94013 -1682
- Misses 37026 38892 +1866
- Partials 7851 7885 +34
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.82% <0.00%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <0.00%> (-0.31%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [227 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 closed pull request #18645: feat(flink): Support streaming RLI write for simple bucket index
URL: https://github.com/apache/hudi/pull/18645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344089204
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.65%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|6|
>|spark-java-tests|18|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 60.65% -7.43%
+ Complexity 28913 25798 -3115
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 85393 -10302
- Misses 37026 47937 +10911
+ Partials 7851 7460 -391
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <0.00%> (-17.00%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `73.32% <50.00%> (-10.54%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [559 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344234798
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.26%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 67.26% -0.82%
+ Complexity 28913 28627 -286
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94700 -995
- Misses 37026 38176 +1150
- Partials 7851 7914 +63
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <0.00%> (-3.60%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349426168
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.69%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 36 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|6|
>|spark-scala-tests|17|6|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 53.69% -14.37%
+ Complexity 28909 18979 -9930
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15202 -2220
=============================================
- Hits 95684 62803 -32881
- Misses 37032 47417 +10385
+ Partials 7856 6733 -1123
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <0.00%> (-17.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `69.38% <0.00%> (-14.48%)` | :arrow_down: |
... and [1435 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349417732
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.66%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 38 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|5|
>|spark-scala-tests|17|6|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.66% -20.41%
+ Complexity 28909 17028 -11881
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15202 -2220
=============================================
- Hits 95684 55748 -39936
- Misses 37032 55080 +18048
+ Partials 7856 6125 -1731
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.98% <0.00%> (-16.67%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165397396
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -459,7 +470,8 @@ public static boolean isPopulateMetaFields(Configuration conf) {
*/
public static boolean isStreamingIndexWriteEnabled(Configuration conf) {
return conf.get(FlinkOptions.METADATA_ENABLED)
- && OptionsResolver.getIndexType(conf) == HoodieIndex.IndexType.GLOBAL_RECORD_LEVEL_INDEX
+ && (OptionsResolver.getIndexType(conf) == HoodieIndex.IndexType.GLOBAL_RECORD_LEVEL_INDEX
+ || OptionsResolver.isSimpleBucketIndexWithRecordLevelIndex(conf))
Review Comment:
seems not because I saw some dictionary encoding from general UUID to integer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349485125
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.04% -0.02%
- Complexity 28909 28963 +54
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95812 +128
- Misses 37032 37116 +84
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.56% <0.00%> (-0.09%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349572721
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
}, {
"hash" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741",
"triggerID" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"triggerType" : "PUSH"
}, {
"hash" : "7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebe621ace81729f610a1752a63233ac53b69ff9f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741)
* 7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349725187
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.63%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 36 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|5|
>|spark-scala-tests|17|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 60.63% -7.44%
+ Complexity 28909 25791 -3118
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 85369 -10315
- Misses 37032 47969 +10937
+ Partials 7856 7465 -391
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.04% <0.00%> (-16.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `73.32% <50.00%> (-10.54%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [563 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349708907
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.63%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 40 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|3|
>|spark-scala-tests|17|6|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.63% -20.44%
+ Complexity 28909 17012 -11897
=============================================
Files 2518 2047 -471
Lines 140572 116955 -23617
Branches 17422 15205 -2217
=============================================
- Hits 95684 55711 -39973
- Misses 37032 55115 +18083
+ Partials 7856 6129 -1727
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.42% <0.00%> (-16.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349733145
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.01%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 65.01% -3.06%
+ Complexity 28909 27658 -1251
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 91546 -4138
- Misses 37032 41361 +4329
- Partials 7856 7896 +40
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.04% <0.00%> (-16.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <0.00%> (-0.30%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [384 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349751038
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.97%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 66.97% -1.10%
+ Complexity 28909 28474 -435
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 94299 -1385
- Misses 37032 38601 +1569
- Partials 7856 7903 +47
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <0.00%> (-3.50%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.48% <0.00%> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [208 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349778693
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.20%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.20% -0.87%
+ Complexity 28909 28597 -312
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 94622 -1062
- Misses 37032 38271 +1239
- Partials 7856 7910 +54
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <0.00%> (-3.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [154 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349786498
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.04% -0.03%
- Complexity 28909 28949 +40
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95808 +124
- Misses 37032 37122 +90
- Partials 7856 7873 +17
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <0.00%> (-0.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [19 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349371521
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.65%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 49 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|30|0|
>|spark-scala-tests|17|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 39.65% -28.42%
+ Complexity 28909 12535 -16374
=============================================
Files 2518 1961 -557
Lines 140572 106957 -33615
Branches 17422 12967 -4455
=============================================
- Hits 95684 42412 -53272
- Misses 37032 59412 +22380
+ Partials 7856 5133 -2723
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <0.00%> (-11.69%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `57.29% <0.00%> (-26.57%)` | :arrow_down: |
... and [1881 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165393634
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/RecordIndexPartitioner.java:
##########
@@ -30,47 +34,92 @@
import org.apache.flink.api.common.functions.Partitioner;
import org.apache.flink.configuration.Configuration;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
/**
- * Record index input partitioner, which is aligned with the mapping of record key
+ * Partitioned record index input partitioner, which is aligned with the mapping of record key
* to the file group of record index partition in metadata table. It prevents multiple
* index write subtasks from writing the same record index file group, thereby effectively
* reducing the number of small files.
+ *
+ * <p>The partitioner first spreads data partitions across downstream tasks, then maps
+ * record keys to the subtask for the selected record-index file group.
*/
public class RecordIndexPartitioner implements Partitioner<HoodieKey> {
private final Configuration conf;
+ private Map<String, Integer> partitionedRLIFileGroupCounts;
+ private Functions.Function3<Integer, String, Integer, Integer> partitionIndexFunc;
+
/**
- * The number of file groups for record index partition in metadata data table. The number
- * cannot be calculated during compiling the writing pipeline, since the hoodie table may
- * not be created yet, so the number is lazily calculated during job running.
+ * Creates a partitioner for partitioned RLI index writes.
+ *
+ * @param conf Flink write configuration
*/
- private int numFileGroupsForRecordIndexPartition = -1;
-
public RecordIndexPartitioner(Configuration conf) {
this.conf = conf;
}
+ /**
+ * Routes an index row by data partition and record-key-derived partitioned RLI file group.
Review Comment:
can you explain in high-level that's the motive here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349523811
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28963 +54
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95821 +137
- Misses 37032 37107 +75
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.60% <0.00%> (-0.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349475973
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.04% -0.02%
- Complexity 28909 28963 +54
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95809 +125
- Misses 37032 37117 +85
- Partials 7856 7871 +15
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.53% <0.00%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349696597
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.79%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 44 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|4|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.79% -20.28%
+ Complexity 28909 16644 -12265
=============================================
Files 2518 2030 -488
Lines 140572 114588 -25984
Branches 17422 14696 -2726
=============================================
- Hits 95684 54763 -40921
- Misses 37032 53966 +16934
+ Partials 7856 5859 -1997
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <0.00%> (-15.53%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.92% <0.00%> (-11.78%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1582 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349673050
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 39.70%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 49 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|30|0|
>|spark-scala-tests|17|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 39.70% -28.37%
+ Complexity 28909 12558 -16351
=============================================
Files 2518 1964 -554
Lines 140572 106917 -33655
Branches 17422 13005 -4417
=============================================
- Hits 95684 42449 -53235
- Misses 37032 59340 +22308
+ Partials 7856 5128 -2728
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <0.00%> (-11.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `57.29% <0.00%> (-26.57%)` | :arrow_down: |
... and [1897 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344285088
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 68.04% -0.04%
- Complexity 28913 28944 +31
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
+ Hits 95695 95794 +99
- Misses 37026 37128 +102
- Partials 7851 7868 +17
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.55% <0.00%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344429268
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 68.04% -0.03%
- Complexity 28913 28945 +32
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
+ Hits 95695 95804 +109
- Misses 37026 37118 +92
- Partials 7851 7868 +17
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.66% <0.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349746034
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.06%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 65.06% -3.01%
+ Complexity 28909 27690 -1219
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 91611 -4073
- Misses 37032 41283 +4251
- Partials 7856 7909 +53
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.04% <0.00%> (-16.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.48% <0.00%> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [380 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349793256
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.04% -0.03%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95811 +127
- Misses 37032 37121 +89
- Partials 7856 7871 +15
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.12%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [18 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349755732
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.11%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.11% -0.96%
+ Complexity 28909 28548 -361
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 94499 -1185
- Misses 37032 38403 +1371
- Partials 7856 7901 +45
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <0.00%> (-3.50%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [179 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4357717135
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95817 +133
- Misses 37032 37117 +85
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <0.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3168485626
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/RecordLevelIndexBackend.java:
##########
@@ -19,125 +19,382 @@
package org.apache.hudi.sink.partitioner.index;
import org.apache.hudi.client.common.HoodieFlinkEngineContext;
-import org.apache.hudi.common.data.HoodieListData;
+import org.apache.hudi.common.config.HoodieCommonConfig;
import org.apache.hudi.common.data.HoodiePairData;
+import org.apache.hudi.common.model.FileSlice;
import org.apache.hudi.common.model.HoodieRecordGlobalLocation;
+import org.apache.hudi.common.serialization.DefaultSerializer;
import org.apache.hudi.common.table.HoodieTableMetaClient;
-import org.apache.hudi.common.util.HoodieDataUtils;
+import org.apache.hudi.common.util.DefaultSizeEstimator;
+import org.apache.hudi.common.util.ValidationUtils;
import org.apache.hudi.common.util.VisibleForTesting;
-import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.OptionsResolver;
import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
import org.apache.hudi.metadata.HoodieTableMetadata;
+import org.apache.hudi.metadata.MetadataPartitionType;
import org.apache.hudi.sink.event.Correspondent;
+import org.apache.hudi.sink.utils.SamplingActionExecutor;
+import org.apache.hudi.util.FlinkWriteClients;
import org.apache.hudi.util.StreamerUtil;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.flink.configuration.Configuration;
+import java.io.Closeable;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
/**
- * An implementation of {@link IndexBackend} based on the record level index in metadata table.
+ * Partition-scoped index backend backed by partitioned record level index.
+ *
+ * <p>The backend keeps a lazy cache per data partition. Each cache maps record keys owned by the
+ * current Flink assign subtask to the file group id stored in the partitioned RLI. New records are
+ * added to the cache after bucket assignment, while existing records keep their original RLI routing.
+ *
+ * <p>Partition caches are evicted lazily: checkpoint completion only advances the safe eviction
+ * watermark, and cleanup happens when the total in-memory cache size exceeds
+ * {@link FlinkOptions#INDEX_RLI_CACHE_SIZE}.
*/
@Slf4j
-public class RecordLevelIndexBackend implements MinibatchIndexBackend {
- @VisibleForTesting
- @Getter
- private final RecordIndexCache recordIndexCache;
+public class RecordLevelIndexBackend implements PartitionedIndexBackend {
+
private final Configuration conf;
+ private final HoodieWriteConfig writeConfig;
private final HoodieTableMetaClient metaClient;
+ private final boolean isInsertOverwrite;
+ private final long maxCacheSizeInBytes;
+ private final BootstrapFilter bootstrapFilter;
private HoodieTableMetadata metadataTable;
- public RecordLevelIndexBackend(Configuration conf, long initCheckpointId) {
- this.metaClient = StreamerUtil.createMetaClient(conf);
+ @Getter
+ private final Map<String, BucketCache> partitionBucketCaches = new LinkedHashMap<>(16, 0.75f, true);
+ private long currentCheckpointId = -1L;
+ private long minRetainedCheckpointId = Long.MIN_VALUE;
+ private final SamplingActionExecutor memoryCheckExecutor = new SamplingActionExecutor();
+
+ /**
+ * Creates a partitioned RLI backend with custom ownership filtering.
+ *
+ * <p>This constructor is used by simple bucket index, whose write ownership is determined by
+ * partition and bucket file id rather than Flink record-key key groups.
+ *
+ * @param conf Flink write configuration
+ * @param bootstrapFilter filter for deciding whether a bootstrapped RLI record belongs to this task
+ */
+ public RecordLevelIndexBackend(Configuration conf, BootstrapFilter bootstrapFilter) {
this.conf = conf;
- this.recordIndexCache = new RecordIndexCache(conf, initCheckpointId);
+ this.writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, false, false);
+ this.metaClient = StreamerUtil.createMetaClient(conf);
+ this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(conf);
+ this.maxCacheSizeInBytes = conf.get(FlinkOptions.INDEX_RLI_CACHE_SIZE) * 1024 * 1024;
+ this.bootstrapFilter = bootstrapFilter;
reloadMetadataTable();
}
@Override
- public HoodieRecordGlobalLocation get(String recordKey) throws IOException {
- return get(Collections.singletonList(recordKey)).get(recordKey);
+ public String get(String partitionPath, String recordKey) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ return cache.getFileGroupId(recordKey);
}
@Override
- public void update(String recordKey, HoodieRecordGlobalLocation recordGlobalLocation) {
- recordIndexCache.update(recordKey, recordGlobalLocation);
+ public void update(String partitionPath, String recordKey, String fileId) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ cache.putRecordKey(recordKey, fileId, false);
+ memoryCheckExecutor.runIfNecessary(() -> cleanIfNecessary(0L, partitionPath));
}
+ /**
+ * Records the latest checkpoint id seen by this assign subtask.
+ *
+ * <p>New record-key mappings written after this point are tagged with the checkpoint id so lazy
+ * eviction can avoid removing partition caches that may still be needed for recovery.
+ *
+ * @param checkpointId checkpoint id from the bucket assign operator
+ */
@Override
- public Map<String, HoodieRecordGlobalLocation> get(List<String> recordKeys) throws IOException {
- // use a linked hash map to keep the natural order.
- Map<String, HoodieRecordGlobalLocation> keysAndLocations = new LinkedHashMap<>();
- List<String> missedKeys = new ArrayList<>();
- for (String key: recordKeys) {
- HoodieRecordGlobalLocation location = recordIndexCache.get(key);
- if (location == null) {
- missedKeys.add(key);
- }
- // insert anyway even the location is null to keep the natural order.
- keysAndLocations.put(key, location);
- }
- if (!missedKeys.isEmpty()) {
- HoodiePairData<String, HoodieRecordGlobalLocation> recordIndexData =
- metadataTable.readRecordIndexLocationsWithKeys(HoodieListData.eager(missedKeys));
- List<Pair<String, HoodieRecordGlobalLocation>> recordIndexLocations = HoodieDataUtils.dedupeAndCollectAsList(recordIndexData);
- recordIndexLocations.forEach(keyAndLocation -> {
- recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue());
- keysAndLocations.put(keyAndLocation.getKey(), keyAndLocation.getValue());
- });
- }
- return keysAndLocations;
+ public void onCheckpoint(long checkpointId) {
+ this.currentCheckpointId = checkpointId;
}
+ /**
+ * Advances the lazy eviction watermark after a completed checkpoint.
+ *
+ * <p>The watermark is derived from the minimum inflight checkpoint so caches that may still be
+ * needed for recovery are retained. Metadata table state is reloaded after the coordinator has
+ * committed or advanced instants for the completed checkpoint.
+ *
+ * @param correspondent writer coordinator correspondent used to query inflight instants
+ * @param completedCheckpointId completed checkpoint id reported by Flink
+ */
@Override
- public void update(List<Pair<String, HoodieRecordGlobalLocation>> recordKeysAndLocations) throws IOException {
- recordKeysAndLocations.forEach(keyAndLocation -> recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue()));
+ public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointId) {
+ Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
+ updateEvictableCkp(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointId));
+ metaClient.reloadActiveTimeline();
+ reloadMetadataTable();
}
- @Override
- public void onCheckpoint(long checkpointId) {
- recordIndexCache.addCheckpointCache(checkpointId);
+ private BucketCache getOrBootstrapPartition(String partitionPath) {
+ BucketCache cache = partitionBucketCaches.get(partitionPath);
+ if (cache != null) {
+ return cache;
+ }
+
+ cache = isInsertOverwrite ? createBucketCache(partitionPath) : bootstrapPartition(partitionPath);
+ partitionBucketCaches.put(partitionPath, cache);
+ cleanIfNecessary(0L, partitionPath);
+ return cache;
}
- @Override
- public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointID) {
- Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
- log.info("Inflight instants and the corresponding checkpoints: {}, notified completed checkpoints: {}",
- inflightInstants, completedCheckpointID);
- // if there are no inflight instants,
- // the latest completed checkpoint id is used as the minimum checkpoint id,
- // since the streaming write operator always uses previous checkpoint id to request the new instant.
- recordIndexCache.markAsEvictable(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointID));
- this.metaClient.reloadActiveTimeline();
- reloadMetadataTable();
+ private BucketCache bootstrapPartition(String partitionPath) {
+ BucketCache cache = createBucketCache(partitionPath);
+ if (!metaClient.getTableConfig().isMetadataPartitionAvailable(MetadataPartitionType.RECORD_INDEX)) {
+ log.info("Record index is not available yet. Start partitioned RLI cache empty for partition {}", partitionPath);
+ return cache;
+ }
+
+ try {
+ Map<String, List<FileSlice>> partitionedFileGroups =
+ metadataTable.getBucketizedFileGroupsForPartitionedRLI(MetadataPartitionType.RECORD_INDEX);
+ List<FileSlice> fileSlices = partitionedFileGroups.get(partitionPath);
+ if (fileSlices == null || fileSlices.isEmpty()) {
+ return cache;
+ }
+ HoodiePairData<String, HoodieRecordGlobalLocation> locations =
+ metadataTable.readRecordIndexLocations(fileSlicesToFilter -> fileSlices);
+ final AtomicLong totalCnt = new AtomicLong();
+ locations.forEach(locationPair -> {
+ String recordKey = locationPair.getLeft();
+ String fileId = locationPair.getRight().getFileId();
+ if (bootstrapFilter.shouldLoad(partitionPath, recordKey, fileId)) {
+ cache.putRecordKey(recordKey, fileId, true);
+ }
+ totalCnt.incrementAndGet();
+ });
+ log.info("Bootstrapped partitioned RLI cache for partition {} with {} owned records from total {} RLI records.",
+ partitionPath, cache.size(), totalCnt.get());
+ return cache;
+ } catch (Exception e) {
+ cache.close();
+ throw new HoodieException("Failed to bootstrap partitioned RLI cache for partition " + partitionPath, e);
+ }
+ }
+
+ private BucketCache createBucketCache(String partitionPath) {
+ long inferredCacheSize = inferMemorySizeForCache();
+ cleanIfNecessary(inferredCacheSize, partitionPath);
+ return newBucketCache(createSpillableMap(partitionPath, inferredCacheSize), Long.MIN_VALUE);
+ }
+
+ private ExternalSpillableMap<String, Integer> createSpillableMap(String partitionPath, long inferredCacheSize) {
+ // preserve some memory for fileId dict, assuming the average file group number as Short.MAX_VALUE, then the size will be about 1MB.
+ long maxInMemorySizeInBytes = Math.max(inferredCacheSize - BucketCache.FILE_ID_DICT_ENTRY_SIZE * Short.MAX_VALUE, 1);
+ try {
+ return new ExternalSpillableMap<>(
+ maxInMemorySizeInBytes,
+ writeConfig.getSpillableMapBasePath(),
+ new DefaultSizeEstimator<>(),
+ new DefaultSizeEstimator<>(),
+ ExternalSpillableMap.DiskMapType.ROCKS_DB,
+ new DefaultSerializer<>(),
+ writeConfig.getBoolean(HoodieCommonConfig.DISK_MAP_BITCASK_COMPRESSION_ENABLED),
+ "PartitionedRLICache-" + partitionPath);
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create partitioned RLI cache for partition " + partitionPath, e);
+ }
}
private void reloadMetadataTable() {
+ closeMetadataTable();
this.metadataTable = metaClient.getTableFormat().getMetadataFactory().create(
HoodieFlinkEngineContext.DEFAULT,
metaClient.getStorage(),
StreamerUtil.metadataConfig(conf),
conf.get(FlinkOptions.PATH));
}
+ private void updateEvictableCkp(long checkpointId) {
+ ValidationUtils.checkArgument(checkpointId >= minRetainedCheckpointId,
Review Comment:
🤖 Is `checkArgument(checkpointId >= minRetainedCheckpointId)` safe across all paths into `onCheckpointComplete`? If a coordinator returns inflight instants whose min checkpoint id is below the previously retained one (e.g. an unusual concurrent write, or a recovery scenario where the coordinator state lags the cache), this would throw IllegalArgumentException and crash the operator. Could it be relaxed to a `Math.max(...)` guard so we never regress, but also never fail hard?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/RecordLevelIndexBackend.java:
##########
@@ -19,125 +19,382 @@
package org.apache.hudi.sink.partitioner.index;
import org.apache.hudi.client.common.HoodieFlinkEngineContext;
-import org.apache.hudi.common.data.HoodieListData;
+import org.apache.hudi.common.config.HoodieCommonConfig;
import org.apache.hudi.common.data.HoodiePairData;
+import org.apache.hudi.common.model.FileSlice;
import org.apache.hudi.common.model.HoodieRecordGlobalLocation;
+import org.apache.hudi.common.serialization.DefaultSerializer;
import org.apache.hudi.common.table.HoodieTableMetaClient;
-import org.apache.hudi.common.util.HoodieDataUtils;
+import org.apache.hudi.common.util.DefaultSizeEstimator;
+import org.apache.hudi.common.util.ValidationUtils;
import org.apache.hudi.common.util.VisibleForTesting;
-import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.OptionsResolver;
import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
import org.apache.hudi.metadata.HoodieTableMetadata;
+import org.apache.hudi.metadata.MetadataPartitionType;
import org.apache.hudi.sink.event.Correspondent;
+import org.apache.hudi.sink.utils.SamplingActionExecutor;
+import org.apache.hudi.util.FlinkWriteClients;
import org.apache.hudi.util.StreamerUtil;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.flink.configuration.Configuration;
+import java.io.Closeable;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
/**
- * An implementation of {@link IndexBackend} based on the record level index in metadata table.
+ * Partition-scoped index backend backed by partitioned record level index.
+ *
+ * <p>The backend keeps a lazy cache per data partition. Each cache maps record keys owned by the
+ * current Flink assign subtask to the file group id stored in the partitioned RLI. New records are
+ * added to the cache after bucket assignment, while existing records keep their original RLI routing.
+ *
+ * <p>Partition caches are evicted lazily: checkpoint completion only advances the safe eviction
+ * watermark, and cleanup happens when the total in-memory cache size exceeds
+ * {@link FlinkOptions#INDEX_RLI_CACHE_SIZE}.
*/
@Slf4j
-public class RecordLevelIndexBackend implements MinibatchIndexBackend {
- @VisibleForTesting
- @Getter
- private final RecordIndexCache recordIndexCache;
+public class RecordLevelIndexBackend implements PartitionedIndexBackend {
+
private final Configuration conf;
+ private final HoodieWriteConfig writeConfig;
private final HoodieTableMetaClient metaClient;
+ private final boolean isInsertOverwrite;
+ private final long maxCacheSizeInBytes;
+ private final BootstrapFilter bootstrapFilter;
private HoodieTableMetadata metadataTable;
- public RecordLevelIndexBackend(Configuration conf, long initCheckpointId) {
- this.metaClient = StreamerUtil.createMetaClient(conf);
+ @Getter
+ private final Map<String, BucketCache> partitionBucketCaches = new LinkedHashMap<>(16, 0.75f, true);
+ private long currentCheckpointId = -1L;
+ private long minRetainedCheckpointId = Long.MIN_VALUE;
+ private final SamplingActionExecutor memoryCheckExecutor = new SamplingActionExecutor();
+
+ /**
+ * Creates a partitioned RLI backend with custom ownership filtering.
+ *
+ * <p>This constructor is used by simple bucket index, whose write ownership is determined by
+ * partition and bucket file id rather than Flink record-key key groups.
+ *
+ * @param conf Flink write configuration
+ * @param bootstrapFilter filter for deciding whether a bootstrapped RLI record belongs to this task
+ */
+ public RecordLevelIndexBackend(Configuration conf, BootstrapFilter bootstrapFilter) {
this.conf = conf;
- this.recordIndexCache = new RecordIndexCache(conf, initCheckpointId);
+ this.writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, false, false);
+ this.metaClient = StreamerUtil.createMetaClient(conf);
+ this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(conf);
+ this.maxCacheSizeInBytes = conf.get(FlinkOptions.INDEX_RLI_CACHE_SIZE) * 1024 * 1024;
+ this.bootstrapFilter = bootstrapFilter;
reloadMetadataTable();
}
@Override
- public HoodieRecordGlobalLocation get(String recordKey) throws IOException {
- return get(Collections.singletonList(recordKey)).get(recordKey);
+ public String get(String partitionPath, String recordKey) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ return cache.getFileGroupId(recordKey);
}
@Override
- public void update(String recordKey, HoodieRecordGlobalLocation recordGlobalLocation) {
- recordIndexCache.update(recordKey, recordGlobalLocation);
+ public void update(String partitionPath, String recordKey, String fileId) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ cache.putRecordKey(recordKey, fileId, false);
+ memoryCheckExecutor.runIfNecessary(() -> cleanIfNecessary(0L, partitionPath));
}
+ /**
+ * Records the latest checkpoint id seen by this assign subtask.
+ *
+ * <p>New record-key mappings written after this point are tagged with the checkpoint id so lazy
+ * eviction can avoid removing partition caches that may still be needed for recovery.
+ *
+ * @param checkpointId checkpoint id from the bucket assign operator
+ */
@Override
- public Map<String, HoodieRecordGlobalLocation> get(List<String> recordKeys) throws IOException {
- // use a linked hash map to keep the natural order.
- Map<String, HoodieRecordGlobalLocation> keysAndLocations = new LinkedHashMap<>();
- List<String> missedKeys = new ArrayList<>();
- for (String key: recordKeys) {
- HoodieRecordGlobalLocation location = recordIndexCache.get(key);
- if (location == null) {
- missedKeys.add(key);
- }
- // insert anyway even the location is null to keep the natural order.
- keysAndLocations.put(key, location);
- }
- if (!missedKeys.isEmpty()) {
- HoodiePairData<String, HoodieRecordGlobalLocation> recordIndexData =
- metadataTable.readRecordIndexLocationsWithKeys(HoodieListData.eager(missedKeys));
- List<Pair<String, HoodieRecordGlobalLocation>> recordIndexLocations = HoodieDataUtils.dedupeAndCollectAsList(recordIndexData);
- recordIndexLocations.forEach(keyAndLocation -> {
- recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue());
- keysAndLocations.put(keyAndLocation.getKey(), keyAndLocation.getValue());
- });
- }
- return keysAndLocations;
+ public void onCheckpoint(long checkpointId) {
+ this.currentCheckpointId = checkpointId;
}
+ /**
+ * Advances the lazy eviction watermark after a completed checkpoint.
+ *
+ * <p>The watermark is derived from the minimum inflight checkpoint so caches that may still be
+ * needed for recovery are retained. Metadata table state is reloaded after the coordinator has
+ * committed or advanced instants for the completed checkpoint.
+ *
+ * @param correspondent writer coordinator correspondent used to query inflight instants
+ * @param completedCheckpointId completed checkpoint id reported by Flink
+ */
@Override
- public void update(List<Pair<String, HoodieRecordGlobalLocation>> recordKeysAndLocations) throws IOException {
- recordKeysAndLocations.forEach(keyAndLocation -> recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue()));
+ public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointId) {
+ Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
+ updateEvictableCkp(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointId));
+ metaClient.reloadActiveTimeline();
+ reloadMetadataTable();
}
- @Override
- public void onCheckpoint(long checkpointId) {
- recordIndexCache.addCheckpointCache(checkpointId);
+ private BucketCache getOrBootstrapPartition(String partitionPath) {
+ BucketCache cache = partitionBucketCaches.get(partitionPath);
+ if (cache != null) {
+ return cache;
+ }
+
+ cache = isInsertOverwrite ? createBucketCache(partitionPath) : bootstrapPartition(partitionPath);
+ partitionBucketCaches.put(partitionPath, cache);
+ cleanIfNecessary(0L, partitionPath);
+ return cache;
}
- @Override
- public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointID) {
- Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
- log.info("Inflight instants and the corresponding checkpoints: {}, notified completed checkpoints: {}",
- inflightInstants, completedCheckpointID);
- // if there are no inflight instants,
- // the latest completed checkpoint id is used as the minimum checkpoint id,
- // since the streaming write operator always uses previous checkpoint id to request the new instant.
- recordIndexCache.markAsEvictable(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointID));
- this.metaClient.reloadActiveTimeline();
- reloadMetadataTable();
+ private BucketCache bootstrapPartition(String partitionPath) {
+ BucketCache cache = createBucketCache(partitionPath);
+ if (!metaClient.getTableConfig().isMetadataPartitionAvailable(MetadataPartitionType.RECORD_INDEX)) {
+ log.info("Record index is not available yet. Start partitioned RLI cache empty for partition {}", partitionPath);
+ return cache;
+ }
+
+ try {
+ Map<String, List<FileSlice>> partitionedFileGroups =
+ metadataTable.getBucketizedFileGroupsForPartitionedRLI(MetadataPartitionType.RECORD_INDEX);
+ List<FileSlice> fileSlices = partitionedFileGroups.get(partitionPath);
+ if (fileSlices == null || fileSlices.isEmpty()) {
+ return cache;
+ }
+ HoodiePairData<String, HoodieRecordGlobalLocation> locations =
+ metadataTable.readRecordIndexLocations(fileSlicesToFilter -> fileSlices);
+ final AtomicLong totalCnt = new AtomicLong();
+ locations.forEach(locationPair -> {
+ String recordKey = locationPair.getLeft();
+ String fileId = locationPair.getRight().getFileId();
+ if (bootstrapFilter.shouldLoad(partitionPath, recordKey, fileId)) {
+ cache.putRecordKey(recordKey, fileId, true);
+ }
+ totalCnt.incrementAndGet();
+ });
+ log.info("Bootstrapped partitioned RLI cache for partition {} with {} owned records from total {} RLI records.",
+ partitionPath, cache.size(), totalCnt.get());
+ return cache;
+ } catch (Exception e) {
+ cache.close();
+ throw new HoodieException("Failed to bootstrap partitioned RLI cache for partition " + partitionPath, e);
+ }
+ }
+
+ private BucketCache createBucketCache(String partitionPath) {
+ long inferredCacheSize = inferMemorySizeForCache();
+ cleanIfNecessary(inferredCacheSize, partitionPath);
+ return newBucketCache(createSpillableMap(partitionPath, inferredCacheSize), Long.MIN_VALUE);
+ }
+
+ private ExternalSpillableMap<String, Integer> createSpillableMap(String partitionPath, long inferredCacheSize) {
+ // preserve some memory for fileId dict, assuming the average file group number as Short.MAX_VALUE, then the size will be about 1MB.
+ long maxInMemorySizeInBytes = Math.max(inferredCacheSize - BucketCache.FILE_ID_DICT_ENTRY_SIZE * Short.MAX_VALUE, 1);
+ try {
+ return new ExternalSpillableMap<>(
+ maxInMemorySizeInBytes,
+ writeConfig.getSpillableMapBasePath(),
+ new DefaultSizeEstimator<>(),
+ new DefaultSizeEstimator<>(),
+ ExternalSpillableMap.DiskMapType.ROCKS_DB,
+ new DefaultSerializer<>(),
+ writeConfig.getBoolean(HoodieCommonConfig.DISK_MAP_BITCASK_COMPRESSION_ENABLED),
+ "PartitionedRLICache-" + partitionPath);
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create partitioned RLI cache for partition " + partitionPath, e);
+ }
}
private void reloadMetadataTable() {
+ closeMetadataTable();
this.metadataTable = metaClient.getTableFormat().getMetadataFactory().create(
HoodieFlinkEngineContext.DEFAULT,
metaClient.getStorage(),
StreamerUtil.metadataConfig(conf),
conf.get(FlinkOptions.PATH));
}
+ private void updateEvictableCkp(long checkpointId) {
+ ValidationUtils.checkArgument(checkpointId >= minRetainedCheckpointId,
+ String.format("The minimum retained checkpoint id should be increased, previous: %s, received: %s",
+ minRetainedCheckpointId, checkpointId));
+ minRetainedCheckpointId = checkpointId;
+ }
+
+ private long inferMemorySizeForCache() {
+ if (partitionBucketCaches.isEmpty()) {
+ return maxCacheSizeInBytes / 2;
+ }
+ long averageMemorySize = getCurrentHeapSize() / partitionBucketCaches.size();
+ if (averageMemorySize <= 0) {
+ return maxCacheSizeInBytes / 2;
+ }
+ return averageMemorySize;
+ }
+
+ private long getCurrentHeapSize() {
+ return partitionBucketCaches.values().stream()
+ .map(BucketCache::getHeapSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ @VisibleForTesting
+ void cleanIfNecessary(long nextCacheSize, String protectedPartitionPath) {
+ while (getCurrentHeapSize() + nextCacheSize > maxCacheSizeInBytes) {
+ boolean cleaned = false;
+ Iterator<Map.Entry<String, BucketCache>> iterator = partitionBucketCaches.entrySet().iterator();
+ while (iterator.hasNext()) {
+ Map.Entry<String, BucketCache> entry = iterator.next();
+ if (entry.getKey().equals(protectedPartitionPath)) {
+ continue;
+ }
+ BucketCache cache = entry.getValue();
+ if (cache.lastUpdatedCheckpoint < minRetainedCheckpointId) {
+ cache.close();
+ iterator.remove();
+ cleaned = true;
+ log.info("Evict partitioned RLI cache for partition {}", entry.getKey());
+ break;
+ }
+ }
+ if (!cleaned) {
+ // All remaining partition caches are either protected or too recent to evict safely.
+ // Returning avoids retrying the same scan without making progress.
+ return;
+ }
+ }
+ }
+
@Override
Review Comment:
🤖 If any `BucketCache::close` throws (e.g. RocksDB close failure inside `ExternalSpillableMap`), the `forEach` aborts and the remaining caches plus `closeMetadataTable()` never run, leaking the spillable maps and the metadata table. Could you wrap each close in try/catch (or use a try-finally chain) so close attempts continue and accumulated exceptions are surfaced at the end?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1478,6 +1479,10 @@ private Set<String> getNonStreamingMetadataPartitionsToUpdate() {
*/
protected Pair<List<HoodieFileGroupId>, HoodieData<HoodieRecord>> tagRecordsWithLocationForStreamingWrites(HoodieData<HoodieRecord> untaggedRecords,
Set<String> enabledMetadataPartitions) {
+ // no need to tag if the incoming records is empty.
+ if (untaggedRecords instanceof HoodieListData && untaggedRecords.isEmpty()) {
Review Comment:
🤖 Is the `instanceof HoodieListData` restriction intentional to avoid an expensive `isEmpty()` action on Spark RDDs? If so, a brief comment explaining the rationale would help future readers — otherwise it looks like the optimization could just check `untaggedRecords.isEmpty()` directly across implementations.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/RecordIndexPartitioner.java:
##########
@@ -30,47 +34,96 @@
import org.apache.flink.api.common.functions.Partitioner;
import org.apache.flink.configuration.Configuration;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
/**
- * Record index input partitioner, which is aligned with the mapping of record key
+ * Partitioned record index input partitioner, which is aligned with the mapping of record key
* to the file group of record index partition in metadata table. It prevents multiple
* index write subtasks from writing the same record index file group, thereby effectively
* reducing the number of small files.
+ *
+ * <p>Partitioned RLI stores record-index file groups under the corresponding data table
+ * partition. Since RLI file groups for different data partitions can have the same bucket id,
Review Comment:
🤖 nit: with `GlobalRecordIndexPartitioner` now living next to this class, the unprefixed name `RecordIndexPartitioner` reads as the generic/default one even though it's specifically for partitioned RLI. Could you rename to something like `PartitionedRecordIndexPartitioner` to mirror the global counterpart?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1478,6 +1479,10 @@ private Set<String> getNonStreamingMetadataPartitionsToUpdate() {
*/
protected Pair<List<HoodieFileGroupId>, HoodieData<HoodieRecord>> tagRecordsWithLocationForStreamingWrites(HoodieData<HoodieRecord> untaggedRecords,
Set<String> enabledMetadataPartitions) {
+ // no need to tag if the incoming records is empty.
Review Comment:
🤖 nit: the `instanceof HoodieListData` check makes the intent unclear — why is it limited to that one impl? If the goal is to skip a remote/expensive `isEmpty()` for non-list backends, it'd help to spell that out in the comment (and fix the grammar: "records are empty").
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4343830159
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.95%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 33 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|0|
>|spark-java-tests|18|0|
>|spark-client-hadoop-common|1|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 44.95% -23.13%
+ Complexity 28913 8529 -20384
=============================================
Files 2518 1201 -1317
Lines 140572 62652 -77920
Branches 17422 6778 -10644
=============================================
- Hits 95695 28164 -67531
+ Misses 37026 31384 -5642
+ Partials 7851 3104 -4747
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `50.58% <0.00%> (-33.28%)` | :arrow_down: |
... and [2116 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344023426
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.51%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|4|
>|spark-java-tests|18|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 48.51% -19.57%
+ Complexity 28913 16520 -12393
=============================================
Files 2518 1996 -522
Lines 140572 111798 -28774
Branches 17422 14103 -3319
=============================================
- Hits 95695 54235 -41460
- Misses 37026 51823 +14797
+ Partials 7851 5740 -2111
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.20% <0.00%> (-15.45%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <0.00%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1596 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344070885
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.69%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|6|
>|spark-java-tests|18|5|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 47.69% -20.39%
+ Complexity 28913 17031 -11882
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15205 -2217
=============================================
- Hits 95695 55776 -39919
- Misses 37026 55057 +18031
+ Partials 7851 6120 -1731
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <0.00%> (-17.00%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1566 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4343978490
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.99%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|0|
>|spark-java-tests|18|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 53.99% -14.08%
+ Complexity 28913 12409 -16504
=============================================
Files 2518 1433 -1085
Lines 140572 71972 -68600
Branches 17422 8204 -9218
=============================================
- Hits 95695 38863 -56832
+ Misses 37026 29626 -7400
+ Partials 7851 3483 -4368
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `57.20% <0.00%> (-26.65%)` | :arrow_down: |
... and [1864 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344116661
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 62.84%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|6|
>|spark-java-tests|18|7|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 62.84% -5.24%
+ Complexity 28913 26674 -2239
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 88478 -7217
- Misses 37026 44844 +7818
+ Partials 7851 7468 -383
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.82% <0.00%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `73.32% <50.00%> (-10.54%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [415 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344208195
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.19%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 67.19% -0.88%
+ Complexity 28913 28595 -318
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94607 -1088
- Misses 37026 38291 +1265
- Partials 7851 7892 +41
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <0.00%> (-3.90%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [155 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344212021
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.19%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 67.19% -0.88%
+ Complexity 28913 28595 -318
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94608 -1087
- Misses 37026 38291 +1265
- Partials 7851 7891 +40
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <0.00%> (-3.90%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [155 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344269984
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.03%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 68.03% -0.04%
- Complexity 28913 28944 +31
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
+ Hits 95695 95792 +97
- Misses 37026 37129 +103
- Partials 7851 7869 +18
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.52% <0.00%> (-0.13%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349456787
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.17%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 65.17% -2.90%
+ Complexity 28909 27747 -1162
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 91762 -3922
- Misses 37032 41142 +4110
- Partials 7856 7893 +37
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <0.00%> (-17.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <0.00%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [358 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165523968
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/RecordIndexPartitioner.java:
##########
@@ -30,47 +34,92 @@
import org.apache.flink.api.common.functions.Partitioner;
import org.apache.flink.configuration.Configuration;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
+
/**
- * Record index input partitioner, which is aligned with the mapping of record key
+ * Partitioned record index input partitioner, which is aligned with the mapping of record key
* to the file group of record index partition in metadata table. It prevents multiple
* index write subtasks from writing the same record index file group, thereby effectively
* reducing the number of small files.
+ *
+ * <p>The partitioner first spreads data partitions across downstream tasks, then maps
+ * record keys to the subtask for the selected record-index file group.
*/
public class RecordIndexPartitioner implements Partitioner<HoodieKey> {
private final Configuration conf;
+ private Map<String, Integer> partitionedRLIFileGroupCounts;
+ private Functions.Function3<Integer, String, Integer, Integer> partitionIndexFunc;
+
/**
- * The number of file groups for record index partition in metadata data table. The number
- * cannot be calculated during compiling the writing pipeline, since the hoodie table may
- * not be created yet, so the number is lazily calculated during job running.
+ * Creates a partitioner for partitioned RLI index writes.
+ *
+ * @param conf Flink write configuration
*/
- private int numFileGroupsForRecordIndexPartition = -1;
-
public RecordIndexPartitioner(Configuration conf) {
this.conf = conf;
}
+ /**
+ * Routes an index row by data partition and record-key-derived partitioned RLI file group.
Review Comment:
Partitioned RLI stores record-index file groups under the corresponding data table partition. Since RLI file groups for different data partitions can have the same bucket id, shuffling only by bucket id only would route those equally numbered buckets to the same downstream task and can easily cause data skew. Therefore an index row must be routed by its data partition first, then by the record-key hash within that partition's RLI file group range.
I'll also add more doc here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349724061
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.63%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 36 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|5|
>|spark-scala-tests|17|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 60.63% -7.44%
+ Complexity 28909 25791 -3118
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 85369 -10315
- Misses 37032 47969 +10937
+ Partials 7856 7465 -391
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.04% <0.00%> (-16.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `73.32% <50.00%> (-10.54%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [563 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349481062
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.04% -0.02%
- Complexity 28909 28963 +54
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95811 +127
- Misses 37032 37116 +84
- Partials 7856 7870 +14
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.54% <0.00%> (-0.11%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349472662
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.04% -0.03%
- Complexity 28909 28963 +54
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95807 +123
- Misses 37032 37119 +87
- Partials 7856 7871 +15
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.50% <0.00%> (-0.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [15 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4559562433
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 90 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95817 +133
- Misses 37032 37117 +85
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <0.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4563362294
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 92 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95817 +133
- Misses 37032 37117 +85
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <0.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344003751
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.19%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 30 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|2|
>|spark-java-tests|18|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 46.19% -21.88%
+ Complexity 28913 15418 -13495
=============================================
Files 2518 1979 -539
Lines 140572 109426 -31146
Branches 17422 13587 -3835
=============================================
- Hits 95695 50550 -45145
- Misses 37026 53531 +16505
+ Partials 7851 5345 -2506
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.96% <0.00%> (-11.74%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `57.65% <0.00%> (-26.21%)` | :arrow_down: |
... and [1660 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344105773
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.65%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|6|
>|spark-java-tests|18|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 60.65% -7.43%
+ Complexity 28913 25798 -3115
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 85393 -10302
- Misses 37026 47937 +10911
+ Partials 7851 7460 -391
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.65% <0.00%> (-17.00%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `73.32% <50.00%> (-10.54%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [559 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344007710
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.73%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 29 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|3|
>|spark-java-tests|18|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 45.73% -22.35%
+ Complexity 28913 15620 -13293
=============================================
Files 2518 1996 -522
Lines 140572 111793 -28779
Branches 17422 14097 -3325
=============================================
- Hits 95695 51127 -44568
- Misses 37026 55138 +18112
+ Partials 7851 5528 -2323
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <0.00%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `57.65% <0.00%> (-26.21%)` | :arrow_down: |
... and [1646 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349294543
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.97%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 50 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|30|0|
>|spark-scala-tests|17|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 44.97% -23.10%
+ Complexity 28909 8535 -20374
=============================================
Files 2518 1201 -1317
Lines 140572 62652 -77920
Branches 17422 6778 -10644
=============================================
- Hits 95684 28178 -67506
+ Misses 37032 31372 -5660
+ Partials 7856 3102 -4754
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `50.58% <0.00%> (-33.28%)` | :arrow_down: |
... and [2115 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349409298
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.62%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 40 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|3|
>|spark-scala-tests|17|6|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.62% -20.44%
+ Complexity 28909 17016 -11893
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15202 -2220
=============================================
- Hits 95684 55702 -39982
- Misses 37032 55113 +18081
+ Partials 7856 6138 -1718
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.33% <0.00%> (-16.32%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349397128
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.03%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 46 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|2|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 49.03% -19.04%
+ Complexity 28909 16323 -12586
=============================================
Files 2518 1978 -540
Lines 140572 109410 -31162
Branches 17422 13582 -3840
=============================================
- Hits 95684 53646 -42038
- Misses 37032 50204 +13172
+ Partials 7856 5560 -2296
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <0.00%> (-15.49%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.95% <0.00%> (-11.76%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1609 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349404102
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.60%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 41 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|2|
>|spark-scala-tests|17|6|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.60% -20.47%
+ Complexity 28909 17007 -11902
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15202 -2220
=============================================
- Hits 95684 55670 -40014
- Misses 37032 55142 +18110
+ Partials 7856 6141 -1715
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.76% <0.00%> (-15.89%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165378258
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/IndexWriteFunction.java:
##########
@@ -171,13 +171,19 @@ private Pair<List<HoodieRecord>, Set<String>> prepareIndexRecordsAndPartitions(B
Map<String, HoodieRecord> keyAndRecordMap = new LinkedHashMap<>();
while (rowItr.hasNext()) {
RowData indexRow = rowItr.next();
- String recordKey = IndexRowUtils.getRecordKey(indexRow);
- keyAndRecordMap.put(recordKey, IndexRowUtils.convertToHoodieRecord(this.currentInstant, indexRow, writeConfig));
+ keyAndRecordMap.put(getDedupKey(indexRow, writeConfig), IndexRowUtils.convertToHoodieRecord(this.currentInstant, indexRow, writeConfig));
dataPartitions.add(IndexRowUtils.getPartition(indexRow));
}
return Pair.of(new ArrayList<>(keyAndRecordMap.values()), dataPartitions);
}
+ private String getDedupKey(RowData indexRow, HoodieWriteConfig writeConfig) {
+ String recordKey = IndexRowUtils.getRecordKey(indexRow);
Review Comment:
can we make it a function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349431789
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.66%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 35 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|6|
>|spark-scala-tests|17|6|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 60.66% -7.41%
+ Complexity 28909 25810 -3099
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 85411 -10273
- Misses 37032 47925 +10893
+ Partials 7856 7461 -395
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <0.00%> (-17.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `73.32% <50.00%> (-10.54%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [561 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349730675
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 64.87%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 64.87% -3.20%
+ Complexity 28909 27591 -1318
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 91347 -4337
- Misses 37032 41563 +4531
- Partials 7856 7893 +37
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.04% <0.00%> (-16.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.09% <0.00%> (-0.61%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [409 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349781297
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.95%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.95% -0.12%
+ Complexity 28909 28903 -6
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
- Hits 95684 95681 -3
- Misses 37032 37271 +239
+ Partials 7856 7851 -5
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.17% <0.00%> (-0.47%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [35 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349849224
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95817 +133
- Misses 37032 37117 +85
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.64% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349901342
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
}, {
"hash" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741",
"triggerID" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"triggerType" : "PUSH"
}, {
"hash" : "7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e",
"triggerType" : "PUSH"
}, {
"hash" : "3587d3640ec016284e7667655820c5c6aa652999",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13743",
"triggerID" : "3587d3640ec016284e7667655820c5c6aa652999",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e UNKNOWN
* 3587d3640ec016284e7667655820c5c6aa652999 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13743)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349784373
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.97%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.97% -0.09%
- Complexity 28909 28914 +5
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95716 +32
- Misses 37032 37221 +189
- Partials 7856 7866 +10
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.31% <0.00%> (-0.34%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [30 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349460261
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.17%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 65.17% -2.90%
+ Complexity 28909 27747 -1162
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 91763 -3921
- Misses 37032 41142 +4110
- Partials 7856 7892 +36
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <0.00%> (-17.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.62% <0.00%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [358 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349461552
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.08%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.08% -0.99%
+ Complexity 28909 28531 -378
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 94449 -1235
- Misses 37032 38461 +1429
- Partials 7856 7887 +31
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.48% <0.00%> (-4.16%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.62% <0.00%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [181 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165438183
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -50,9 +56,7 @@
* The index is local because different partition paths have separate items in the index.
*/
@Slf4j
-public class BucketStreamWriteFunction extends StreamWriteFunction {
-
- private int parallelism;
+public class BucketStreamWriteFunction extends StreamWriteFunction implements CheckpointListener {
Review Comment:
This pr is supporting streaming RLI for simple bucket index, so we don't need to introduce new write function. If you're referring to the support for dynamic bucket, there is another pr: https://github.com/apache/hudi/pull/18640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4343762649
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d13219446a416ca61eba9636c7d201817eb1502 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349540753
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28963 +54
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
+ Hits 95684 95821 +137
- Misses 37032 37107 +75
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344558255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d13219446a416ca61eba9636c7d201817eb1502 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344406592
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.04%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 68.04% -0.03%
- Complexity 28913 28945 +32
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
+ Hits 95695 95804 +109
- Misses 37026 37118 +92
- Partials 7851 7868 +17
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <0.00%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349424372
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.69%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 37 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|6|
>|spark-scala-tests|17|6|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.69% -20.38%
+ Complexity 28909 17037 -11872
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15202 -2220
=============================================
- Hits 95684 55781 -39903
- Misses 37032 55051 +18019
+ Partials 7856 6121 -1735
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.60% <0.00%> (-17.05%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349373999
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 42.80%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 48 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 42.80% -25.27%
+ Complexity 28909 13868 -15041
=============================================
Files 2518 1978 -540
Lines 140572 109410 -31162
Branches 17422 13582 -3840
=============================================
- Hits 95684 46828 -48856
- Misses 37032 57136 +20104
+ Partials 7856 5446 -2410
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <0.00%> (-15.49%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <0.00%> (-11.69%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.78% <0.00%> (-17.08%)` | :arrow_down: |
... and [1819 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349401798
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.01%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 43 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|5|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 48.01% -20.06%
+ Complexity 28909 16762 -12147
=============================================
Files 2518 2026 -492
Lines 140572 114469 -26103
Branches 17422 14665 -2757
=============================================
- Hits 95684 54960 -40724
- Misses 37032 53564 +16532
+ Partials 7856 5945 -1911
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <0.00%> (-15.49%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <0.00%> (-12.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1580 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349383779
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.72%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 47 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 48.72% -19.35%
+ Complexity 28909 16183 -12726
=============================================
Files 2518 1978 -540
Lines 140572 109410 -31162
Branches 17422 13582 -3840
=============================================
- Hits 95684 53311 -42373
- Misses 37032 50623 +13591
+ Partials 7856 5476 -2380
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <0.00%> (-15.49%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.01% <0.00%> (-11.69%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1613 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349412922
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.66%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 39 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|4|
>|spark-scala-tests|17|6|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.66% -20.41%
+ Complexity 28909 17025 -11884
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15202 -2220
=============================================
- Hits 95684 55742 -39942
- Misses 37032 55082 +18050
+ Partials 7856 6129 -1727
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.97% <0.00%> (-16.68%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1567 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165377097
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -50,9 +56,7 @@
* The index is local because different partition paths have separate items in the index.
*/
@Slf4j
-public class BucketStreamWriteFunction extends StreamWriteFunction {
-
- private int parallelism;
+public class BucketStreamWriteFunction extends StreamWriteFunction implements CheckpointListener {
Review Comment:
can we write a new function instead of modifying existing one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349270551
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
}, {
"hash" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d13219446a416ca61eba9636c7d201817eb1502 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726)
* ebe621ace81729f610a1752a63233ac53b69ff9f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165390514
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/RecordLevelIndexBackend.java:
##########
@@ -19,125 +19,378 @@
package org.apache.hudi.sink.partitioner.index;
import org.apache.hudi.client.common.HoodieFlinkEngineContext;
-import org.apache.hudi.common.data.HoodieListData;
+import org.apache.hudi.common.config.HoodieCommonConfig;
import org.apache.hudi.common.data.HoodiePairData;
+import org.apache.hudi.common.model.FileSlice;
import org.apache.hudi.common.model.HoodieRecordGlobalLocation;
+import org.apache.hudi.common.serialization.DefaultSerializer;
import org.apache.hudi.common.table.HoodieTableMetaClient;
-import org.apache.hudi.common.util.HoodieDataUtils;
+import org.apache.hudi.common.util.DefaultSizeEstimator;
+import org.apache.hudi.common.util.ValidationUtils;
import org.apache.hudi.common.util.VisibleForTesting;
-import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.OptionsResolver;
import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
import org.apache.hudi.metadata.HoodieTableMetadata;
+import org.apache.hudi.metadata.MetadataPartitionType;
import org.apache.hudi.sink.event.Correspondent;
+import org.apache.hudi.sink.utils.PeriodicActionExecutor;
+import org.apache.hudi.util.FlinkWriteClients;
import org.apache.hudi.util.StreamerUtil;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.flink.configuration.Configuration;
+import java.io.Closeable;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
/**
- * An implementation of {@link IndexBackend} based on the record level index in metadata table.
+ * Partition-scoped index backend backed by partitioned record level index.
+ *
+ * <p>The backend keeps a lazy cache per data partition. Each cache maps record keys owned by the
+ * current Flink assign subtask to the file group id stored in the partitioned RLI. New records are
+ * added to the cache after bucket assignment, while existing records keep their original RLI routing.
+ *
+ * <p>Partition caches are evicted lazily: checkpoint completion only advances the safe eviction
+ * watermark, and cleanup happens when the total in-memory cache size exceeds
+ * {@link FlinkOptions#INDEX_RLI_CACHE_SIZE}.
*/
@Slf4j
-public class RecordLevelIndexBackend implements MinibatchIndexBackend {
- @VisibleForTesting
- @Getter
- private final RecordIndexCache recordIndexCache;
+public class RecordLevelIndexBackend implements PartitionedIndexBackend {
+
private final Configuration conf;
+ private final HoodieWriteConfig writeConfig;
private final HoodieTableMetaClient metaClient;
+ private final boolean isInsertOverwrite;
+ private final long maxCacheSizeInBytes;
+ private final BootstrapFilter bootstrapFilter;
private HoodieTableMetadata metadataTable;
- public RecordLevelIndexBackend(Configuration conf, long initCheckpointId) {
- this.metaClient = StreamerUtil.createMetaClient(conf);
+ @Getter
+ private final Map<String, BucketCache> partitionBucketCaches = new LinkedHashMap<>(16, 0.75f, true);
+ private long currentCheckpointId = -1L;
+ private long minRetainedCheckpointId = Long.MIN_VALUE;
+ private final PeriodicActionExecutor memoryCheckExecutor = new PeriodicActionExecutor();
+
+ /**
+ * Creates a partitioned RLI backend with custom ownership filtering.
+ *
+ * <p>This constructor is used by simple bucket index, whose write ownership is determined by
+ * partition and bucket file id rather than Flink record-key key groups.
+ *
+ * @param conf Flink write configuration
+ * @param bootstrapFilter filter for deciding whether a bootstrapped RLI record belongs to this task
+ */
+ public RecordLevelIndexBackend(Configuration conf, BootstrapFilter bootstrapFilter) {
this.conf = conf;
- this.recordIndexCache = new RecordIndexCache(conf, initCheckpointId);
+ this.writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, false, false);
+ this.metaClient = StreamerUtil.createMetaClient(conf);
+ this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(conf);
+ this.maxCacheSizeInBytes = conf.get(FlinkOptions.INDEX_RLI_CACHE_SIZE) * 1024 * 1024;
+ this.bootstrapFilter = bootstrapFilter;
reloadMetadataTable();
}
@Override
- public HoodieRecordGlobalLocation get(String recordKey) throws IOException {
- return get(Collections.singletonList(recordKey)).get(recordKey);
+ public String get(String partitionPath, String recordKey) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ return cache.getFileGroupId(recordKey);
}
@Override
- public void update(String recordKey, HoodieRecordGlobalLocation recordGlobalLocation) {
- recordIndexCache.update(recordKey, recordGlobalLocation);
+ public void update(String partitionPath, String recordKey, String fileId) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ cache.putRecordKey(recordKey, fileId, false);
+ memoryCheckExecutor.runIfNecessary(() -> cleanIfNecessary(0L, partitionPath));
}
+ /**
+ * Records the latest checkpoint id seen by this assign subtask.
+ *
+ * <p>New record-key mappings written after this point are tagged with the checkpoint id so lazy
+ * eviction can avoid removing partition caches that may still be needed for recovery.
+ *
+ * @param checkpointId checkpoint id from the bucket assign operator
+ */
@Override
- public Map<String, HoodieRecordGlobalLocation> get(List<String> recordKeys) throws IOException {
- // use a linked hash map to keep the natural order.
- Map<String, HoodieRecordGlobalLocation> keysAndLocations = new LinkedHashMap<>();
- List<String> missedKeys = new ArrayList<>();
- for (String key: recordKeys) {
- HoodieRecordGlobalLocation location = recordIndexCache.get(key);
- if (location == null) {
- missedKeys.add(key);
- }
- // insert anyway even the location is null to keep the natural order.
- keysAndLocations.put(key, location);
- }
- if (!missedKeys.isEmpty()) {
- HoodiePairData<String, HoodieRecordGlobalLocation> recordIndexData =
- metadataTable.readRecordIndexLocationsWithKeys(HoodieListData.eager(missedKeys));
- List<Pair<String, HoodieRecordGlobalLocation>> recordIndexLocations = HoodieDataUtils.dedupeAndCollectAsList(recordIndexData);
- recordIndexLocations.forEach(keyAndLocation -> {
- recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue());
- keysAndLocations.put(keyAndLocation.getKey(), keyAndLocation.getValue());
- });
- }
- return keysAndLocations;
+ public void onCheckpoint(long checkpointId) {
+ this.currentCheckpointId = checkpointId;
}
+ /**
+ * Advances the lazy eviction watermark after a completed checkpoint.
+ *
+ * <p>The watermark is derived from the minimum inflight checkpoint so caches that may still be
+ * needed for recovery are retained. Metadata table state is reloaded after the coordinator has
+ * committed or advanced instants for the completed checkpoint.
+ *
+ * @param correspondent writer coordinator correspondent used to query inflight instants
+ * @param completedCheckpointId completed checkpoint id reported by Flink
+ */
@Override
- public void update(List<Pair<String, HoodieRecordGlobalLocation>> recordKeysAndLocations) throws IOException {
- recordKeysAndLocations.forEach(keyAndLocation -> recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue()));
+ public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointId) {
+ Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
+ updateEvictableCkp(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointId));
+ metaClient.reloadActiveTimeline();
+ reloadMetadataTable();
}
- @Override
- public void onCheckpoint(long checkpointId) {
- recordIndexCache.addCheckpointCache(checkpointId);
+ private BucketCache getOrBootstrapPartition(String partitionPath) {
+ BucketCache cache = partitionBucketCaches.get(partitionPath);
+ if (cache != null) {
+ return cache;
+ }
+
+ cache = isInsertOverwrite ? createBucketCache(partitionPath) : bootstrapPartition(partitionPath);
+ partitionBucketCaches.put(partitionPath, cache);
+ cleanIfNecessary(0L, partitionPath);
+ return cache;
}
- @Override
- public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointID) {
- Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
- log.info("Inflight instants and the corresponding checkpoints: {}, notified completed checkpoints: {}",
- inflightInstants, completedCheckpointID);
- // if there are no inflight instants,
- // the latest completed checkpoint id is used as the minimum checkpoint id,
- // since the streaming write operator always uses previous checkpoint id to request the new instant.
- recordIndexCache.markAsEvictable(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointID));
- this.metaClient.reloadActiveTimeline();
- reloadMetadataTable();
+ private BucketCache bootstrapPartition(String partitionPath) {
+ BucketCache cache = createBucketCache(partitionPath);
+ if (!metaClient.getTableConfig().isMetadataPartitionAvailable(MetadataPartitionType.RECORD_INDEX)) {
+ log.info("Record index is not available yet. Start partitioned RLI cache empty for partition {}", partitionPath);
+ return cache;
+ }
+
+ try {
+ Map<String, List<FileSlice>> partitionedFileGroups =
+ metadataTable.getBucketizedFileGroupsForPartitionedRLI(MetadataPartitionType.RECORD_INDEX);
+ List<FileSlice> fileSlices = partitionedFileGroups.get(partitionPath);
+ if (fileSlices == null || fileSlices.isEmpty()) {
+ return cache;
+ }
+ HoodiePairData<String, HoodieRecordGlobalLocation> locations =
+ metadataTable.readRecordIndexLocations(fileSlicesToFilter -> fileSlices);
+ final AtomicLong totalCnt = new AtomicLong();
+ locations.forEach(locationPair -> {
+ String recordKey = locationPair.getLeft();
+ String fileId = locationPair.getRight().getFileId();
+ if (bootstrapFilter.shouldLoad(partitionPath, recordKey, fileId)) {
+ cache.putRecordKey(recordKey, fileId, true);
+ }
+ totalCnt.incrementAndGet();
+ });
+ log.info("Bootstrapped partitioned RLI cache for partition {} with {} owned records from total {} RLI records.",
+ partitionPath, cache.size(), totalCnt.get());
+ return cache;
+ } catch (Exception e) {
+ cache.close();
+ throw new HoodieException("Failed to bootstrap partitioned RLI cache for partition " + partitionPath, e);
+ }
+ }
+
+ private BucketCache createBucketCache(String partitionPath) {
+ long inferredCacheSize = inferMemorySizeForCache();
+ cleanIfNecessary(inferredCacheSize, partitionPath);
+ return newBucketCache(createSpillableMap(partitionPath, inferredCacheSize), Long.MIN_VALUE);
+ }
+
+ private ExternalSpillableMap<String, Integer> createSpillableMap(String partitionPath, long inferredCacheSize) {
+ // preserve some memory for fileId dict, assuming the average file group number as Short.MAX_VALUE, then the size will be about 1MB.
+ long maxInMemorySizeInBytes = Math.max(inferredCacheSize - BucketCache.FILE_ID_DICT_ENTRY_SIZE * Short.MAX_VALUE, 1);
+ try {
+ return new ExternalSpillableMap<>(
+ maxInMemorySizeInBytes,
+ writeConfig.getSpillableMapBasePath(),
+ new DefaultSizeEstimator<>(),
+ new DefaultSizeEstimator<>(),
+ ExternalSpillableMap.DiskMapType.ROCKS_DB,
+ new DefaultSerializer<>(),
+ writeConfig.getBoolean(HoodieCommonConfig.DISK_MAP_BITCASK_COMPRESSION_ENABLED),
+ "PartitionedRLICache-" + partitionPath);
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create partitioned RLI cache for partition " + partitionPath, e);
+ }
}
private void reloadMetadataTable() {
+ closeMetadataTable();
this.metadataTable = metaClient.getTableFormat().getMetadataFactory().create(
HoodieFlinkEngineContext.DEFAULT,
metaClient.getStorage(),
StreamerUtil.metadataConfig(conf),
conf.get(FlinkOptions.PATH));
}
+ private void updateEvictableCkp(long checkpointId) {
+ ValidationUtils.checkArgument(checkpointId >= minRetainedCheckpointId,
+ String.format("The minimum retained checkpoint id should be increased, previous: %s, received: %s",
+ minRetainedCheckpointId, checkpointId));
+ minRetainedCheckpointId = checkpointId;
+ }
+
+ private long inferMemorySizeForCache() {
+ if (partitionBucketCaches.isEmpty()) {
+ return maxCacheSizeInBytes / 2;
+ }
+ long averageMemorySize = getCurrentHeapSize() / partitionBucketCaches.size();
+ if (averageMemorySize <= 0) {
+ return maxCacheSizeInBytes / 2;
+ }
+ return averageMemorySize;
+ }
+
+ private long getCurrentHeapSize() {
+ return partitionBucketCaches.values().stream()
+ .map(BucketCache::getHeapSize)
+ .reduce(Long::sum)
+ .orElse(0L);
+ }
+
+ @VisibleForTesting
+ void cleanIfNecessary(long nextCacheSize, String protectedPartitionPath) {
+ while (getCurrentHeapSize() + nextCacheSize > maxCacheSizeInBytes) {
+ boolean cleaned = false;
+ Iterator<Map.Entry<String, BucketCache>> iterator = partitionBucketCaches.entrySet().iterator();
+ while (iterator.hasNext()) {
+ Map.Entry<String, BucketCache> entry = iterator.next();
+ if (entry.getKey().equals(protectedPartitionPath)) {
+ continue;
+ }
+ BucketCache cache = entry.getValue();
+ if (cache.lastUpdatedCheckpoint < minRetainedCheckpointId) {
+ cache.close();
+ iterator.remove();
+ cleaned = true;
+ log.info("Evict partitioned RLI cache for partition {}", entry.getKey());
+ break;
+ }
+ }
+ if (!cleaned) {
+ return;
+ }
+ }
+ }
+
@Override
public void close() throws IOException {
- this.recordIndexCache.close();
- if (this.metadataTable == null) {
- return;
+ partitionBucketCaches.values().forEach(BucketCache::close);
+ partitionBucketCaches.clear();
+ closeMetadataTable();
+ }
+
+ private void closeMetadataTable() {
+ if (metadataTable != null) {
+ try {
+ metadataTable.close();
+ } catch (Exception e) {
+ throw new HoodieException("Failed to close metadata table", e);
+ } finally {
+ metadataTable = null;
+ }
}
- try {
- this.metadataTable.close();
- } catch (Exception e) {
- throw new HoodieException("Exception happened during close metadata table.", e);
+ }
+
+ /**
+ * Creates a bucket cache with an injected spillable map for tests.
+ *
+ * @param recordKeyToFileGroupIdCode encoded record-key to file-group-id mapping
+ * @param lastUpdatedCheckpoint checkpoint id of the latest non-bootstrap update
+ * @return bucket cache for one data partition
+ */
+ @VisibleForTesting
+ public BucketCache newBucketCache(
+ ExternalSpillableMap<String, Integer> recordKeyToFileGroupIdCode,
+ long lastUpdatedCheckpoint) {
+ return new BucketCache(recordKeyToFileGroupIdCode, lastUpdatedCheckpoint);
+ }
+
+ @FunctionalInterface
+ public interface BootstrapFilter {
+ boolean shouldLoad(String partitionPath, String recordKey, String fileId);
+ }
+
+ /**
+ * Bucket Cache of one data table partition.
+ *
+ * <p>The spillable map stores {@code recordKey -> fileGroupIdCode}. File group ids are dictionary
+ * encoded inside the cache so hot partitions do not repeat UUID-style file group id strings for
+ * every record key entry.
+ */
+ public class BucketCache implements Closeable {
+ @Getter
+ private final ExternalSpillableMap<String, Integer> recordKeyToFileGroupIdCode;
+ // Keep file group ids in a partition-local dictionary so the spillable record map stores
+ // compact integer codes instead of repeating long UUID-style file group id strings.
+ private final Map<String, Integer> fileGroupIdToDictId;
+ private final List<String> dictIdToFileGroupId;
+ private long lastUpdatedCheckpoint;
+ // File group ids generated by bucket assign are UUID-style 36-character strings.
+ // Each dictionary entry keeps one file group id and one 4-byte integer code.
+ private static final long FILE_ID_DICT_ENTRY_SIZE = 36L + Integer.BYTES;
+
+ BucketCache(ExternalSpillableMap<String, Integer> recordKeyToFileGroupIdCode, long lastUpdatedCheckpoint) {
+ this.recordKeyToFileGroupIdCode = recordKeyToFileGroupIdCode;
+ this.fileGroupIdToDictId = new HashMap<>();
+ this.dictIdToFileGroupId = new ArrayList<>();
+ this.lastUpdatedCheckpoint = lastUpdatedCheckpoint;
+ }
+
+ /**
+ * Returns the decoded file group id for the record key, or {@code null} when the key is unknown.
+ */
+ String getFileGroupId(String recordKey) {
+ Integer fileGroupIdCode = this.recordKeyToFileGroupIdCode.get(recordKey);
+ return fileGroupIdCode == null ? null : dictIdToFileGroupId.get(fileGroupIdCode);
+ }
+
+ /**
+ * Returns the number of cached record-key mappings in this partition.
+ */
+ int size() {
+ return this.recordKeyToFileGroupIdCode.size();
+ }
+
+ private long getHeapSize() {
+ return this.recordKeyToFileGroupIdCode.getCurrentInMemoryMapSize() + getFileGroupIdDictHeapSize();
+ }
+
+ /**
+ * Adds or updates a record-key mapping.
+ *
+ * @param isBootstrap {@code true} when loading existing RLI mappings; bootstrap entries should not
+ * advance {@code lastUpdatedCheckpoint}
+ */
+ void putRecordKey(String recordKey, String fileGroupId, boolean isBootstrap) {
+ this.recordKeyToFileGroupIdCode.put(recordKey, getOrCreateFileGroupIdCode(fileGroupId));
+ if (!isBootstrap) {
+ this.lastUpdatedCheckpoint = currentCheckpointId;
+ }
+ }
+
+ private int getOrCreateFileGroupIdCode(String fileGroupId) {
+ // Encode each unique file group id once, and reuse the code for all record keys routed to it.
+ Integer existingCode = fileGroupIdToDictId.get(fileGroupId);
+ if (existingCode != null) {
+ return existingCode;
+ }
+
+ int newCode = dictIdToFileGroupId.size();
+ fileGroupIdToDictId.put(fileGroupId, newCode);
+ dictIdToFileGroupId.add(fileGroupId);
+ return newCode;
+ }
+
+ private long getFileGroupIdDictHeapSize() {
+ return dictIdToFileGroupId.size() * FILE_ID_DICT_ENTRY_SIZE;
+ }
+
+ @Override
+ public void close() {
+ this.recordKeyToFileGroupIdCode.close();
Review Comment:
should we clear the other collections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349400867
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.00%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 44 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|4|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 48.00% -20.06%
+ Complexity 28909 16762 -12147
=============================================
Files 2518 2026 -492
Lines 140572 114464 -26108
Branches 17422 14659 -2763
=============================================
- Hits 95684 54954 -40730
- Misses 37032 53562 +16530
+ Partials 7856 5948 -1908
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <0.00%> (-15.49%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.65% <0.00%> (-12.05%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1582 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349398575
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.51%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (ebe621a). Click for more details.
>
> <details><summary>HEAD has 45 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (ebe621a) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 48.51% -19.56%
+ Complexity 28909 16526 -12383
=============================================
Files 2518 1996 -522
Lines 140572 111793 -28779
Branches 17422 14094 -3328
=============================================
- Hits 95684 54236 -41448
- Misses 37032 51811 +14779
+ Partials 7856 5746 -2110
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.15% <0.00%> (-15.49%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.78% <0.00%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1598 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-agent (via GitHub)" <gi...@apache.org>.
hudi-agent commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165411893
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketStreamWriteFunction.java:
##########
@@ -120,14 +132,40 @@ public void snapshotState() {
this.incBucketIndex.clear();
}
+ @Override
+ public void snapshotState(FunctionSnapshotContext context) throws Exception {
+ super.snapshotState(context);
+ this.recordLevelIndexBackendOpt.ifPresent(recordLevelIndexBackend ->
+ recordLevelIndexBackend.onCheckpoint(context.getCheckpointId()));
+ }
+
@Override
public void processElement(HoodieFlinkInternalRow record,
ProcessFunction<HoodieFlinkInternalRow, RowData>.Context context,
Collector<RowData> collector) throws Exception {
defineRecordLocation(record);
+ processRecordIndex(record, collector);
bufferRecord(record);
}
+ private void processRecordIndex(HoodieFlinkInternalRow record, Collector<RowData> collector) {
+ if (!recordLevelIndexBackendOpt.isPresent() || !shouldEmitRecordIndex(record)) {
+ return;
+ }
+ RecordLevelIndexBackend recordLevelIndexBackend = recordLevelIndexBackendOpt.get();
+ String fileId = recordLevelIndexBackend.get(record.getPartitionPath(), record.getRecordKey());
+ if (fileId == null) {
+ recordLevelIndexBackend.update(record.getPartitionPath(), record.getRecordKey(), record.getFileId());
+ record.setOperationType("I");
+ collector.collect(IndexRowUtils.createRecordIndexRow(record));
+ }
+ }
Review Comment:
🤖 nit: `"I"` is a magic string here — could you replace it with a named constant (e.g. `WriteOperationType.INSERT.value()` or a local `INDEX_OP_INSERT`) so the intent is immediately clear to a future reader?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1478,6 +1479,10 @@ private Set<String> getNonStreamingMetadataPartitionsToUpdate() {
*/
protected Pair<List<HoodieFileGroupId>, HoodieData<HoodieRecord>> tagRecordsWithLocationForStreamingWrites(HoodieData<HoodieRecord> untaggedRecords,
Set<String> enabledMetadataPartitions) {
+ // no need to tag of the incoming records is empty.
Review Comment:
🤖 nit: small typo in the comment — "tag of the incoming records" should be "tag if the incoming records are empty".
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349681785
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 42.74%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 48 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 42.74% -25.33%
+ Complexity 28909 13884 -15025
=============================================
Files 2518 1985 -533
Lines 140572 109435 -31137
Branches 17422 13546 -3876
=============================================
- Hits 95684 46775 -48909
- Misses 37032 57185 +20153
+ Partials 7856 5475 -2381
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <0.00%> (-15.53%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <0.00%> (-11.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `66.78% <0.00%> (-17.08%)` | :arrow_down: |
... and [1843 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349694475
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.26%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 45 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 48.26% -19.80%
+ Complexity 28909 16440 -12469
=============================================
Files 2518 2012 -506
Lines 140572 112205 -28367
Branches 17422 14184 -3238
=============================================
- Hits 95684 54160 -41524
- Misses 37032 52379 +15347
+ Partials 7856 5666 -2190
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <0.00%> (-15.53%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <0.00%> (-11.62%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1593 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349684811
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.66%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 47 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|1|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 48.66% -19.41%
+ Complexity 28909 16200 -12709
=============================================
Files 2518 1985 -533
Lines 140572 109459 -31113
Branches 17422 13567 -3855
=============================================
- Hits 95684 53271 -42413
- Misses 37032 50688 +13656
+ Partials 7856 5500 -2356
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <0.00%> (-15.53%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <0.00%> (-11.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1630 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344223802
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.25000%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.22%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.48% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 31.03% | [17 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.07% 67.22% -0.86%
+ Complexity 28913 28607 -306
============================================
Files 2518 2520 +2
Lines 140572 140790 +218
Branches 17422 17448 +26
============================================
- Hits 95695 94646 -1049
- Misses 37026 38239 +1213
- Partials 7851 7905 +54
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <56.25%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.89% <0.00%> (-3.76%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.70% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | `77.61% <60.00%> (-2.08%)` | :arrow_down: |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | `75.90% <0.00%> (-1.77%)` | :arrow_down: |
| ... and [5 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [150 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349581727
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d13219446a416ca61eba9636c7d201817eb1502",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13726",
"triggerID" : "8d13219446a416ca61eba9636c7d201817eb1502",
"triggerType" : "PUSH"
}, {
"hash" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741",
"triggerID" : "ebe621ace81729f610a1752a63233ac53b69ff9f",
"triggerType" : "PUSH"
}, {
"hash" : "7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e",
"triggerType" : "PUSH"
}, {
"hash" : "3587d3640ec016284e7667655820c5c6aa652999",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3587d3640ec016284e7667655820c5c6aa652999",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebe621ace81729f610a1752a63233ac53b69ff9f Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13741)
* 7f04ced30c2a16af0bd93ad0d2ec1b24f2fc0f4e UNKNOWN
* 3587d3640ec016284e7667655820c5c6aa652999 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4350125379
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.55263%` with `126 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.05%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 54.54% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 57.14% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 68.05% -0.02%
- Complexity 28909 28950 +41
============================================
Files 2518 2521 +3
Lines 140572 140803 +231
Branches 17422 17447 +25
============================================
+ Hits 95684 95817 +133
- Misses 37032 37117 +85
- Partials 7856 7869 +13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.38% <58.55%> (+0.01%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.65% <0.00%> (+0.01%)` | :arrow_up: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.69% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/SamplingActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FSamplingActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9TYW1wbGluZ0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `83.79% <50.00%> (-0.07%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344037421
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.62%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|6|
>|spark-java-tests|18|3|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 47.62% -20.45%
+ Complexity 28913 17013 -11900
=============================================
Files 2518 2047 -471
Lines 140572 116953 -23619
Branches 17422 15205 -2217
=============================================
- Hits 95695 55702 -39993
- Misses 37026 55117 +18091
+ Partials 7851 6134 -1717
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.38% <0.00%> (-16.27%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.16%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1566 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4344016680
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.73%. Comparing base ([`426cbb8`](https://app.codecov.io/gh/apache/hudi/commit/426cbb8c232e11eb744edc713754ee5cd946c16e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8d13219`](https://app.codecov.io/gh/apache/hudi/commit/8d13219446a416ca61eba9636c7d201817eb1502?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (426cbb8) and HEAD (8d13219). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (426cbb8) | HEAD (8d13219) |
>|------|------|------|
>|spark-scala-tests|12|4|
>|spark-java-tests|18|0|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.07% 45.73% -22.34%
+ Complexity 28913 15620 -13293
=============================================
Files 2518 1996 -522
Lines 140572 111798 -28774
Branches 17422 14103 -3319
=============================================
- Hits 95695 51133 -44562
- Misses 37026 55140 +18114
+ Partials 7851 5525 -2326
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.95% <0.00%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.79% <0.00%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `57.65% <0.00%> (-26.21%)` | :arrow_down: |
... and [1644 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "cshuo (via GitHub)" <gi...@apache.org>.
cshuo commented on code in PR #18645:
URL: https://github.com/apache/hudi/pull/18645#discussion_r3165457782
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/RecordLevelIndexBackend.java:
##########
@@ -19,125 +19,378 @@
package org.apache.hudi.sink.partitioner.index;
import org.apache.hudi.client.common.HoodieFlinkEngineContext;
-import org.apache.hudi.common.data.HoodieListData;
+import org.apache.hudi.common.config.HoodieCommonConfig;
import org.apache.hudi.common.data.HoodiePairData;
+import org.apache.hudi.common.model.FileSlice;
import org.apache.hudi.common.model.HoodieRecordGlobalLocation;
+import org.apache.hudi.common.serialization.DefaultSerializer;
import org.apache.hudi.common.table.HoodieTableMetaClient;
-import org.apache.hudi.common.util.HoodieDataUtils;
+import org.apache.hudi.common.util.DefaultSizeEstimator;
+import org.apache.hudi.common.util.ValidationUtils;
import org.apache.hudi.common.util.VisibleForTesting;
-import org.apache.hudi.common.util.collection.Pair;
+import org.apache.hudi.common.util.collection.ExternalSpillableMap;
+import org.apache.hudi.config.HoodieWriteConfig;
import org.apache.hudi.configuration.FlinkOptions;
+import org.apache.hudi.configuration.OptionsResolver;
import org.apache.hudi.exception.HoodieException;
+import org.apache.hudi.exception.HoodieIOException;
import org.apache.hudi.metadata.HoodieTableMetadata;
+import org.apache.hudi.metadata.MetadataPartitionType;
import org.apache.hudi.sink.event.Correspondent;
+import org.apache.hudi.sink.utils.PeriodicActionExecutor;
+import org.apache.hudi.util.FlinkWriteClients;
import org.apache.hudi.util.StreamerUtil;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;
import org.apache.flink.configuration.Configuration;
+import java.io.Closeable;
import java.io.IOException;
import java.util.ArrayList;
-import java.util.Collections;
+import java.util.HashMap;
+import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.atomic.AtomicLong;
/**
- * An implementation of {@link IndexBackend} based on the record level index in metadata table.
+ * Partition-scoped index backend backed by partitioned record level index.
+ *
+ * <p>The backend keeps a lazy cache per data partition. Each cache maps record keys owned by the
+ * current Flink assign subtask to the file group id stored in the partitioned RLI. New records are
+ * added to the cache after bucket assignment, while existing records keep their original RLI routing.
+ *
+ * <p>Partition caches are evicted lazily: checkpoint completion only advances the safe eviction
+ * watermark, and cleanup happens when the total in-memory cache size exceeds
+ * {@link FlinkOptions#INDEX_RLI_CACHE_SIZE}.
*/
@Slf4j
-public class RecordLevelIndexBackend implements MinibatchIndexBackend {
- @VisibleForTesting
- @Getter
- private final RecordIndexCache recordIndexCache;
+public class RecordLevelIndexBackend implements PartitionedIndexBackend {
+
private final Configuration conf;
+ private final HoodieWriteConfig writeConfig;
private final HoodieTableMetaClient metaClient;
+ private final boolean isInsertOverwrite;
+ private final long maxCacheSizeInBytes;
+ private final BootstrapFilter bootstrapFilter;
private HoodieTableMetadata metadataTable;
- public RecordLevelIndexBackend(Configuration conf, long initCheckpointId) {
- this.metaClient = StreamerUtil.createMetaClient(conf);
+ @Getter
+ private final Map<String, BucketCache> partitionBucketCaches = new LinkedHashMap<>(16, 0.75f, true);
+ private long currentCheckpointId = -1L;
+ private long minRetainedCheckpointId = Long.MIN_VALUE;
+ private final PeriodicActionExecutor memoryCheckExecutor = new PeriodicActionExecutor();
+
+ /**
+ * Creates a partitioned RLI backend with custom ownership filtering.
+ *
+ * <p>This constructor is used by simple bucket index, whose write ownership is determined by
+ * partition and bucket file id rather than Flink record-key key groups.
+ *
+ * @param conf Flink write configuration
+ * @param bootstrapFilter filter for deciding whether a bootstrapped RLI record belongs to this task
+ */
+ public RecordLevelIndexBackend(Configuration conf, BootstrapFilter bootstrapFilter) {
this.conf = conf;
- this.recordIndexCache = new RecordIndexCache(conf, initCheckpointId);
+ this.writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, false, false);
+ this.metaClient = StreamerUtil.createMetaClient(conf);
+ this.isInsertOverwrite = OptionsResolver.isInsertOverwrite(conf);
+ this.maxCacheSizeInBytes = conf.get(FlinkOptions.INDEX_RLI_CACHE_SIZE) * 1024 * 1024;
+ this.bootstrapFilter = bootstrapFilter;
reloadMetadataTable();
}
@Override
- public HoodieRecordGlobalLocation get(String recordKey) throws IOException {
- return get(Collections.singletonList(recordKey)).get(recordKey);
+ public String get(String partitionPath, String recordKey) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ return cache.getFileGroupId(recordKey);
}
@Override
- public void update(String recordKey, HoodieRecordGlobalLocation recordGlobalLocation) {
- recordIndexCache.update(recordKey, recordGlobalLocation);
+ public void update(String partitionPath, String recordKey, String fileId) {
+ BucketCache cache = getOrBootstrapPartition(partitionPath);
+ cache.putRecordKey(recordKey, fileId, false);
+ memoryCheckExecutor.runIfNecessary(() -> cleanIfNecessary(0L, partitionPath));
}
+ /**
+ * Records the latest checkpoint id seen by this assign subtask.
+ *
+ * <p>New record-key mappings written after this point are tagged with the checkpoint id so lazy
+ * eviction can avoid removing partition caches that may still be needed for recovery.
+ *
+ * @param checkpointId checkpoint id from the bucket assign operator
+ */
@Override
- public Map<String, HoodieRecordGlobalLocation> get(List<String> recordKeys) throws IOException {
- // use a linked hash map to keep the natural order.
- Map<String, HoodieRecordGlobalLocation> keysAndLocations = new LinkedHashMap<>();
- List<String> missedKeys = new ArrayList<>();
- for (String key: recordKeys) {
- HoodieRecordGlobalLocation location = recordIndexCache.get(key);
- if (location == null) {
- missedKeys.add(key);
- }
- // insert anyway even the location is null to keep the natural order.
- keysAndLocations.put(key, location);
- }
- if (!missedKeys.isEmpty()) {
- HoodiePairData<String, HoodieRecordGlobalLocation> recordIndexData =
- metadataTable.readRecordIndexLocationsWithKeys(HoodieListData.eager(missedKeys));
- List<Pair<String, HoodieRecordGlobalLocation>> recordIndexLocations = HoodieDataUtils.dedupeAndCollectAsList(recordIndexData);
- recordIndexLocations.forEach(keyAndLocation -> {
- recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue());
- keysAndLocations.put(keyAndLocation.getKey(), keyAndLocation.getValue());
- });
- }
- return keysAndLocations;
+ public void onCheckpoint(long checkpointId) {
+ this.currentCheckpointId = checkpointId;
}
+ /**
+ * Advances the lazy eviction watermark after a completed checkpoint.
+ *
+ * <p>The watermark is derived from the minimum inflight checkpoint so caches that may still be
+ * needed for recovery are retained. Metadata table state is reloaded after the coordinator has
+ * committed or advanced instants for the completed checkpoint.
+ *
+ * @param correspondent writer coordinator correspondent used to query inflight instants
+ * @param completedCheckpointId completed checkpoint id reported by Flink
+ */
@Override
- public void update(List<Pair<String, HoodieRecordGlobalLocation>> recordKeysAndLocations) throws IOException {
- recordKeysAndLocations.forEach(keyAndLocation -> recordIndexCache.update(keyAndLocation.getKey(), keyAndLocation.getValue()));
+ public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointId) {
+ Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
+ updateEvictableCkp(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointId));
+ metaClient.reloadActiveTimeline();
+ reloadMetadataTable();
}
- @Override
- public void onCheckpoint(long checkpointId) {
- recordIndexCache.addCheckpointCache(checkpointId);
+ private BucketCache getOrBootstrapPartition(String partitionPath) {
+ BucketCache cache = partitionBucketCaches.get(partitionPath);
+ if (cache != null) {
+ return cache;
+ }
+
+ cache = isInsertOverwrite ? createBucketCache(partitionPath) : bootstrapPartition(partitionPath);
+ partitionBucketCaches.put(partitionPath, cache);
+ cleanIfNecessary(0L, partitionPath);
+ return cache;
}
- @Override
- public void onCheckpointComplete(Correspondent correspondent, long completedCheckpointID) {
- Map<Long, String> inflightInstants = correspondent.requestInflightInstants();
- log.info("Inflight instants and the corresponding checkpoints: {}, notified completed checkpoints: {}",
- inflightInstants, completedCheckpointID);
- // if there are no inflight instants,
- // the latest completed checkpoint id is used as the minimum checkpoint id,
- // since the streaming write operator always uses previous checkpoint id to request the new instant.
- recordIndexCache.markAsEvictable(inflightInstants.keySet().stream().min(Long::compareTo).orElse(completedCheckpointID));
- this.metaClient.reloadActiveTimeline();
- reloadMetadataTable();
+ private BucketCache bootstrapPartition(String partitionPath) {
+ BucketCache cache = createBucketCache(partitionPath);
+ if (!metaClient.getTableConfig().isMetadataPartitionAvailable(MetadataPartitionType.RECORD_INDEX)) {
+ log.info("Record index is not available yet. Start partitioned RLI cache empty for partition {}", partitionPath);
+ return cache;
+ }
+
+ try {
+ Map<String, List<FileSlice>> partitionedFileGroups =
+ metadataTable.getBucketizedFileGroupsForPartitionedRLI(MetadataPartitionType.RECORD_INDEX);
+ List<FileSlice> fileSlices = partitionedFileGroups.get(partitionPath);
+ if (fileSlices == null || fileSlices.isEmpty()) {
+ return cache;
+ }
+ HoodiePairData<String, HoodieRecordGlobalLocation> locations =
+ metadataTable.readRecordIndexLocations(fileSlicesToFilter -> fileSlices);
+ final AtomicLong totalCnt = new AtomicLong();
+ locations.forEach(locationPair -> {
+ String recordKey = locationPair.getLeft();
+ String fileId = locationPair.getRight().getFileId();
+ if (bootstrapFilter.shouldLoad(partitionPath, recordKey, fileId)) {
+ cache.putRecordKey(recordKey, fileId, true);
+ }
+ totalCnt.incrementAndGet();
+ });
+ log.info("Bootstrapped partitioned RLI cache for partition {} with {} owned records from total {} RLI records.",
+ partitionPath, cache.size(), totalCnt.get());
+ return cache;
+ } catch (Exception e) {
+ cache.close();
+ throw new HoodieException("Failed to bootstrap partitioned RLI cache for partition " + partitionPath, e);
+ }
+ }
+
+ private BucketCache createBucketCache(String partitionPath) {
+ long inferredCacheSize = inferMemorySizeForCache();
+ cleanIfNecessary(inferredCacheSize, partitionPath);
+ return newBucketCache(createSpillableMap(partitionPath, inferredCacheSize), Long.MIN_VALUE);
+ }
+
+ private ExternalSpillableMap<String, Integer> createSpillableMap(String partitionPath, long inferredCacheSize) {
+ // preserve some memory for fileId dict, assuming the average file group number as Short.MAX_VALUE, then the size will be about 1MB.
+ long maxInMemorySizeInBytes = Math.max(inferredCacheSize - BucketCache.FILE_ID_DICT_ENTRY_SIZE * Short.MAX_VALUE, 1);
+ try {
+ return new ExternalSpillableMap<>(
+ maxInMemorySizeInBytes,
+ writeConfig.getSpillableMapBasePath(),
+ new DefaultSizeEstimator<>(),
+ new DefaultSizeEstimator<>(),
+ ExternalSpillableMap.DiskMapType.ROCKS_DB,
+ new DefaultSerializer<>(),
+ writeConfig.getBoolean(HoodieCommonConfig.DISK_MAP_BITCASK_COMPRESSION_ENABLED),
+ "PartitionedRLICache-" + partitionPath);
+ } catch (IOException e) {
+ throw new HoodieIOException("Failed to create partitioned RLI cache for partition " + partitionPath, e);
+ }
}
private void reloadMetadataTable() {
+ closeMetadataTable();
this.metadataTable = metaClient.getTableFormat().getMetadataFactory().create(
HoodieFlinkEngineContext.DEFAULT,
metaClient.getStorage(),
StreamerUtil.metadataConfig(conf),
conf.get(FlinkOptions.PATH));
}
+ private void updateEvictableCkp(long checkpointId) {
+ ValidationUtils.checkArgument(checkpointId >= minRetainedCheckpointId,
+ String.format("The minimum retained checkpoint id should be increased, previous: %s, received: %s",
+ minRetainedCheckpointId, checkpointId));
+ minRetainedCheckpointId = checkpointId;
+ }
+
+ private long inferMemorySizeForCache() {
+ if (partitionBucketCaches.isEmpty()) {
+ return maxCacheSizeInBytes / 2;
Review Comment:
We now have a total cache size limit `index.rli.cache.size`, but cache allocation for each bucket cache of one partition needs more consideration, will update later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349466901
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `58.33333%` with `125 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.20%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`ebe621a`](https://app.codecov.io/gh/apache/hudi/commit/ebe621ace81729f610a1752a63233ac53b69ff9f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ink/partitioner/index/RecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9SZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 53.84% | [53 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ain/java/org/apache/hudi/sink/utils/Pipelines.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPipelines.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QaXBlbGluZXMuamF2YQ==) | 0.00% | [20 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/sink/bucket/BucketStreamWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fbucket%2FBucketStreamWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9idWNrZXQvQnVja2V0U3RyZWFtV3JpdGVGdW5jdGlvbi5qYXZh) | 32.14% | [16 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../hudi/sink/partitioner/RecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9SZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 54.54% | [8 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rtitioner/index/GlobalRecordLevelIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordLevelIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRMZXZlbEluZGV4QmFja2VuZC5qYXZh) | 88.23% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/table/HoodieTableFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTableFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllVGFibGVGYWN0b3J5LmphdmE=) | 0.00% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | 88.23% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/sink/partitioner/index/IndexWriteFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexWriteFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleFdyaXRlRnVuY3Rpb24uamF2YQ==) | 60.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
============================================
- Coverage 68.06% 67.20% -0.87%
+ Complexity 28909 28610 -299
============================================
Files 2518 2521 +3
Lines 140572 140797 +225
Branches 17422 17444 +22
============================================
- Hits 95684 94621 -1063
- Misses 37032 38264 +1232
- Partials 7856 7912 +56
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.39% <58.33%> (+0.02%)` | :arrow_up: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.97% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.43% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <0.00%> (-3.82%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <0.00%> (-0.01%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.71% <0.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...org/apache/hudi/configuration/OptionsResolver.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fconfiguration%2FOptionsResolver.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlndXJhdGlvbi9PcHRpb25zUmVzb2x2ZXIuamF2YQ==) | `69.86% <100.00%> (+1.77%)` | :arrow_up: |
| [...he/hudi/sink/partitioner/BucketAssignFunction.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FBucketAssignFunction.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9CdWNrZXRBc3NpZ25GdW5jdGlvbi5qYXZh) | `93.42% <ø> (ø)` | |
| [...sink/partitioner/index/FlinkStateIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FFlinkStateIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9GbGlua1N0YXRlSW5kZXhCYWNrZW5kLmphdmE=) | `100.00% <ø> (ø)` | |
| [...sink/partitioner/index/GlobalRecordIndexCache.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FGlobalRecordIndexCache.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9HbG9iYWxSZWNvcmRJbmRleENhY2hlLmphdmE=) | `94.73% <100.00%> (ø)` | |
| [...ache/hudi/sink/partitioner/index/IndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmQuamF2YQ==) | `100.00% <ø> (ø)` | |
| [...di/sink/partitioner/index/IndexBackendFactory.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FIndexBackendFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9JbmRleEJhY2tlbmRGYWN0b3J5LmphdmE=) | `46.66% <100.00%> (ø)` | |
| [...di/sink/partitioner/index/RocksDBIndexBackend.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2Findex%2FRocksDBIndexBackend.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9pbmRleC9Sb2Nrc0RCSW5kZXhCYWNrZW5kLmphdmE=) | `80.00% <ø> (ø)` | |
| [...apache/hudi/sink/utils/PeriodicActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Futils%2FPeriodicActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay91dGlscy9QZXJpb2RpY0FjdGlvbkV4ZWN1dG9yLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `75.55% <50.00%> (-8.30%)` | :arrow_down: |
| [...sink/partitioner/GlobalRecordIndexPartitioner.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fsink%2Fpartitioner%2FGlobalRecordIndexPartitioner.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvc2luay9wYXJ0aXRpb25lci9HbG9iYWxSZWNvcmRJbmRleFBhcnRpdGlvbmVyLmphdmE=) | `88.23% <88.23%> (ø)` | |
| ... and [7 more](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [153 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349712438
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.66%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 39 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|4|
>|spark-scala-tests|17|6|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.66% -20.41%
+ Complexity 28909 17021 -11888
=============================================
Files 2518 2047 -471
Lines 140572 116955 -23617
Branches 17422 15205 -2217
=============================================
- Hits 95684 55743 -39941
- Misses 37032 55086 +18054
+ Partials 7856 6126 -1730
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.04% <0.00%> (-16.61%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.55% <0.00%> (-12.15%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(flink): Support streaming RLI write for simple bucket index [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18645:
URL: https://github.com/apache/hudi/pull/18645#issuecomment-4349699693
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.30%. Comparing base ([`8d348cc`](https://app.codecov.io/gh/apache/hudi/commit/8d348cc6b927bb63944e11db2b208bccff8fbb55?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3587d36`](https://app.codecov.io/gh/apache/hudi/commit/3587d3640ec016284e7667655820c5c6aa652999?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
> :exclamation: There is a different number of reports uploaded between BASE (8d348cc) and HEAD (3587d36). Click for more details.
>
> <details><summary>HEAD has 43 uploads less than BASE</summary>
>
>| Flag | BASE (8d348cc) | HEAD (3587d36) |
>|------|------|------|
>|spark-java-tests|30|1|
>|spark-scala-tests|17|5|
>|utilities|1|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18645 +/- ##
=============================================
- Coverage 68.06% 47.30% -20.77%
+ Complexity 28909 16846 -12063
=============================================
Files 2518 2047 -471
Lines 140572 116955 -23617
Branches 17422 15205 -2217
=============================================
- Hits 95684 55327 -40357
- Misses 37032 55584 +18552
+ Partials 7856 6044 -1812
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.94% <0.00%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.42% <0.00%> (-0.01%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <0.00%> (-15.53%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.74% <0.00%> (-11.97%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18645/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18645?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18645?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | `67.14% <0.00%> (-16.72%)` | :arrow_down: |
... and [1571 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18645/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org