You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by MikeThomsen <gi...@git.apache.org> on 2018/06/14 21:59:23 UTC

[GitHub] nifi pull request #2736: NIFI-5223 Allow the usage of expression language fo...

Github user MikeThomsen commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2736#discussion_r195584322
  
    --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-service-api/src/main/java/org/apache/nifi/serialization/RecordSetWriterFactory.java ---
    @@ -76,5 +78,23 @@
          * @return a RecordSetWriter that can write record sets to an OutputStream
          * @throws IOException if unable to read from the given InputStream
          */
    -    RecordSetWriter createWriter(ComponentLog logger, RecordSchema schema, OutputStream out) throws SchemaNotFoundException, IOException;
    --- End diff --
    
    I agree with @pvillard31 on this point. We can't really change service interfaces with a very compelling reason otherwise we'll alienate third party developers.


---