You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wankai123 (via GitHub)" <gi...@apache.org> on 2023/07/30 02:52:27 UTC
[GitHub] [skywalking] wankai123 commented on a diff in pull request #11148: Apply MQE on APISIX, AWS_EKS, AWS_GATEWAY and AWS_S3 layer UI templates
wankai123 commented on code in PR #11148:
URL: https://github.com/apache/skywalking/pull/11148#discussion_r1278481284
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/aws_eks/aws_eks-cluster.json:
##########
@@ -443,38 +451,35 @@
"dashboardName": "AWS_EKS-node",
"fontSize": 12
},
- "metrics": [
- "eks_cluster_node_cpu_utilization",
- "eks_cluster_node_memory_utilization",
- "eks_cluster_node_network_tx_errors",
- "eks_cluster_node_network_rx_errors"
+ "expressions": [
+ "avg(eks_cluster_node_cpu_utilization/100)",
+ "avg(eks_cluster_node_memory_utilization/100)",
Review Comment:
Please confirm if cpu and memory usage needs div 100, the previous calculation is only average
##########
oap-server/server-starter/src/main/resources/ui-initialized-templates/aws_eks/aws_eks-cluster.json:
##########
@@ -497,38 +502,35 @@
"showYAxis": false,
"showGroup": true
},
- "metrics": [
- "eks_cluster_service_pod_cpu_utilization",
- "eks_cluster_service_pod_memory_utilization",
- "eks_cluster_service_pod_net_tx_error",
- "eks_cluster_service_pod_net_rx_error"
+ "expressions": [
+ "avg(eks_cluster_service_pod_cpu_utilization/100)",
+ "avg(eks_cluster_service_pod_memory_utilization/100)",
Review Comment:
The same as above needs to confirm `/100`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org