You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "Zand100 (via GitHub)" <gi...@apache.org> on 2024/11/12 00:50:05 UTC
[PR] store unsafe batches data [incubator-gluten]
Zand100 opened a new pull request, #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: \#ISSUE-ID)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "Zand100 (via GitHub)" <gi...@apache.org>.
Zand100 commented on code in PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#discussion_r1839274420
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/ColumnarBuildSideRelation.scala:
##########
@@ -60,15 +60,16 @@ case class ColumnarBuildSideRelation(output: Seq[Attribute], batches: Array[Arra
var batchId = 0
override def hasNext: Boolean = {
- batchId < batches.length
+ batchId < batches.getLength
}
override def next: ColumnarBatch = {
- val handle =
- jniWrapper
- .deserialize(serializeHandle, batches(batchId))
+ val batch = batches.get(batchId)
+ val columnVector = new OffHeapColumnVector(batch.numElements(), DataTypes.BinaryType)
+ columnVector.putByteArray(batchId, batch.toByteArray, batch.getBaseOffset.toInt, batch.numElements)
+ val columnarBatch = new ColumnarBatch(Array(columnVector))
Review Comment:
@zhztheplayer Is it alright to create the `ColumnarBatch` this way, using `OffHeapColumnVector` and constructing a new `ColumnarBatch` directly from that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "Zand100 (via GitHub)" <gi...@apache.org>.
Zand100 commented on code in PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#discussion_r1837347383
##########
backends-velox/src/main/scala/org/apache/spark/sql/execution/UnsafeArray.scala:
##########
@@ -0,0 +1,58 @@
+package org.apache.spark.sql.execution
+
+import org.apache.spark.memory.{MemoryConsumer, SparkOutOfMemoryError, TaskMemoryManager}
+import org.apache.spark.sql.catalyst.expressions.UnsafeArrayData
+import org.apache.spark.unsafe.{Platform, UnsafeAlignedOffset}
+import org.apache.spark.unsafe.memory.MemoryBlock
+
+class UnsafeArray(taskMemoryManager: TaskMemoryManager) extends MemoryConsumer {
+
+ protected var page: MemoryBlock = null
+ acquirePage(taskMemoryManager.pageSizeBytes)
+ protected var base: AnyRef = page.getBaseObject
+ protected var pageCursor = 0
+ private var keyOffsets: Array[Long] = null
+ protected var numRows = 0
+
+ def iterator() {}
+
+ private def acquirePage(requiredSize: Long): Boolean = {
+ try page = allocatePage(requiredSize)
+
+ catch {
+ case SparkOutOfMemoryError =>
+ return false
+ }
+ base = page.getBaseObject
+ pageCursor = 0
+ true
+ }
+
+ def get(rowId: Int): UnsafeArrayData = {
+ val offset = keyOffsets(rowId)
+ val klen = UnsafeAlignedOffset.getSize(base, offset - UnsafeAlignedOffset.getUaoSize)
+ val result = new UnsafeArrayData
+ result.pointTo (base, offset, klen)
+ result
+ }
+
+ def write(bytes: Array[Byte], inputOffset: Long, inputLength: Int): Unit = {
+ var offset: Long = page.getBaseOffset + pageCursor
+ val recordOffset = offset
+
+ val uaoSize = UnsafeAlignedOffset.getUaoSize
+
+ val recordLength = 2L * uaoSize + inputLength + 8L
+
+ UnsafeAlignedOffset.putSize(base, offset, inputLength + uaoSize)
+ offset += 2L * uaoSize
Review Comment:
I'm not sure if I'm calculating the `offset` correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#issuecomment-2689527122
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] store unsafe batches data [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#issuecomment-2469365533
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "zhztheplayer (via GitHub)" <gi...@apache.org>.
zhztheplayer commented on PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#issuecomment-2469823818
@Zand100 Is there any test case can be added for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "Zand100 (via GitHub)" <gi...@apache.org>.
Zand100 commented on PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#issuecomment-2472230615
I'm planning to write unit and integration tests. I'm still getting familiar with the code. I'm guessing for `UnsafeArray`, I'll write tests similar to https://github.com/apache/spark/blob/master/core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java. Could you please point me to some other places to update tests? (I couldn't find the tests for`ColumnarBuildSideRelation`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#issuecomment-2569889215
@Zand100 are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#issuecomment-2564583364
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7902: [GLUTEN-7750][VL]: store unsafe batches data
URL: https://github.com/apache/incubator-gluten/pull/7902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#issuecomment-2664434099
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7750][VL]: store unsafe batches data [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7902:
URL: https://github.com/apache/incubator-gluten/pull/7902#issuecomment-2469367284
https://github.com/apache/incubator-gluten/issues/7750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org