You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/31 22:01:30 UTC
[GitHub] [maven-site] edburns opened a new pull request #188: Introduce section heading for BOM pattern
edburns opened a new pull request #188:
URL: https://github.com/apache/maven-site/pull/188
modified: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
- TOC: * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}
- ** {Bill of Materials (BOM) poms}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #188: Introduce section heading for BOM pattern
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463952483
##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
* {{{Importing_Dependencies}Importing Dependencies}}
+ * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}
Review comment:
That is not what I was referring to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] edburns commented on pull request #188: Introduce section heading for BOM pattern
Posted by GitBox <gi...@apache.org>.
edburns commented on pull request #188:
URL: https://github.com/apache/maven-site/pull/188#issuecomment-672292707
Hello, this is approved. Can someone please merge it, or let me know what I need to do to have it merged?
Thanks,
Ed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] mkarg commented on a change in pull request #188: Introduce section heading for BOM pattern
Posted by GitBox <gi...@apache.org>.
mkarg commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463934565
##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
* {{{Importing_Dependencies}Importing Dependencies}}
+ * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}
Review comment:
I think what Ed wanted to say with this is correct: "Bill of Material - style POM, a.k.a. BOM"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] michael-o commented on a change in pull request #188: Introduce section heading for BOM pattern
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #188:
URL: https://github.com/apache/maven-site/pull/188#discussion_r463934456
##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -48,6 +48,8 @@ Introduction to the Dependency Mechanism
* {{{Importing_Dependencies}Importing Dependencies}}
+ * {{{bill-of-materials-bom-poms}Bill of Materials (BOM) poms}}
Review comment:
poms > POMs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] edburns commented on pull request #188: Introduce section heading for BOM pattern
Posted by GitBox <gi...@apache.org>.
edburns commented on pull request #188:
URL: https://github.com/apache/maven-site/pull/188#issuecomment-668297271
@michael-o I applied the suggested changes and squashed it to one commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] olamy merged pull request #188: Introduce section heading for BOM pattern
Posted by GitBox <gi...@apache.org>.
olamy merged pull request #188:
URL: https://github.com/apache/maven-site/pull/188
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-site] edburns commented on pull request #188: Introduce section heading for BOM pattern
Posted by GitBox <gi...@apache.org>.
edburns commented on pull request #188:
URL: https://github.com/apache/maven-site/pull/188#issuecomment-667405962
Given how important BOM poms are, I think they deserve a section heading here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org