[GitHub] [incubator-mxnet] nickguletskii commented on issue #17177: [1.x] Fix incorrect calculation results when the C locale is set to a locale that uses commas as the decimal separator

[GitBox <gi...@apache.org>]

nickguletskii commented on issue #17177: [1.x] Fix incorrect calculation results when the C locale is set to a locale that uses commas as the decimal separator
URL: https://github.com/apache/incubator-mxnet/pull/17177#issuecomment-615153501
 
 
   @marcoabreu I think it would be better to add a (nightly) CI job that will run the whole test suite with a locale that is vastly different from `en_US.UTF-8`. While this PR solves the issues related to the usage of ``std::stod`` and ``std::stof``, there's no guarantee that there aren't any more subtle locale-related issues that are quietly truncating/changing values inside MXNet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services