[GitHub] [james-project] chibenwa commented on a change in pull request #422: JAMES-XXXX Configurable protocol for JMAP configuration

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #422:
URL: https://github.com/apache/james-project/pull/422#discussion_r628265253



##########
File path: server/protocols/jmap-rfc-8621-integration-tests/memory-jmap-rfc-8621-integration-tests/src/test/resources/jmap.properties
##########
@@ -1,3 +1,5 @@
 # Configuration urlPrefix for JMAP routes.
-url.prefix=http://domain.com
+protocol.jmap=http
+protocol.ws=ws
+url.prefix=domain.com

Review comment:
       That is a breaking change. And breaking changes are bad.
   
   I would propose:
   
   ```
   url.prefix=http://domain.com
   websocket.url.prefix=ws://domain.com
   ```
   
   That way if you don't change your config, you will not end up with an unwanted behaviour.
   
   Bonus: One could set up proxying to a dedicated websocket server, and advertise that through the session, using a completely distinct load balancer... <3




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org