You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lahodaj (via GitHub)" <gi...@apache.org> on 2024/03/27 13:05:31 UTC
[PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
lahodaj opened a new pull request, #7201:
URL: https://github.com/apache/netbeans/pull/7201
Currently, when a module sets `requires.nb.javac`, it cannot have `javac.source`/`javac.target` > 8, and the use of `--release` is disabled for it. This is because the `requires.nb.javac` is implemented using `-Xbootclasspath/p:`, which is incompatible with both `javac.source` > 8 and `--release`.
As NetBeans now practically only supports JDK 17 as the build/runtime JDK, this is becoming increasingly troublesome. JDK 17 includes things like Text Blocks, which would be immensely useful for writing tests, but we cannot use that because `javac.source` is stuck on `8` for the javac-based modules.
There are multiple ways out of this, but the one in this patch is that we run the compilation with `--limit-modules` setup in such a way that `java.compiler` and `jdk.compiler` are disabled. The correct javac is then pulled from the classpath as any ordinary library. This is a bit tricky, as it means we need to list modules that should be enabled. This is achieved using a custom Ant task, which may run a probe on the target JDK, determining modules that are neither `java.compiler` nor `jdk.compiler`, and do not depend either of these.
Some alternatives:
- using `--patch-module`, and replace the content of the module (which may be tricky, as this does not remove the all module content)
- having more precise dependencies on JDK modules inside `project.xml`, and specifically setup the system module paths to only include these modules. This would work, but is a lot of more work. So, while we may do that in the long run, the patch here still seems reasonable for now to me.
There is an obvious relation to https://github.com/apache/netbeans/pull/7188 - either this or that patch will need tweaks to accommodate changes from the other. I am completely fine with doing that here, assuming there's a reasonable timeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2132248850
> +1 to removing those that match. There can be times where they deliberately don't match and those should probably be reviewed separately.
well, as you can see in https://github.com/mbien/netbeans/commit/af7798df16a63f93e6a097e09c2c9dcce578523a and https://github.com/mbien/netbeans/commit/8db6aabca483f87ccafa1782bbe91a4d3c7671d2, I bumped `javac.release` to the value of `OpenIDE-Module-Java-Dependencies`. There was luckily no instance where lang level was `>` manifest attribute
the reason it wasn't synced in the first place was likely due to https://github.com/apache/netbeans/issues/6817 which this PR would fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2130795567
Hi @lahodaj and reviewers,
I tested this by rebasing this PR on latest master which contains the other `javac.release` changes (https://github.com/apache/netbeans/pull/7247), and then adding another commit which sets `javac.release` to all modules which set `OpenIDE-Module-Java-Dependencies` in their manifest. I did also open all involved modules with NB 22 and checked if the editor is picking everything up properly (verifies that https://github.com/apache/netbeans/pull/7188 is working).
tests are currently running at https://github.com/mbien/netbeans/actions/runs/9233121350?pr=1
since my branch is already rebased and squashed, I could force push this into this PR if you want and we take another quick look and merge as two commits?
https://github.com/mbien/netbeans/commits/java-modules-using-jdk9-plus/
- https://github.com/mbien/netbeans/commit/646f89dced05ac1a0214be118f81eb052b3cb6eb this PR, rebased and squashed
- https://github.com/mbien/netbeans/commit/af7798df16a63f93e6a097e09c2c9dcce578523a additional commit which sets `javac.release`
let me know what to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2049582185
> the diff below would make the tests pass. It moves the tests to the build-tools job which is JDK 17 and disables some. Feel free to apply to your changes if you want.
Thanks! I've applied your patch, except for the change in source/target for apisupport.ant:
https://github.com/apache/netbeans/pull/7201/commits/ea4246cf8a624e89d26445cc78c1209e1a1304e6
Lets see is tests will pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2132703850
I was getting ready to ask whether we can integrate this, so thanks for being quicker. I am +1 on integrating this, and +1 on removing obvious unnecessary manifest entries. Keeping those that are not obvious separate would surely be good.
Thanks for working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2132818366
awesome! Squashed and pushed. Your changes are the first commit (unmodified, just squashed), the javac.release/manifest updates are in the second commit.
Planning to merge today, if anyone still wants to look through it - there is still time to make changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#discussion_r1550209915
##########
nbbuild/antsrc/org/netbeans/nbbuild/extlibs/SetupLimitModules.java:
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.nbbuild.extlibs;
+
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.lang.ProcessBuilder.Redirect;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Properties;
+import org.apache.tools.ant.BuildException;
+import org.apache.tools.ant.Task;
+
+/**
+ *
+ */
+public class SetupLimitModules extends Task {
+
+ private String limitModulesProperty;
+ private String releaseVersion;
+ private String excludedModules;
+ private String nbjdkHome;
+ private File cacheFile;
+
+ public void setLimitModulesProperty(String limitModulesProperty) {
+ this.limitModulesProperty = limitModulesProperty;
+ }
+
+ public void setReleaseVersion(String releaseVersion) {
+ this.releaseVersion = releaseVersion;
+ }
+
+ public void setExcludedModules(String excludedModules) {
+ this.excludedModules = excludedModules;
+ }
+
+ public void setNbjdkHome(String nbjdkHome) {
+ this.nbjdkHome = nbjdkHome;
+ }
+
+ public void setCacheFile(File cacheFile) {
+ this.cacheFile = cacheFile;
+ }
+
+ @Override
+ public void execute() throws BuildException {
+ try {
+ Properties cache = new Properties();
+
+ if (cacheFile != null && cacheFile.canRead()) {
+ try (InputStream in = new FileInputStream(cacheFile)) {
+ cache.load(in);
+ }
+ }
+
+ String cacheKey = nbjdkHome + "-" + releaseVersion;
+ String limitedModules = cache.getProperty(cacheKey);
+
+ if (limitedModules == null) {
+ String antlibJar = SetupLimitModules.class
+ .getProtectionDomain()
+ .getCodeSource()
+ .getLocation()
+ .getPath();
+ List<String> command = new ArrayList<>();
+ command.add(new File(new File(nbjdkHome, "bin"), "java").getAbsolutePath());
+ command.add("-classpath");
+ command.add(antlibJar);
+ command.add("org.netbeans.nbbuild.extlibs.SetupLimitModulesProbe");
+ command.add(releaseVersion);
+ command.addAll(Arrays.asList(excludedModules.split(",")));
+ Process p = new ProcessBuilder(command).redirectError(Redirect.INHERIT).start();
+ p.waitFor();
+ StringBuilder limitModulesText = new StringBuilder();
+ InputStream in = p.getInputStream();
+ int r;
+ while ((r = in.read()) != (-1)) {
+ limitModulesText.append((char) r);
+ }
Review Comment:
is the input stream intentionally left open?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2132273139
> There was luckily no instance where lang level was `>` manifest attribute
That scenario would fail CI tests. I saw your release changes. But there are a few that specify a higher JDK requirement and use reflection to compile with a lower language level. eg. External processes jdk9 shouldn't just have this done, it should be rewritten to use the APIs directly, and folded back into the main module. That's why I asked if we could split out and review those few separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2132246220
@mbien +1 to removing those that match. There can be times where they deliberately don't match and those should probably be reviewed separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2040483025
I suggest the following merge order:
NB 22:
- https://github.com/apache/netbeans/pull/7188
- https://github.com/apache/netbeans/pull/7201 (this PR)
NB 23:
- https://github.com/apache/netbeans/pull/7247 (or some similar PR)
This gives devs a chance to update to NB 22 before starting to use the option (since the build would work but NB would break since it would load everything with 1.4 lang level).
cc @matthiasblaesing @neilcsmith-net
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #7201:
URL: https://github.com/apache/netbeans/pull/7201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2132219529
I have another change to offer. We could now remove the JDK manifest entries entirely, since the build adds them by looking at the `javac.release` property if they aren't there yet.
- https://github.com/mbien/netbeans/commit/8db6aabca483f87ccafa1782bbe91a4d3c7671d2
This would simplify the module configuration to a single value in `project.properties`.
to validate this I diffed the manifest dump of all jars before/after a rebuild using this script:
```bash
find nbbuild/netbeans/ -type f -iname '*.jar' | sort | while read line || [[ -n $line ]];
do
echo "$line/META-INF/MANIFEST.MF"
unzip -p $line META-INF/MANIFEST.MF
done
```
checking all jars in `nbbuild/netbeans/` should be sufficient, right? @matthiasblaesing
i could squash this into my other commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2039220349
make sense for NB22 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2046501282
the diff below would make the tests pass. It moves the tests to the build-tools job which is JDK 17 and disables some. Feel free to apply to your changes if you want.
```diff
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 8c1fcf4..ac9f4ec 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -922,6 +922,10 @@
if: ${{ matrix.java == '17' }}
run: ant $OPTS -f extide/o.apache.tools.ant.module test
+ - name: apisupport.ant
+ if: ${{ matrix.java == '17' }}
+ run: ant $OPTS -f apisupport/apisupport.ant test
+
- name: Create Test Summary
uses: test-summary/action@v2
if: failure()
@@ -1544,9 +1548,6 @@
- name: Extract
run: tar --zstd -xf build.tar.zst
- - name: apisupport.ant
- run: ant $OPTS -f apisupport/apisupport.ant test
-
- name: apisupport.project
run: ant $OPTS -f apisupport/apisupport.project test
diff --git a/apisupport/apisupport.ant/nbproject/project.properties b/apisupport/apisupport.ant/nbproject/project.properties
index 03ab15a..eb26886 100644
--- a/apisupport/apisupport.ant/nbproject/project.properties
+++ b/apisupport/apisupport.ant/nbproject/project.properties
@@ -21,39 +21,16 @@
requires.nb.javac=true
javac.compilerargs=-Xlint -Xlint:-serial
-javac.source=1.8
-javac.release=17
+javac.source=11
+javac.target=11
javadoc.arch=${basedir}/arch.xml
test-unit-sys-prop.test.nbroot=${nb_all}
test-unit-sys-prop.test.netbeans.dest.dir=${netbeans.dest.dir}
test-unit-sys-prop.java.awt.headless=true
-test.config.stableBTD.includes=**/*Test.class
-test.config.stableBTD.excludes=\
- **/AccessibilityQueryImplTest.class,\
- **/AntArtifactProviderImplTest.class,\
- **/ApisupportAntUtilsTest.class,\
- **/AvoidModuleListInProjectConstructorTest.class,\
- **/BrandingSupportTest.class,\
- **/BuildZipDistributionTest.class,\
- **/ClassPathProviderImplTest.class,\
- **/CustomizerLibrariesTest.class,\
- **/EvaluatorTest.class,\
- **/GlobalJavadocForBinaryImplTest.class,\
- **/GlobalSourceForBinaryImplTest.class,\
- **/Issue167725DeadlockTest.class,\
- **/JavadocForBinaryImplTest.class,\
- **/ModuleActionsTest.class,\
- **/ModuleListTest.class,\
- **/ModuleTypePanelTest.class,\
- **/NbModuleProjectTest.class,\
- **/ProjectXMLManagerTest.class,\
- **/SingleModulePropertiesTest.class,\
- **/SourceForBinaryImplTest.class,\
- **/SourceLevelQueryImplTest.class,\
- **/SubprojectProviderImplTest.class,\
- **/SuiteOperationsTest.class,\
- **/TestEntryTest.class,\
- **/UnitTestForSourceQueryImplTest.class,\
- **/UpdateTrackingFileOwnerQueryTest.class
+test.config.default.includes=**/*Test.class
+test.config.default.excludes=\
+ **/ExternalBuildDirTest.class,\
+ **/UseHtml4JavaTest.class
+
diff --git a/apisupport/apisupport.ant/test/unit/src/org/netbeans/modules/apisupport/project/CompilationDependencyTest.java b/apisupport/apisupport.ant/test/unit/src/org/netbeans/modules/apisupport/project/CompilationDependencyTest.java
index 597b38d..ef778b0 100644
--- a/apisupport/apisupport.ant/test/unit/src/org/netbeans/modules/apisupport/project/CompilationDependencyTest.java
+++ b/apisupport/apisupport.ant/test/unit/src/org/netbeans/modules/apisupport/project/CompilationDependencyTest.java
@@ -88,8 +88,9 @@
assertFalse("Successfully compiled when is invalid specification version",
testingProject.getModuleJarLocation().exists());
}
-
- public void testCompileAgainstPublicPackage() throws Exception {
+
+ // TODO fixme
+ public void fails_on_11_testCompileAgainstPublicPackage() throws Exception {
NbModuleProject testingProject = TestBase.generateStandaloneModule(getWorkDir(), "testing");
testingProject.open();
FileObject buildScript = findBuildXml(testingProject);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2133519798
all green -> merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "lahodaj (via GitHub)" <gi...@apache.org>.
lahodaj commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2045846692
FWIW - I've merged with master (to get `javac.release`), and tried adjust this patch for that:
https://github.com/apache/netbeans/pull/7201/commits/a7e81d3f49dfe5b05adeb0365612b98f40bb4e29
Also tried to fix `apisupport.ant` to support the `--limit-modules`. The effective way is that is asks nb-javac about modules for the target source level, which also includes the data for `--release`, and hence this is to a degree independent on the runtime platform. This is:
https://github.com/apache/netbeans/pull/7201/commits/3e88fb031b06fa71af0638ed30a9183bf50cf027
Please let me know what you think!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2059734119
@lahodaj although I do like the changes here, I am a bit worried that this could cause unexpected issues. Would it make more sense to merge this early in the NB 23 dev cycle rather than at the end of NB 22?
One nitpick I have is that I am no fan of duplicated code in the repo, we might find a way to copy SetupLimitModulesProbe.java around before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2022737994
sounds like this would fix https://github.com/apache/netbeans/issues/6817? awesome! Thanks for looking into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Support for requires.nb.javac modules with javac.source/target > 8. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7201:
URL: https://github.com/apache/netbeans/pull/7201#issuecomment-2132366971
> ...That's why I asked if we could split out and review those few separately?
sure. I also just realized while jogging that I broke gradle again since i reverted my own revert (https://github.com/apache/netbeans/pull/7367) with this by setting release to 17 in the first commit :facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists