You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/05/21 22:49:16 UTC

[GitHub] [phoenix] swaroopak commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

swaroopak commented on a change in pull request #785:
URL: https://github.com/apache/phoenix/pull/785#discussion_r428956248



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -635,6 +672,9 @@ public boolean verifySingleIndexRow(Result indexRow, IndexToolVerificationResult
         Collections.sort(expectedMutationList, MUTATION_TS_DESC_COMPARATOR);
         Collections.sort(actualMutationList, MUTATION_TS_DESC_COMPARATOR);
         if (verifyType == IndexTool.IndexVerifyType.ONLY) {
+            if (actualMutationList.get(0) instanceof Put) {

Review comment:
       this means only the latest row right?
   in that case, a comment would be helpful here 
   "Read repair would happen on the latest row hence considering the latest mutation to update the Unverified counters" or something on the similar lines?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org