[GitHub] jlahoda commented on issue #248: adding crlf characters for the failing tests in api.templates

[GitBox <gi...@apache.org>]

jlahoda commented on issue #248: adding crlf characters for the failing tests in api.templates
URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-342469201
 
 
   My personal opinion: ideally tests should pass/work on both Linux and Windows. Instead of playing with different line endings in the expected text, I'd suggest to normalize to one line endings format (ideally the Linux one). I.e. the expected text would have only one format ('\n') of line endings, just readFile(newForm) would do '.replace("\r\n", "\n")' or '.replace(System.getProperty("line.separator"), "\n")'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services