You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2017/03/08 03:05:43 UTC

Review Request 57408: ATLAS-1657 Taxonomy term disassociation with assets fail

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57408/
-----------------------------------------------------------

Review request for atlas.


Bugs: ATLAS-1657
    https://issues.apache.org/jira/browse/ATLAS-1657


Repository: atlas


Description
-------

Since it calls older typesystem APIs directly, the v2 typesystem is not aware of the classifications created. Changing this to v2 as required


Diffs
-----

  catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java ea967f9 
  repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 6ce1bba 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java e3c9e1b 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 13b0250 
  webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 2c385c9 
  webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java 0cb112a 
  webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java cba78f3 


Diff: https://reviews.apache.org/r/57408/diff/1/


Testing
-------

All UTS pass


Thanks,

Suma Shivaprasad


Re: Review Request 57408: ATLAS-1657 Taxonomy term disassociation with assets fail

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57408/#review168244
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On March 8, 2017, 3:40 a.m., Suma Shivaprasad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57408/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 3:40 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1657
>     https://issues.apache.org/jira/browse/ATLAS-1657
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Since it calls older typesystem APIs directly, the v2 typesystem is not aware of the classifications created. Changing this to v2 as required
> 
> 
> Diffs
> -----
> 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java ea967f9 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6d3a9f5 
>   repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java 6ce1bba 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java e3c9e1b 
>   webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 13b0250 
>   webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 2c385c9 
>   webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java 0cb112a 
>   webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java cba78f3 
> 
> 
> Diff: https://reviews.apache.org/r/57408/diff/2/
> 
> 
> Testing
> -------
> 
> All UTS pass
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>


Re: Review Request 57408: ATLAS-1657 Taxonomy term disassociation with assets fail

Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57408/
-----------------------------------------------------------

(Updated March 8, 2017, 3:40 a.m.)


Review request for atlas.


Changes
-------

Fixed issue with typename check


Bugs: ATLAS-1657
    https://issues.apache.org/jira/browse/ATLAS-1657


Repository: atlas


Description
-------

Since it calls older typesystem APIs directly, the v2 typesystem is not aware of the classifications created. Changing this to v2 as required


Diffs (updated)
-----

  catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java ea967f9 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 6d3a9f5 
  repository/src/main/java/org/apache/atlas/repository/converters/TypeConverterUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/util/RestUtils.java 6ce1bba 
  webapp/src/main/java/org/apache/atlas/web/resources/EntityService.java e3c9e1b 
  webapp/src/main/java/org/apache/atlas/web/resources/TaxonomyService.java 13b0250 
  webapp/src/main/java/org/apache/atlas/web/resources/TypesResource.java 2c385c9 
  webapp/src/test/java/org/apache/atlas/util/RestUtilsTest.java 0cb112a 
  webapp/src/test/java/org/apache/atlas/web/resources/TaxonomyServiceTest.java cba78f3 


Diff: https://reviews.apache.org/r/57408/diff/2/

Changes: https://reviews.apache.org/r/57408/diff/1-2/


Testing
-------

All UTS pass


Thanks,

Suma Shivaprasad