You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2025/01/11 15:22:59 UTC
[PR] GitHub issues - release vote [maven-site]
slawekjaranowski opened a new pull request, #641:
URL: https://github.com/apache/maven-site/pull/641
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GitHub issues - release vote [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #641:
URL: https://github.com/apache/maven-site/pull/641#discussion_r1913044547
##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -153,12 +153,28 @@ Vote open for at least 72 hours.
-----
+** JIRA issues
+
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.
+** GitHub issues
+
+ We provide link to <GitHub milestone> as resolved issues and for left issues link to <GitHub issues>, like:
Review Comment:
I'm not sure what you mean by "left issues". Unfinished issues maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GitHub issues - release vote [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #641:
URL: https://github.com/apache/maven-site/pull/641#discussion_r1913102989
##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -153,12 +153,28 @@ Vote open for at least 72 hours.
-----
+** JIRA issues
+
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.
+** GitHub issues
+
+ We provide link to <GitHub milestone> as resolved issues and for left issues link to <GitHub issues>, like:
Review Comment:
We don't need to quote this directly. "left" as an adjective is a little weird. When it precedes the noun, it almost always refers to the left hand side, and not to things left behind. If we want to indicate that something was left behind we'd follow the noun. That is, we'd say "The people left when the plane took off" and not "The left people when the plane took off". I'm guessing this is one of those weird rules of English native speakers don't think about. I never noticed it until just now.
Maybe something like
We link to the <GitHub milestone> for issues resolved in the release, and link to <GitHub issues> for issues that are still open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GitHub issues - release vote [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #641:
URL: https://github.com/apache/maven-site/pull/641#discussion_r1912506206
##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -153,12 +153,28 @@ Vote open for at least 72 hours.
-----
+** JIRA issues
+
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.
+** GitHub issues
+
+ We provide link to <GitHub milestone> as resolved issues and for left issues link to <GitHub issues>, like:
+
+-----
+
+We solved N issues:
+https://github.com/apache/<repository-name>/milestone/1?closed=1
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GitHub issues - release vote [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #641:
URL: https://github.com/apache/maven-site/pull/641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GitHub issues - release vote [maven-site]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on code in PR #641:
URL: https://github.com/apache/maven-site/pull/641#discussion_r1912161568
##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -153,12 +153,28 @@ Vote open for at least 72 hours.
-----
+** JIRA issues
+
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.
+** GitHub issues
+
+ We provide link to <GitHub milestone> as resolved issues and for left issues link to <GitHub issues>, like:
+
+-----
+
+We solved N issues:
+https://github.com/apache/<repository-name>/milestone/1?closed=1
Review Comment:
Do you want to replace `1` with something like `<milestone-number>` (like repository name)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GitHub issues - release vote [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #641:
URL: https://github.com/apache/maven-site/pull/641#discussion_r1913481449
##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -153,12 +153,28 @@ Vote open for at least 72 hours.
-----
+** JIRA issues
+
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.
+** GitHub issues
+
+ We provide link to <GitHub milestone> as resolved issues and for left issues link to <GitHub issues>, like:
Review Comment:
@elharo fixed as proposed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GitHub issues - release vote [maven-site]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #641:
URL: https://github.com/apache/maven-site/pull/641#discussion_r1913610376
##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -153,12 +153,28 @@ Vote open for at least 72 hours.
-----
+** JIRA issues
+
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.
+** GitHub issues
+
+ We link to the <GitHub milestone> for issues resolved in the release, and link to <GitHub issues> for issues that are still open
Review Comment:
nit: colon or period at end of sentence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GitHub issues - release vote [maven-site]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #641:
URL: https://github.com/apache/maven-site/pull/641#discussion_r1913066562
##########
content/apt/developers/release/maven-project-release-procedure.apt:
##########
@@ -153,12 +153,28 @@ Vote open for at least 72 hours.
-----
+** JIRA issues
+
To get the JIRA release notes link, browse to the plugin's or component's JIRA page, select the <Releases> link, pick a version,
and use the link to <Release Notes> that is next to the version being released.
To get the list of issues left in JIRA, browse to the plugin's or component's JIRA page, and from the <Preset Filters>
on the right, use the link for <Outstanding> issues.
+** GitHub issues
+
+ We provide link to <GitHub milestone> as resolved issues and for left issues link to <GitHub issues>, like:
Review Comment:
There is already a text:
> There are still a couple of issues left in JIRA:
so I follow what we have
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org