[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6551: framebuffer for e-ink display. Added callback function to redraw.

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #6551:
URL: https://github.com/apache/incubator-nuttx/pull/6551#discussion_r912860389


##########
drivers/lcd/ssd1680.c:
##########
@@ -1312,8 +1303,8 @@ FAR struct lcd_dev_s *ssd1680_initialize(FAR struct spi_dev_s *dev,
   return &priv->dev;
 }
 
-FAR void *bitscpy_ds(FAR void *dest, int dest_offset, FAR const void *src,
-    size_t nbits)
+static FAR void *bitscpy_ds(FAR void *dest, int dest_offset,
+    FAR const void *src, size_t nbits)

Review Comment:
   If possible:
   ```suggestion
   static FAR void *bitscpy_ds(FAR void *dest, int dest_offset,
                               FAR const void *src, size_t nbits)
   ```



##########
drivers/lcd/ssd1680.c:
##########
@@ -1371,8 +1362,8 @@ FAR void *bitscpy_ds(FAR void *dest, int dest_offset, FAR const void *src,
   return dest;
 }
 
-FAR void *bitscpy_ss(FAR void *dest, FAR const void *src, int src_offset,
-    size_t nbits)
+static FAR void *bitscpy_ss(FAR void *dest, FAR const void *src,
+    int src_offset, size_t nbits)

Review Comment:
   If possible:
   ```suggestion
   static FAR void *bitscpy_ss(FAR void *dest, FAR const void *src,
                               int src_offset, size_t nbits)
   ```



##########
include/nuttx/lcd/lcd.h:
##########
@@ -137,6 +137,8 @@ struct lcd_planeinfo_s
    * buffers.
    */
 
+  int (*redraw)(FAR struct lcd_dev_s *dev);

Review Comment:
   I think this should be moved and placed below `getarea`. A proper description should be added as well



##########
drivers/lcd/ssd1680.c:
##########
@@ -126,11 +126,11 @@ struct ssd1680_dev_s
 
 /* Libc extension */

Review Comment:
   is below interface really a `Libc extension`? Or it is a copy-paste leftover?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org