[GitHub] [apisix] bzp2010 commented on a diff in pull request #7775: feat(admin-api): support check conf only, don't write etcd

[GitBox <gi...@apache.org>]

bzp2010 commented on code in PR #7775:
URL: https://github.com/apache/apisix/pull/7775#discussion_r953260562


##########
apisix/admin/init.lua:
##########
@@ -130,13 +130,18 @@ local function run()
     local uri_segs = core.utils.split_uri(ngx.var.uri)
     core.log.info("uri: ", core.json.delay_encode(uri_segs))
 
+    local check_only = false
     -- /apisix/admin/schema/route
     local seg_res, seg_id = uri_segs[4], uri_segs[5]
     local seg_sub_path = core.table.concat(uri_segs, "/", 6)
     if seg_res == "schema" and seg_id == "plugins" then
         -- /apisix/admin/schema/plugins/limit-count
         seg_res, seg_id = uri_segs[5], uri_segs[6]
         seg_sub_path = core.table.concat(uri_segs, "/", 7)
+
+    elseif seg_res == "check_conf" then

Review Comment:
   I think some comments are needed here to indicate what the check conf interface uri of the Admin API is.
   
   like `-- /apisix/admin/schema/route`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org