You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/02 06:51:31 UTC
[GitHub] [maven-shared-utils] gnodet opened a new pull request #67: [MNG-6380] Update the wrapped jansi streams
gnodet opened a new pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Update the wrapped jansi streams
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-764529402
Rebased on top of #69
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Update the wrapped jansi streams
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-737546957
I've pushed commits to leverage today's changes to Jansi.
@slachiewicz I'm not sure to understand your question, could you rephrase please ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] elharo commented on a change in pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#discussion_r575802972
##########
File path: pom.xml
##########
@@ -70,7 +70,7 @@
<dependency>
<groupId>org.fusesource.jansi</groupId>
<artifactId>jansi</artifactId>
- <version>2.0.1</version>
+ <version>2.2.0</version>
Review comment:
should this be 2.3.1 now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on a change in pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#discussion_r575872367
##########
File path: pom.xml
##########
@@ -70,7 +70,7 @@
<dependency>
<groupId>org.fusesource.jansi</groupId>
<artifactId>jansi</artifactId>
- <version>2.0.1</version>
+ <version>2.2.0</version>
Review comment:
We could, but the 2.3.0/2.3.1 only brings two additional native methods specifically for `mvnd` and no other changes, so there is no real benefit either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] elharo commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-821558142
jenkins passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Update the wrapped jansi streams
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-764529402
Rebased on top of #69
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-821345445
@MartinKanters jansi is a dependency both maven-shared and core maven, so it needs to be upgraded in both. In addition, MNG-6380 is resolved with the commits in this PR and not simply the upgrade of jansi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Update the wrapped jansi streams
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-737055511
I need to release jansi before merging this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] elharo commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-821548787
checking jenkins: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-shared-utils/job/MNG-6380/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] elharo merged pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] elharo commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-778772270
Running through jenkins on branch gnodet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] michael-o commented on pull request #67: [MNG-6380] Update the wrapped jansi streams
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-737179842
I will have a look at this combined with other Maven issues in a few days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-765203066
> I saw that something have changed in relation to unpacking libs. What native lib version will be used if we unpack (for maven core) lib to dedicated directory and set env variables also?
The native libraries location have changed a bit with Jansi 2.x, so we need to properly change the maven distribution, see https://github.com/apache/maven/pull/433/commits/151e3494fec519197fb55df97e79f60bb2ef1d24
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] MartinKanters commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-821143715
@gnodet I see that jansi was already upgraded in https://github.com/apache/maven-shared-utils/pull/69. Is this work still needed? Is it required or nice to have for the Maven Core 4.0.0 (alpha) release eventually?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-shared-utils] gnodet commented on pull request #67: [MNG-6380] Option -Dstyle.color=always doesn't force color output
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #67:
URL: https://github.com/apache/maven-shared-utils/pull/67#issuecomment-821403210
Rebased and squashed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org