You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 18:33:48 UTC
[GitHub] [airflow] olchas opened a new pull request #10521: Fix impersonation related bug in bigtable tests
olchas opened a new pull request #10521:
URL: https://github.com/apache/airflow/pull/10521
This PR fixes bugs in two BigTable tests introduced in https://github.com/apache/airflow/pull/10052 related to not including `impersonation_chain` in the list of arguments `BigTableHook` is called with.
---
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Target Github ISSUE in description if exists
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] olchas commented on pull request #10521: Fix impersonation related bug in bigtable tests
Posted by GitBox <gi...@apache.org>.
olchas commented on pull request #10521:
URL: https://github.com/apache/airflow/pull/10521#issuecomment-679296362
@potiuk I believe this might be the reason for broken master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #10521: Fix impersonation related bug in bigtable tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10521:
URL: https://github.com/apache/airflow/pull/10521#issuecomment-679309820
> @potiuk I believe this might be the reason for broken master.
Cool! Thanks! So this is one of those cases where two related changed crossed . I will cancel my revert then :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #10521: Fix impersonation related bug in bigtable tests
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #10521:
URL: https://github.com/apache/airflow/pull/10521
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org