You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/02/23 06:45:34 UTC
[GitHub] [netbeans] JaroslavTulach opened a new pull request #2777: Let AutoUpdate task recognize m2:/ URL scheme
JaroslavTulach opened a new pull request #2777:
URL: https://github.com/apache/netbeans/pull/2777
Let `AutoUpdate` task recognize m2:/ URL scheme, so VSCode build can install additional nbjavac modules from Maven.
The [BUILD.md](https://github.com/apache/netbeans/blob/234392d4fc125d4e20a116598821b2cfd378dfc6/java/java.lsp.server/vscode/BUILD.md) file suggests to use:
```bash
java/java.lsp.server$ ant build-lsp-server -D3rdparty.modules=.*nbjavac.*
```
to build the LSP server with additionally installed `nbjavac` modules. The download no longer works since #2759 - the `AutoUpdate` task hasn't be updated to understand the `m2:/` protocol. This PR:
* calls from `AutoUpdate` task to `DownloadBinaries` to handle the `m2:/` protocol
* modifies the travis check to use the `-D3rdparty.modules` property, so we have some test coverage
* the [release job](https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/) **is not** modified, ASF doesn't want to distribute nbjavac right now
* the `m2:/` URL definitions had to be adjusted to [gradle scheme](https://github.com/apache/netbeans/blob/234392d4fc125d4e20a116598821b2cfd378dfc6/nbbuild/antsrc/org/netbeans/nbbuild/extlibs/DownloadBinaries.java#L424)
If this PR is accepted, then #2773 shall be adjusted accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach merged pull request #2777: Let AutoUpdate task recognize m2:/ URL scheme
Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #2777:
URL: https://github.com/apache/netbeans/pull/2777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #2777: Let AutoUpdate task recognize m2:/ URL scheme
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2777:
URL: https://github.com/apache/netbeans/pull/2777#issuecomment-784026834
Manual testing after clean build seems to indicate it is possible to install `nbjavac` when running with
```
JAVA_HOME=/jdk-8/ ant tryme
```
Installing `nbjavac` via `AutoUpdate` task as part of [VSCode gate](https://travis-ci.com/github/apache/netbeans/jobs/485440308) seems to work as well:
```
[autoupdate] Downloading file:/home/travis/build/apache/netbeans/nb/updatecenters/build/classes/org/netbeans/modules/updatecenters/resources/3rdparty-catalog.xml
[autoupdate] Trying external Maven URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.2:api
Trying: https://repo1.maven.org/maven2/com/dukescript/nbjavac/nb-javac/15.0.0.2/nb-javac-15.0.0.2-api.jar
Downloading: https://repo1.maven.org/maven2/com/dukescript/nbjavac/nb-javac/15.0.0.2/nb-javac-15.0.0.2-api.jar
[autoupdate] Trying external Maven URL: m2:/com.dukescript.nbjavac:nb-javac:15.0.0.2
Trying: https://repo1.maven.org/maven2/com/dukescript/nbjavac/nb-javac/15.0.0.2/nb-javac-15.0.0.2.jar
Downloading: https://repo1.maven.org/maven2/com/dukescript/nbjavac/nb-javac/15.0.0.2/nb-javac-15.0.0.2.jar
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists