You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by alpinegizmo <gi...@git.apache.org> on 2016/12/15 14:47:59 UTC
[GitHub] flink pull request #3013: [FLINK-5344] relax spec for requested ruby version...
GitHub user alpinegizmo opened a pull request:
https://github.com/apache/flink/pull/3013
[FLINK-5344] relax spec for requested ruby version so the docs can be\u2026
With this update, the docs can be built with any version of ruby from 2.0 onward -- I've tested with ruby 2.0 in our dockerized jekyll, and with ruby 2.3 on ubuntu 16.04. Otherwise the run.sh script in docs/docker ran into problems.
The json gem needed to be explicitly pulled in because in early versions of ruby 2.0 it wasn't yet in the ruby stdlib.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alpinegizmo/flink 5344-update-gemfile-for-dockerized-jekyll
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3013.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3013
----
commit 2ff29149b713354acc338a923aa004ba9a55108b
Author: David Anderson <da...@alpinegizmo.com>
Date: 2016-12-15T14:42:45Z
[FLINK-5344] relax spec for requested ruby version so the docs can be built in a wider variety of systems, including our dockerized jekyll environment
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3013: [FLINK-5344] relax spec for requested ruby version so the...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/3013
I've concluded this was the wrong approach. I'll open another pull request to deal with these issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3013: [FLINK-5344] relax spec for requested ruby version so the...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/3013
Max, this latest commit allows one to take advantage of ruby 2.0 if it is available, but is backwards compatible to 1.9. Hopefully this will satisfy everyone. The only issue I can see is that if one runs the build_docs script with ruby 2.x then Gemfile.lock will be updated with newer versions which probably should not be checked in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3013: [FLINK-5344] relax spec for requested ruby version...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3013#discussion_r92654203
--- Diff: docs/Gemfile ---
@@ -17,13 +17,14 @@
################################################################################
source 'https://rubygems.org'
-ruby '~> 2.3.0'
+ruby '~> 2'
--- End diff --
When we upgraded this from `~> 1.9`, the nightly Buildbot stopped working: https://ci.apache.org/builders/flink-docs-master/builds/557/steps/Flink%20docs/logs/stdio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3013: [FLINK-5344] relax spec for requested ruby version...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on a diff in the pull request:
https://github.com/apache/flink/pull/3013#discussion_r92689908
--- Diff: docs/build_docs.sh ---
@@ -46,8 +46,8 @@ DOCS_DST=${DOCS_SRC}/content
JEKYLL_CMD="build"
# if -p flag is provided, serve site on localhost
-# -i is like -p, but incremental (which has some issues, but is very fast)
-while getopts ":p:i" opt; do
+# -i is like -p, but incremental (only rebuilds the modified file)
+while getopts "pi" opt; do
--- End diff --
Yes, this fixes the -p argument.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3013: [FLINK-5344] relax spec for requested ruby version...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/3013#discussion_r92653981
--- Diff: docs/build_docs.sh ---
@@ -46,8 +46,8 @@ DOCS_DST=${DOCS_SRC}/content
JEKYLL_CMD="build"
# if -p flag is provided, serve site on localhost
-# -i is like -p, but incremental (which has some issues, but is very fast)
-while getopts ":p:i" opt; do
+# -i is like -p, but incremental (only rebuilds the modified file)
+while getopts "pi" opt; do
--- End diff --
Does this fix the `-p` argument? In the master, only the `-i` argument is working.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3013: [FLINK-5344] relax spec for requested ruby version...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo closed the pull request at:
https://github.com/apache/flink/pull/3013
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---