You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/04/28 04:35:51 UTC
[GitHub] [superset] justinpark opened a new pull request, #23860: fix(alerts): flaky test error
justinpark opened a new pull request, #23860:
URL: https://github.com/apache/superset/pull/23860
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This commit fixes the following flaky test error.
```
✕ renders the appropriate dropdown in Message Content section (1160 ms)
● renders the appropriate dropdown in Message Content section
expect(element).toBeChecked()
Received element is not checked:
<input class="ant-radio-input" type="radio" value="chart" />
63 | userEvent.click(chartRadio);
64 |
> 65 | expect(await screen.findByRole('radio', { name: /chart/i })).toBeChecked();
```
This commit also cleaned up warnings related to the react-ace editor by using jest.mock.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
<img width="489" alt="Screenshot 2023-04-27 at 9 35 27 PM" src="https://user-images.githubusercontent.com/1392866/235055147-3ad91659-8655-4038-8e39-e23749152bbb.png">
Before:
<img width="493" alt="Screenshot 2023-04-27 at 9 33 39 PM" src="https://user-images.githubusercontent.com/1392866/235055041-1d75a2f7-7f08-4bc4-b31b-050102338674.png">
### TESTING INSTRUCTIONS
> npm run test
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark merged pull request #23860: fix(alerts): flaky test error
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #23860:
URL: https://github.com/apache/superset/pull/23860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23860: fix(alerts): flaky test error
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23860:
URL: https://github.com/apache/superset/pull/23860#issuecomment-1527054208
## [Codecov](https://codecov.io/gh/apache/superset/pull/23860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23860](https://codecov.io/gh/apache/superset/pull/23860?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1a212cd) into [master](https://codecov.io/gh/apache/superset/commit/053dca10bd459d23a2bec3383082c3c9572db65e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (053dca1) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 1a212cd differs from pull request most recent head 94fcef3. Consider uploading reports for the commit 94fcef3 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23860 +/- ##
=======================================
Coverage 68.11% 68.11%
=======================================
Files 1938 1938
Lines 74958 74958
Branches 8141 8141
=======================================
Hits 51055 51055
Misses 21824 21824
Partials 2079 2079
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.46% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org