[GitHub] [calcite-avatica-go] trusch commented on issue #43: [CALCITE-3248] add Connector implementation

[GitBox <gi...@apache.org>]

trusch commented on issue #43: [CALCITE-3248] add Connector implementation
URL: https://github.com/apache/calcite-avatica-go/pull/43#issuecomment-521117298
 
 
   With regards to the documentation change: Should I just remove the docs, or also the parsing in the dsn? For maximum backwards compability I could also check if these values are set and copy them into the `Info` map. That way we would preserve the ability to pass down username and password to the backing DB using the old dsn-only approach and wouldn't break any existing code relying on that behavior. What do you think? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services