You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2003/08/02 00:16:21 UTC
Committing other people's filed patches
I looked in the issue tracker today, found a trivial documentation patch that had been filed in March, reviewed it, committed, and marked the issue as "resolved: fixed" (issue 1217, r6634). Is it OK for me to do that? I don't want to abuse my commit rights. Of course I will only do this when I am confident that a patch is correct and wanted.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] /tools/examples/*.py
Posted by kf...@collab.net.
Tomek Meka <tm...@gmx.net> writes:
> I have updated a few example scripts. Now:
> - they call repos.svn_repos_open instead of fs.new,
> - use everywhere core.run_app
> - use repos transaction functions, instead of fs ones,
> - they run :-)
>
> Is the patch format ok?
Yup! The log message is pretty terse, but I think it's appropriate
for this sort of change.
Applied in revision 6643. Thanks!
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
[PATCH] /tools/examples/*.py
Posted by Tomek Meka <tm...@gmx.net>.
Hi!
I have updated a few example scripts. Now:
- they call repos.svn_repos_open instead of fs.new,
- use everywhere core.run_app
- use repos transaction functions, instead of fs ones,
- they run :-)
Is the patch format ok?
Greetings,
Tomek
Re: Committing other people's filed patches
Posted by Julian Foad <ju...@btopenworld.com>.
kfogel@collab.net wrote:
>
> I guess I should add: you are running 'make check' first, right? Or
> to be more complete:
>
> 'make check'
> 'make svncheck'
> 'make davcheck'
I certainly run "make check". Recently I have set up and tried "make svncheck", but I'm not running it regularly. I'll add it to my build-and-test script, so that I will run it in future. I have not set up Apache so I am not running "make davcheck", but I will try to do that soon.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Committing other people's filed patches
Posted by kf...@collab.net.
kfogel@collab.net writes:
> Seriously: you have as much "right" to commit as any committer. And
> you are as responsible for what you commit as any committer. So when
> you're unsure of a specific change, you should ask first, and when
> you're pretty confident, you can go ahead and commit it -- this is how
> everyone else operates too. And if there's ever a vote among the full
> committers (rare, but who knows), then your vote counts the same as
> anyone else's.
I guess I should add: you are running 'make check' first, right? Or
to be more complete:
'make check'
'make svncheck'
'make davcheck'
Basically, if a commit breaks the build or the test suite, that's more
embarrassing than if it introduces a subtle bug that no one expected
:-). So for code changes, there are at least these sanity checks to
give you some confidence.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: Committing other people's filed patches
Posted by kf...@collab.net.
Julian Foad <ju...@btopenworld.com> writes:
> I looked in the issue tracker today, found a trivial documentation
> patch that had been filed in March, reviewed it, committed, and
> marked the issue as "resolved: fixed" (issue 1217, r6634). Is it OK
> for me to do that? I don't want to abuse my commit rights. Of
> course I will only do this when I am confident that a patch is
> correct and wanted.
Don't be timid :-).
Seriously: you have as much "right" to commit as any committer. And
you are as responsible for what you commit as any committer. So when
you're unsure of a specific change, you should ask first, and when
you're pretty confident, you can go ahead and commit it -- this is how
everyone else operates too. And if there's ever a vote among the full
committers (rare, but who knows), then your vote counts the same as
anyone else's.
You might inadvertently commit something problematic (most of us have
done it once or twice). If that happens, we just revert it and
discuss, no big deal.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org