You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by ejwhite922 <gi...@git.apache.org> on 2017/08/02 13:56:53 UTC
[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen
GitHub user ejwhite922 opened a pull request:
https://github.com/apache/incubator-rya/pull/191
RYA-306 Remove rya.benchmark committed gen
## Description
Deleted the committed generated source code in rya.benchmark from git. It is now generated and ignored by git so when building changes to those files they don't show up as changed files in git.
Also, other projects that use generated source now append the license header to the generated files. The license header is placed in the top level Rya project under "resources" so all projects can access it and has a property in the rya parent pom called "license.header.file".
### Tests
Build
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-306)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
#### People To Review
@meiercaleb
@amihalik
@jdasch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ejwhite922/incubator-rya RYA-306_RemoveBenchmarkGen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #191
----
commit 9c1b7946a361636a3d616898c8d261dfafa04de4
Author: eric.white <er...@parsons.com>
Date: 2017-08-01T15:32:06Z
RYA-306 Removed rya.benchmark gen source files from git. Made all generated files appear automatically in their corresponding Eclipse project .classpath file when updating through Maven.
commit a994f25bbafa00b00628d8ee595f88ac22ba819e
Author: eric.white <er...@parsons.com>
Date: 2017-08-01T21:04:47Z
RYA-306 Commit #2. Added license header to generated source files in other projects.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/191#discussion_r130889403
--- Diff: extras/rya.benchmark/pom.xml ---
@@ -106,11 +106,29 @@
</executions>
<configuration>
<!-- Place the generated source within the 'src' directory so license-maven-plugin will find it. -->
- <outputDirectory>src/main/gen</outputDirectory>
+ <outputDirectory>src/gen/java</outputDirectory>
<packageName>org.apache.rya.benchmark.query</packageName>
</configuration>
</plugin>
+ <plugin>
--- End diff --
Plugin execution is unnecessary if code is stored in ${project.build.directory}/generated-sources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/357/<h2>Build result: FAILURE</span></h2>[...truncated 5.53 MB...][INFO] Apache Rya Spark Support ........................... SKIPPED[INFO] Apache Rya Web Projects ............................ SKIPPED[INFO] Apache Rya Web Implementation ...................... SKIPPED[INFO] ------------------------------------------------------------------------[INFO] BUILD FAILURE[INFO] ------------------------------------------------------------------------[INFO] Total time: 24:17 min[INFO] Finished at: 2017-08-04T19:23:25+00:00[INFO] Final Memory: 419M/3343M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal com.mycila:license-maven-plugin:2.6:format (default) on project rya.export.api: Resource ${rya.project.basedir}/resources/LICENSE_HEADER.txt not found in file system, classpath or URL: no protocol: ${rya.project.basedir}/resources/LICENSE_HEADER.txt -> [H
elp 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException[ERROR] [ERROR] After correcting the problems, you can resume the build with the command[ERROR] mvn <goals> -rf :rya.export.apichannel stoppedSetting status of 69dc245a1fd7b6be21d2309458bf1c7042019dde to FAILURE with url https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/357/ and message: 'FAILURE 'Using context: Jenkins: clean package -Pgeoindexing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rya/pull/191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Sorry for so many comments. The main concern I have with this is that if generated source is not stored in the `${project.build.directory}` (aka target), you really can't do a true `mvn clean` without extra build configuration. So following the maven convention gives you a lot for free and makes your poms small.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/191#discussion_r130889483
--- Diff: extras/rya.export/export.accumulo/pom.xml ---
@@ -102,6 +102,24 @@ under the License.
<outputDirectory>src/gen/java</outputDirectory>
</configuration>
</plugin>
+
--- End diff --
Plugin execution is unnecessary if code is stored in ${project.build.directory}/generated-sources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Looks good. I just made a pull request to your branch with my last couple nits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/332/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by ejwhite922 <gi...@git.apache.org>.
Github user ejwhite922 commented on the issue:
https://github.com/apache/incubator-rya/pull/191
I made all changes requested. Let me know if anything else is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/362/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/364/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/191
I feel bad taking up your time with this Eric. I've got a [branch](https://github.com/jdasch/incubator-rya/tree/RYA-306) from a while ago that is probably good enough. Do you want me to update it and send it out as a PR, or let you mod this PR? Happy to do either.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/191#discussion_r130889095
--- Diff: extras/rya.benchmark/pom.xml ---
@@ -106,11 +106,29 @@
</executions>
<configuration>
<!-- Place the generated source within the 'src' directory so license-maven-plugin will find it. -->
- <outputDirectory>src/main/gen</outputDirectory>
+ <outputDirectory>src/gen/java</outputDirectory>
--- End diff --
Line 109 is unnecessary. Remove so code is stored in ${project.build.directory}/generated-sources per maven conversion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/359/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/363/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya pull request #191: RYA-306 Remove rya.benchmark committed gen
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on a diff in the pull request:
https://github.com/apache/incubator-rya/pull/191#discussion_r130889523
--- Diff: extras/rya.export/export.api/pom.xml ---
@@ -98,6 +98,24 @@ under the License.
</configuration>
</plugin>
+ <plugin>
--- End diff --
Plugin execution is unnecessary if code is stored in ${project.build.directory}/generated-sources.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rya issue #191: RYA-306 Remove rya.benchmark committed gen
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/191
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/366/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---