[GitHub] graceguo-supercat closed pull request #5012: Fix AdhocFilterControl for single metric options

[GitBox <gi...@apache.org>]

graceguo-supercat closed pull request #5012: Fix AdhocFilterControl for single metric options
URL: https://github.com/apache/incubator-superset/pull/5012
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/explore/components/controls/AdhocFilterControl.jsx b/superset/assets/src/explore/components/controls/AdhocFilterControl.jsx
index abd8778f40..3a12c2a7b3 100644
--- a/superset/assets/src/explore/components/controls/AdhocFilterControl.jsx
+++ b/superset/assets/src/explore/components/controls/AdhocFilterControl.jsx
@@ -206,7 +206,7 @@ export default class AdhocFilterControl extends React.Component {
   optionsForSelect(props) {
     const options = [
       ...props.columns,
-      ...[...props.formData.metrics, props.formData.metric].map(metric => (
+      ...[...(props.formData.metrics || []), props.formData.metric].map(metric => (
         metric && (
           typeof metric === 'string' ?
           { saved_metric_name: metric } :


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org