You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/01 16:43:12 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11456: [BEAM-7554] Add MillisInstant logical type to replace DATETIME

TheNeuralBit commented on a change in pull request #11456:
URL: https://github.com/apache/beam/pull/11456#discussion_r418625619



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/Schema.java
##########
@@ -419,7 +420,6 @@ public int hashCode() {
     FLOAT,
     DOUBLE,
     STRING, // String.
-    DATETIME, // Date and time.

Review comment:
       Yeah we could deprecate it for a release or two before removing. Would we also need to keep support for the primitive DATETIME in IOs and SQL? I'd need to think about how that transition would work.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org