[jira] [Commented] (PDFBOX-3017) Improve document signing

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-3017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318727#comment-15318727 ] 

ASF subversion and git services commented on PDFBOX-3017:
---------------------------------------------------------

Commit 1747261 from [~tilman] in branch 'pdfbox/trunk'
[ https://svn.apache.org/r1747261 ]

PDFBOX-3017: enable verify

> Improve document signing
> ------------------------
>
>                 Key: PDFBOX-3017
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-3017
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: Signing
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Tilman Hausherr
>         Attachments: pdfa_signed_insivible.pdf
>
>
> Improve signing code:
> - incremental save only works for signatures and doesn't respect certificates such as Adobe Extended Usage Rights
> - -{{prepareNonVisualSignature}} clears the AcroForm DR {{acroForm.setDefaultResources(null)}} which is not good if there are other form fields-
> - visual/nonVisualSignature should move into the {{interactive.forms}} package and be handled within the signature field
> - verify signature (to have tests that go full circle)
> - document or refactor / rewrite visible labyrinthine signature code
> - why is it not possible to pass only the signatureField to addSignature, instead having to create a COSDocument with a page and annotations that has the signature field, and that must be searched for in {{prepareVisibleSignature()}}?
> - support rotated pages (see https://stackoverflow.com/questions/34012293/pdfbox-sign-landscape-file-error/34359956#34359956 )
> - make sure that signed PDF/A files are still PDF/A (see http://www.pdfa.org/wp-content/uploads/2011/08/tn0006_digital_signatures_in_pdfa-1_2008-03-14.pdf ); /ID possibly not OK; /Annots is possibly required ([~tilman] removed this for invisible signatures); test signed files with PDF-Tools and with preflight; test whether "bad" signatures are detected by preflight
> - PDFBOX-3363 - why is the stream cached in a file? Should it be done in memory?
> - remove {{setVisualSignature(PDVisibleSigProperties visSignatureProperties)}} from SignatureOptions.java, all it does is to call {{visSignatureProperties.getVisibleSignature()}} which returns an {{InputStream}}, and this is already available
> - {{checkSignatureField}} violates the "do one thing" rule
> - ... your ideas...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org