You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "carterkozak (via GitHub)" <gi...@apache.org> on 2023/11/01 18:43:27 UTC
[PR] HTTPCLIENT-2305: SSLConnectionSocketFactory allows socket.connect to be decorated [httpcomponents-client]
carterkozak opened a new pull request, #499:
URL: https://github.com/apache/httpcomponents-client/pull/499
https://issues.apache.org/jira/browse/HTTPCLIENT-2305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCLIENT-2305: SSLConnectionSocketFactory allows socket.connect to be decorated [httpcomponents-client]
Posted by "carterkozak (via GitHub)" <gi...@apache.org>.
carterkozak commented on PR #499:
URL: https://github.com/apache/httpcomponents-client/pull/499#issuecomment-1790827273
Thanks for the review, @ok2c!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCLIENT-2305: SSLConnectionSocketFactory allows socket.connect to be decorated [httpcomponents-client]
Posted by "carterkozak (via GitHub)" <gi...@apache.org>.
carterkozak commented on code in PR #499:
URL: https://github.com/apache/httpcomponents-client/pull/499#discussion_r1379179948
##########
httpclient5/src/main/java/org/apache/hc/client5/http/ssl/SSLConnectionSocketFactory.java:
##########
@@ -239,19 +240,7 @@ public Socket connectSocket(
if (LOG.isDebugEnabled()) {
LOG.debug("Connecting socket to {} with timeout {}", remoteAddress, connectTimeout);
}
Review Comment:
This debug logging will make more sense in the new method, update incoming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: [PR] HTTPCLIENT-2305: SSLConnectionSocketFactory allows socket.connect to be decorated [httpcomponents-client]
Posted by "carterkozak (via GitHub)" <gi...@apache.org>.
carterkozak merged PR #499:
URL: https://github.com/apache/httpcomponents-client/pull/499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org