You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Benjamin Muschko (JIRA)" <ji...@apache.org> on 2018/01/08 19:36:01 UTC

[jira] [Commented] (HTTPCLIENT-1888) NullPointerException in SystemDefaultCredentialsProvider.getCredentials when AuthScope.orgin is null

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316863#comment-16316863 ] 

Benjamin Muschko commented on HTTPCLIENT-1888:
----------------------------------------------

Did you already set a release date for version 4.5.5? I'd love to use the fix for this issue in [Gradle|https://github.com/gradle/gradle].

> NullPointerException in SystemDefaultCredentialsProvider.getCredentials when AuthScope.orgin is null
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1888
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1888
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5.4
>            Reporter: Collin Peters
>            Priority: Critical
>             Fix For: 4.5.5, 4.6 Alpha1
>
>
> 4.5.4 has the following line in [SystemDefaultCredentialsProvider|https://github.com/apache/httpcomponents-client/blob/4.5.4/httpclient/src/main/java/org/apache/http/impl/client/SystemDefaultCredentialsProvider.java#L114]
>  {code}
>  final String protocol = origin != null ? origin.getSchemeName() : (origin.getPort() == 443 ? "https" : "http");
> {code}
> So 'origin' is still accessed when it is determined that it is null.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org