[jira] [Commented] (KAFKA-5950) AdminClient should retry based on returned error codes

["Andrey Dyachkov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206539#comment-16206539 ] 

Andrey Dyachkov commented on KAFKA-5950:
----------------------------------------

[~ijuma] I have finished KAFKA-5445. I have a question about, retries:
AbstractResponse implementations usually have `error(s)` method, then I can get exception and check if it is implementation of RetriableException. It is not clear why I have to check the error code to understand that I have to retry. could you clarify it, please?

> AdminClient should retry based on returned error codes
> ------------------------------------------------------
>
>                 Key: KAFKA-5950
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5950
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ismael Juma
>            Assignee: Andrey Dyachkov
>              Labels: needs-kip
>             Fix For: 1.1.0
>
>
> The AdminClient only retries if the request fails with a retriable error. If a response is returned, then a retry is never attempted. This is inconsistent with other clients that check the error codes in the response and retry for each retriable error code.
> We should consider if it makes sense to adopt this behaviour in the AdminClient so that users don't have to do it themselves.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)