You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/05 10:25:51 UTC
[GitHub] [skywalking] kezhenxu94 opened a new issue #5443: E2E bug when running locally with multiple `docker-compose.yml` files
kezhenxu94 opened a new issue #5443:
URL: https://github.com/apache/skywalking/issues/5443
https://github.com/apache/skywalking/blob/35264e6171b7a5c675d4fdf42645dae4caa5a31c/test/e2e/e2e-common/src/main/java/org/apache/skywalking/e2e/SkyWalkingAnnotations.java#L206-L220
@codeglzhang you cannot run `docker-compose -f xxx.yml config` when the `xxx.yml` is part of the complete yaml configs, an example is
https://github.com/apache/skywalking/blob/190ca93b6bf48e9d966de5b05cd6490ba54b7266/test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/profile/ProfileE2E.java#L76-L79
where two or more yaml files compose the entire correct docker-compose configurations, therefore, should be something like (just FYI)
```diff
- public static DockerComposeFile getAllConfigInfo(String composeFile) throws IOException, InterruptedException {
- String shStr = String.format("docker-compose -f %s config", composeFile);
+ public static DockerComposeFile getAllConfigInfo(String... composeFiles) throws IOException, InterruptedException {
+ String shStr = String.format("docker-compose %s config", Stream.of(composeFiles).collect(joining(" ", "-f", "")));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codeglzhang commented on issue #5443: E2E bug when running locally with multiple `docker-compose.yml` files
Posted by GitBox <gi...@apache.org>.
codeglzhang commented on issue #5443:
URL: https://github.com/apache/skywalking/issues/5443#issuecomment-687709195
Thx, I have got it. Using the command `docker-compose -f xxx.yml -f xxx.yml ... config` to get complete config information directly is better than parsing each yml file individually. I will fix it as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #5443: E2E bug when running locally with multiple `docker-compose.yml` files
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #5443:
URL: https://github.com/apache/skywalking/issues/5443#issuecomment-687586202
@codeglzhang just feel free to finish your examinations first and then coma back to this when you're available
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5443: E2E bug when running locally with multiple `docker-compose.yml` files
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5443:
URL: https://github.com/apache/skywalking/issues/5443
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org