[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #621: [#378] feat: introduce storage manager selector

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on code in PR #621:
URL: https://github.com/apache/incubator-uniffle/pull/621#discussion_r1109581410


##########
server/src/test/java/org/apache/uniffle/server/storage/MultiStorageManagerTest.java:
##########
@@ -56,6 +57,44 @@ public void selectStorageManagerTest() {
     assertTrue((manager.selectStorage(event) instanceof HdfsStorage));
   }
 
+  @Test
+  public void testStorageManagerSelectorOfPreferCold() {
+    ShuffleServerConf conf = new ShuffleServerConf();
+    conf.setLong(ShuffleServerConf.FLUSH_COLD_STORAGE_THRESHOLD_SIZE, 10000L);
+    conf.set(ShuffleServerConf.RSS_STORAGE_BASE_PATH, Arrays.asList("test"));
+    conf.setLong(ShuffleServerConf.DISK_CAPACITY, 10000L);
+    conf.setString(ShuffleServerConf.RSS_STORAGE_TYPE, StorageType.MEMORY_LOCALFILE_HDFS.name());
+    conf.setString(ShuffleServerConf.MULTISTORAGE_FALLBACK_STRATEGY_CLASS,
+        RotateStorageManagerFallbackStrategy.class.getCanonicalName());
+    conf.set(
+        ShuffleServerConf.MULTISTORAGE_SELECTOR_COLD_STORAGE_PREFER,
+        StorageManagerSelector.ColdStoragePreferredFactor.HUGE_PARTITION

Review Comment:
   Emm. My fault. The default value should be `GREATER_THAN_SIZE`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org