You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2016/03/16 21:11:55 UTC
[5/5] wicket git commit: Minor improvements
Minor improvements
- remove 'public' qualifiers for methods in private inner classes
- fix javadocs
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c1a7ef05
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c1a7ef05
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c1a7ef05
Branch: refs/heads/master
Commit: c1a7ef0502f09dcfc6f5aa42cd6f4b4dcdb04d38
Parents: 67d86e5
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Wed Mar 16 21:10:48 2016 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Wed Mar 16 21:10:48 2016 +0100
----------------------------------------------------------------------
.../wicket/examples/repeater/ContactDataProvider.java | 2 +-
.../extensions/markup/html/repeater/tree/TableTree.java | 2 +-
.../html/repeater/tree/table/TreeDataProvider.java | 12 ++++++------
3 files changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/c1a7ef05/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactDataProvider.java
----------------------------------------------------------------------
diff --git a/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactDataProvider.java b/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactDataProvider.java
index 70d88c8..9a95307 100644
--- a/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactDataProvider.java
+++ b/wicket-examples/src/main/java/org/apache/wicket/examples/repeater/ContactDataProvider.java
@@ -40,7 +40,7 @@ public class ContactDataProvider implements IDataProvider<Contact>
* retrieves contacts from database starting with index <code>first</code> and ending with
* <code>first+count</code>
*
- * @see org.apache.wicket.markup.repeater.data.IDataProvider#iterator(int, int)
+ * @see org.apache.wicket.markup.repeater.data.IDataProvider#iterator(long, long)
*/
@Override
public Iterator<Contact> iterator(long first, long count)
http://git-wip-us.apache.org/repos/asf/wicket/blob/c1a7ef05/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/TableTree.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/TableTree.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/TableTree.java
index df61813..0ae190f 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/TableTree.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/TableTree.java
@@ -109,7 +109,7 @@ public abstract class TableTree<T, S> extends AbstractTree<T>
* Factory method for the wrapped {@link DataTable}.
*
* Note: If overwritten, the DataTable's row items have to output their markupId, or
- * {@link #updateNode(Object, IPartialPageRequestHandler)} will fail.
+ * {@link #updateNode(Object, Optional)} will fail.
*
* @param id
* @param columns
http://git-wip-us.apache.org/repos/asf/wicket/blob/c1a7ef05/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/TreeDataProvider.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/TreeDataProvider.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/TreeDataProvider.java
index d803918..549d230 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/TreeDataProvider.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/repeater/tree/table/TreeDataProvider.java
@@ -47,7 +47,7 @@ public abstract class TreeDataProvider<T> implements ITreeDataProvider<T>
* @param provider
* the provider to adapt
*/
- public TreeDataProvider(ITreeProvider<T> provider)
+ protected TreeDataProvider(ITreeProvider<T> provider)
{
this.provider = provider;
}
@@ -128,7 +128,7 @@ public abstract class TreeDataProvider<T> implements ITreeDataProvider<T>
}
/**
- * Hook method to decide wether the given node's children should be iterated.
+ * Hook method to decide whether the given node's children should be iterated.
*
* @param node
* node
@@ -157,13 +157,13 @@ public abstract class TreeDataProvider<T> implements ITreeDataProvider<T>
private Iterator<? extends T> children;
- public Branch(Branch<T> parent, Iterator<? extends T> children)
+ Branch(Branch<T> parent, Iterator<? extends T> children)
{
this.parent = parent;
this.children = children;
}
- public NodeModel<T> wrapModel(IModel<T> model)
+ NodeModel<T> wrapModel(IModel<T> model)
{
boolean[] branches = new boolean[getDepth()];
@@ -178,7 +178,7 @@ public abstract class TreeDataProvider<T> implements ITreeDataProvider<T>
return new NodeModel<>(model, branches);
}
- public int getDepth()
+ int getDepth()
{
if (parent == null)
{
@@ -213,4 +213,4 @@ public abstract class TreeDataProvider<T> implements ITreeDataProvider<T>
throw new UnsupportedOperationException();
}
}
-}
\ No newline at end of file
+}