You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/19 12:40:28 UTC
[GitHub] [airflow] uranusjr opened a new pull request #15940: Correctly implement autocomplete early return
uranusjr opened a new pull request #15940:
URL: https://github.com/apache/airflow/pull/15940
Found this bug while working on #15525. This is properly tested now.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #15940: Correctly implement autocomplete early return
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #15940:
URL: https://github.com/apache/airflow/pull/15940#discussion_r635199998
##########
File path: airflow/www/views.py
##########
@@ -4162,7 +4162,7 @@ def class_permission_name(self):
"""Returns appropriate permission name depending on request method name."""
if request:
action_name = request.view_args.get("name")
- _, method_name = request.url_rule.endpoint.split(".")
+ _, method_name = request.url_rule.endpoint.rsplit(".", 1)
Review comment:
Oops, this is unrelated and should have been submitted separately. A trivial cleanup though so probably OK to have it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #15940: Correctly implement autocomplete early return
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #15940:
URL: https://github.com/apache/airflow/pull/15940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org