You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2023/01/18 14:49:32 UTC
[GitHub] [skywalking-banyandb-java-client] hanahmily opened a new pull request, #34: Introduce the Float field type
hanahmily opened a new pull request, #34:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/34
Introduce the Float field type and suppress the resource not found error on loading on-disk streams/measures.
Related to https://github.com/apache/skywalking/issues/8940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on pull request #34: Introduce the Float field type
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #34:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/34#issuecomment-1387252756
> Why should we suppress the resource not found error?
A stream or measure might not link to any index rules. Considering a measure without index rules, throwing such an error would mess up the initialization. In the OAP scenario, the installation procedure will be interrupted when loading existing measures from the disk. Then the OAP server will crash down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #34: Introduce the Float field type
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #34:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/34#issuecomment-1387202020
Why should we suppress the resource not found error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng merged pull request #34: Introduce the Float field type
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #34:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #34: Introduce the Float field type
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #34:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/34#issuecomment-1387256717
> > Why should we suppress the resource not found error?
>
>
>
> A stream or measure might not link to any index rules. Considering a measure without index rules, throwing such an error would mess up the initialization. In the OAP scenario, the installation procedure will be interrupted when loading existing measures from the disk. Then the OAP server will crash down.
>
>
>
>
Do you mean due to last time bug? I don't think we intend to have no rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] hanahmily commented on pull request #34: Introduce the Float field type
Posted by GitBox <gi...@apache.org>.
hanahmily commented on PR #34:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/34#issuecomment-1387275004
> I don't think we intend to have no rule.
Service-level metrics don't need any index rules. All searchable tags belong to the entity(SeriesID).
> Do you mean due to last time bug?
It's from an [improvement](https://github.com/apache/skywalking-banyandb-java-client/commit/f79cef58b07b6d9316eba75d7f5f2aa357c5691f) more than a bug. We don't create the indexRuleBinding when there is no indexRule. But the measure initialization procedure is based on the assumption that there is an indexRuleBinding at least. That is why an indexRuleBinding not found error is raised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org