You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "jkbkupczyk (via GitHub)" <gi...@apache.org> on 2025/08/12 17:58:41 UTC
[PR] WIP: Migrate tests to JUnit5 - final [commons-net]
jkbkupczyk opened a new pull request, #359:
URL: https://github.com/apache/commons-net/pull/359
This PR is a follow-up to https://github.com/apache/commons-net/pull/358, it finalizes the migration of tests to JUnit5 within project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate tests to JUnit5 - final [commons-net]
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on PR #359:
URL: https://github.com/apache/commons-net/pull/359#issuecomment-3184740006
> @jkbkupczyk Thank you so much! 👍👌
TY for review! Do you know of any other commons-* projects that might require a JUnit5 migration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate tests to JUnit5 - final [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-net/pull/359#issuecomment-3181208066
Just dropping a note here that the unit test count is the same as master:
```
Tests run: 557, Failures: 0, Errors: 0, Skipped: 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate tests to JUnit5 - final [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-net/pull/359#issuecomment-3181221022
@jkbkupczyk
Thank you so much! 👍👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate tests to JUnit5 - final [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #359:
URL: https://github.com/apache/commons-net/pull/359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Migrate tests to JUnit5 - final [commons-net]
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on PR #359:
URL: https://github.com/apache/commons-net/pull/359#issuecomment-3180913815
> Hello @jkbkupczyk
>
> Thank you for completing this task. Don't forget to drop the vintage JUnit JAR 😉
>
> https://github.com/apache/commons-net/blob/cf048deb5bc1cd2cf0649c2106cc8109ed0c4360/pom.xml#L112-L116
OFC, as soon I finish the work on ListingFunctionalTest. Thanks for pointing that out ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Migrate tests to JUnit5 - final [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-net/pull/359#issuecomment-3180437928
Hello @jkbkupczyk
Thank you for completing this task.
Don't forget to drop the vintage JUnit JAR 😉
https://github.com/apache/commons-net/blob/cf048deb5bc1cd2cf0649c2106cc8109ed0c4360/pom.xml#L112-L116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate tests to JUnit5 - final [commons-net]
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on PR #359:
URL: https://github.com/apache/commons-net/pull/359#issuecomment-3180998037
@garydgregory done, please take a look. All tests are finally running with JUnit5! Now we are waiting for JUnit6 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Migrate tests to JUnit5 - final [commons-net]
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #359:
URL: https://github.com/apache/commons-net/pull/359#issuecomment-3184745192
> > @jkbkupczyk Thank you so much! 👍👌
>
> TY for review! Do you know of any other commons-* projects that might require a JUnit5 migration?
@jkbkupczyk
Commons VFS still has bits stuck on JUnit 3!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org