[jira] [Commented] (OAK-288) QueryTests should use the NodeStore apis

["Alex Parvulescu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451832#comment-13451832 ] 

Alex Parvulescu commented on OAK-288:
-------------------------------------

applied the util patch in r1382707.

I disabled the sql tests for now, as they fail after updating to the NodeStore apis.
                
> QueryTests should use the NodeStore apis
> ----------------------------------------
>
>                 Key: OAK-288
>                 URL: https://issues.apache.org/jira/browse/OAK-288
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Alex Parvulescu
>         Attachments: OAK-288-jsop-util.patch
>
>
> Currently the existing oak query tests come in form of a "script" file [0] that contains 
>  - commit commands which will be executed directly against the mk.
>  - select commands
>  - expected results
> while this was good for fast prototyping we should refactor the tests to use proper unit tests.
> Arguments for refactoring:
>  - overall java style unit tests, reduce the complexity of running this setup
>  - proper reporting unit test failures
>  - executing the commit commands directly against the mk breaks the {{CommitHook}} mechanism because the commits will pass unnoticed
>  - proper separation of concerns - oak core should not directly reference the mk, it should pass through exisiting apis like the {{NodeStore}}
> [0] http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/test/resources/org/apache/jackrabbit/oak/query/sql2.txt?view=markup

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira