You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/03 05:12:21 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request, #2623: [#2604]Dependency management split
CalvinKirs opened a new pull request, #2623:
URL: https://github.com/apache/incubator-seatunnel/pull/2623
#2604 subtask
Split Spark connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2623: [#2604]Dependency management split
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2623:
URL: https://github.com/apache/incubator-seatunnel/pull/2623#issuecomment-1236060111
@Hisoka-X Hi, Thanks. PTAL again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2623: [#2604]Dependency management split
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2623:
URL: https://github.com/apache/incubator-seatunnel/pull/2623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2623: [#2604]Dependency management split
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2623:
URL: https://github.com/apache/incubator-seatunnel/pull/2623#issuecomment-1236060152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2623: [#2604]Dependency management split
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2623:
URL: https://github.com/apache/incubator-seatunnel/pull/2623#discussion_r962105936
##########
pom.xml:
##########
@@ -157,17 +156,12 @@
<maven-pmd-plugin.version>3.8</maven-pmd-plugin.version>
<spoiwo.version>1.8.0</spoiwo.version>
<play-mailer.version>7.0.2</play-mailer.version>
- <phoenix-spark.version>5.0.0-HBase-2.0</phoenix-spark.version>
<zkclient.version>0.3</zkclient.version>
<elasticsearch6.client.version>6.3.1</elasticsearch6.client.version>
<elasticsearch7.client.version>7.5.1</elasticsearch7.client.version>
<flink-shaded-hadoop-2.version>2.7.5-7.0</flink-shaded-hadoop-2.version>
<parquet-avro.version>1.10.0</parquet-avro.version>
- <elasticsearch-spark.version>6.8.3</elasticsearch-spark.version>
<clickhouse-jdbc.version>0.2</clickhouse-jdbc.version>
- <hbase-spark.version>1.0.0</hbase-spark.version>
- <kudu-spark.version>1.7.0</kudu-spark.version>
- <mongo-spark.version>2.2.0</mongo-spark.version>
<spark-redis.version>2.6.0</spark-redis.version>
Review Comment:
please move `spark-redis.version` too
##########
seatunnel-connectors/seatunnel-connectors-spark/seatunnel-connector-spark-hudi/pom.xml:
##########
@@ -28,29 +28,16 @@
<modelVersion>4.0.0</modelVersion>
<artifactId>seatunnel-connector-spark-hudi</artifactId>
+ <properties>
+ <hudi-spark-bundle.version>0.11.1</hudi-spark-bundle.version>
+ </properties>
<dependencies>
- <dependency>
- <groupId>org.apache.seatunnel</groupId>
- <artifactId>seatunnel-api-spark</artifactId>
- <version>${project.version}</version>
- <scope>provided</scope>
- </dependency>
<dependency>
<groupId>org.apache.hudi</groupId>
<artifactId>hudi-spark-bundle_${scala.binary.version}</artifactId>
</dependency>
Review Comment:
Add `hudi-spark-bundle.version`
##########
pom.xml:
##########
@@ -188,7 +182,6 @@
<docker.tag>${project.version}</docker.tag>
<jcommander.version>1.81</jcommander.version>
<junit.version>5.9.0</junit.version>
- <tispark.version>2.4.1</tispark.version>
<druid.version>0.22.1</druid.version>
Review Comment:
`druid.version` and `sshd.version` also should be moved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org