You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by Owen O'Malley <om...@apache.org> on 2016/06/02 18:51:40 UTC
[VOTE] Apache ORC 1.1.0 RC 0
I've rolled Apache ORC 1.1.0 release candidate 0 and I'd like to release
it. It is the first release with the Java reader and writer included.
Please check it out and vote whether we should release it.
Artifacts: http://home.apache.org/~omalley/orc-1.1.0/
Git tag: https://github.com/apache/orc/releases/tag/release-1.1.0rc0
Voting will conclude in 72 hours.
Thanks,
Owen
Re: [VOTE] Apache ORC 1.1.0 RC 0
Posted by Alan Gates <al...@gmail.com>.
I did test with rc1, but I didn’t have the proper java packages installed. Once I resolved that it builds fine with java.
+1.
Alan.
> On Jun 3, 2016, at 21:42, Owen O'Malley <om...@apache.org> wrote:
>
> Hmm, Did you test rc0 or rc1? With rc1, I tried changing the Docker file
> for centos7 to install the java 8 compiler and it worked fine.
>
> diff --git docker/centos7/Dockerfile docker/centos7/Dockerfile
> index 22b3dd0..9ef8883 100644
> --- docker/centos7/Dockerfile
> +++ docker/centos7/Dockerfile
> @@ -29,8 +29,8 @@ RUN yum install -y \
> gcc-c++ \
> gettext-devel \
> git \
> - java-1.7.0-openjdk \
> - java-1.7.0-openjdk-devel \
> + java-1.8.0-openjdk \
> + java-1.8.0-openjdk-devel \
> make \
> maven \
> openssl-devel \
>
> Can you create a Dockerfile where the compilation fails?
>
> Thanks,
> Owen
>
> On Fri, Jun 3, 2016 at 2:17 PM, Alan Gates <al...@gmail.com> wrote:
>
>> One issue I saw was that it won’t build the Java side with JDK 1.8. It
>> builds fine with 1.7. We should probably fix this before releasing.
>>
>> Alan.
>>
>>> On Jun 2, 2016, at 11:51, Owen O'Malley <om...@apache.org> wrote:
>>>
>>> I've rolled Apache ORC 1.1.0 release candidate 0 and I'd like to release
>>> it. It is the first release with the Java reader and writer included.
>>> Please check it out and vote whether we should release it.
>>>
>>> Artifacts: http://home.apache.org/~omalley/orc-1.1.0/
>>> Git tag: https://github.com/apache/orc/releases/tag/release-1.1.0rc0
>>>
>>> Voting will conclude in 72 hours.
>>>
>>> Thanks,
>>> Owen
>>
>>
Re: [VOTE] Apache ORC 1.1.0 RC 0
Posted by Owen O'Malley <om...@apache.org>.
Hmm, Did you test rc0 or rc1? With rc1, I tried changing the Docker file
for centos7 to install the java 8 compiler and it worked fine.
diff --git docker/centos7/Dockerfile docker/centos7/Dockerfile
index 22b3dd0..9ef8883 100644
--- docker/centos7/Dockerfile
+++ docker/centos7/Dockerfile
@@ -29,8 +29,8 @@ RUN yum install -y \
gcc-c++ \
gettext-devel \
git \
- java-1.7.0-openjdk \
- java-1.7.0-openjdk-devel \
+ java-1.8.0-openjdk \
+ java-1.8.0-openjdk-devel \
make \
maven \
openssl-devel \
Can you create a Dockerfile where the compilation fails?
Thanks,
Owen
On Fri, Jun 3, 2016 at 2:17 PM, Alan Gates <al...@gmail.com> wrote:
> One issue I saw was that it won’t build the Java side with JDK 1.8. It
> builds fine with 1.7. We should probably fix this before releasing.
>
> Alan.
>
> > On Jun 2, 2016, at 11:51, Owen O'Malley <om...@apache.org> wrote:
> >
> > I've rolled Apache ORC 1.1.0 release candidate 0 and I'd like to release
> > it. It is the first release with the Java reader and writer included.
> > Please check it out and vote whether we should release it.
> >
> > Artifacts: http://home.apache.org/~omalley/orc-1.1.0/
> > Git tag: https://github.com/apache/orc/releases/tag/release-1.1.0rc0
> >
> > Voting will conclude in 72 hours.
> >
> > Thanks,
> > Owen
>
>
Re: [VOTE] Apache ORC 1.1.0 RC 0
Posted by Alan Gates <al...@gmail.com>.
One issue I saw was that it won’t build the Java side with JDK 1.8. It builds fine with 1.7. We should probably fix this before releasing.
Alan.
> On Jun 2, 2016, at 11:51, Owen O'Malley <om...@apache.org> wrote:
>
> I've rolled Apache ORC 1.1.0 release candidate 0 and I'd like to release
> it. It is the first release with the Java reader and writer included.
> Please check it out and vote whether we should release it.
>
> Artifacts: http://home.apache.org/~omalley/orc-1.1.0/
> Git tag: https://github.com/apache/orc/releases/tag/release-1.1.0rc0
>
> Voting will conclude in 72 hours.
>
> Thanks,
> Owen
Re: [VOTE] Apache ORC 1.1.0 RC 0
Posted by Prasanth J <j....@gmail.com>.
brew install had multiple version of cmake. I removed all version from brew, did an update
and installed cmake 3.5.2. With that build is successful. So build is no longer an issue.
a) appveyor.yml can be removed if not used.
b) After extracting the tar, the directory names orc-orc-1.1.0rc0. We should remove “orc” repetition.
c) gcc/g++ optimization can be updated to -O3 as it provides more useful perf optimizations (vectorize, inlining etc.) on top of -O2 which could be useful for native reader.
Thanks
Prasanth
> On Jun 2, 2016, at 12:54 PM, Prasanth J <j....@gmail.com> wrote:
>
> -1
>
> a) Downloaded the source and when I tried to compile, it failed.
> I am using cmake 3.4.2, LLVM version for gcc/g++ is 7.3.0.
>
> Following errors were observed
> 1) /work/orc-release/orc-orc-1.1.0rc0/build/CMakeFiles/CMakeTmp/CheckIncludeFile.cxx:1:10: fatal error: 'tr1/unordered_map' file not found
> #include <tr1/unordered_map>
>
> 2) /work/orc-release/orc-orc-1.1.0rc0/build/CMakeFiles/CMakeTmp/src.cxx:5:14: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
> return std::move(var);
>
> Is there are minimum required version or recommended version cmake and llvm?
> If so can that be put into README section.
>
> b) In appveyor.yml, I see version as 1.0.x. Not sure if we need that file.
>
> Thanks
> Prasanth
>
>> On Jun 2, 2016, at 11:51 AM, Owen O'Malley <om...@apache.org> wrote:
>>
>> I've rolled Apache ORC 1.1.0 release candidate 0 and I'd like to release
>> it. It is the first release with the Java reader and writer included.
>> Please check it out and vote whether we should release it.
>>
>> Artifacts: http://home.apache.org/~omalley/orc-1.1.0/
>> Git tag: https://github.com/apache/orc/releases/tag/release-1.1.0rc0
>>
>> Voting will conclude in 72 hours.
>>
>> Thanks,
>> Owen
>
Re: [VOTE] Apache ORC 1.1.0 RC 0
Posted by Prasanth J <j....@gmail.com>.
-1
a) Downloaded the source and when I tried to compile, it failed.
I am using cmake 3.4.2, LLVM version for gcc/g++ is 7.3.0.
Following errors were observed
1) /work/orc-release/orc-orc-1.1.0rc0/build/CMakeFiles/CMakeTmp/CheckIncludeFile.cxx:1:10: fatal error: 'tr1/unordered_map' file not found
#include <tr1/unordered_map>
2) /work/orc-release/orc-orc-1.1.0rc0/build/CMakeFiles/CMakeTmp/src.cxx:5:14: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
return std::move(var);
Is there are minimum required version or recommended version cmake and llvm?
If so can that be put into README section.
b) In appveyor.yml, I see version as 1.0.x. Not sure if we need that file.
Thanks
Prasanth
> On Jun 2, 2016, at 11:51 AM, Owen O'Malley <om...@apache.org> wrote:
>
> I've rolled Apache ORC 1.1.0 release candidate 0 and I'd like to release
> it. It is the first release with the Java reader and writer included.
> Please check it out and vote whether we should release it.
>
> Artifacts: http://home.apache.org/~omalley/orc-1.1.0/
> Git tag: https://github.com/apache/orc/releases/tag/release-1.1.0rc0
>
> Voting will conclude in 72 hours.
>
> Thanks,
> Owen