You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/12/09 07:23:12 UTC
[jira] [Commented] (THRIFT-2880) Read the network address from the
listener if available.
[ https://issues.apache.org/jira/browse/THRIFT-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239038#comment-14239038 ]
ASF GitHub Bot commented on THRIFT-2880:
----------------------------------------
GitHub user fumin opened a pull request:
https://github.com/apache/thrift/pull/310
THRIFT-2880 Read the network address from the listener if available.
Often in tests, the listening port of a test server is automatically
selected by passing the zero port in the host, as in "127.0.0.1:0".
An example of such behaviour is in the "httptest" package of the
standard library:
https://github.com/golang/go/blob/master/src/net/http/httptest/server.go#L65
As such, it is necessary to read from the listener itself to retrieve
the actually listening port, as in
https://github.com/golang/go/blob/master/src/net/http/httptest/server.go#L107
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fumin/thrift thrift-2880
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #310
----
commit 7449b691f400774d23a75eb3115921d8dfd1d515
Author: awaw fumin <aw...@gmail.com>
Date: 2014-12-09T06:21:23Z
Read the network address from the listener if available.
Often in tests, the listening port of a test server is automatically
selected by passing the zero port in the host, as in "127.0.0.1:0".
An example of such behaviour is in the "httptest" package of the
standard library:
https://github.com/golang/go/blob/master/src/net/http/httptest/server.go#L65
As such, it is necessary to read from the listener itself to retrieve
the actually listening port, as in
https://github.com/golang/go/blob/master/src/net/http/httptest/server.go#L107
----
> Read the network address from the listener if available.
> --------------------------------------------------------
>
> Key: THRIFT-2880
> URL: https://issues.apache.org/jira/browse/THRIFT-2880
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Affects Versions: 0.9.2
> Environment: Linux Amazon AMI
> Reporter: awaw fumin
> Labels: patch
> Attachments: 0001-Read-the-network-address-from-the-listener-if-availa.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Often in tests, the listening port of a test server is automatically
> selected by passing the zero port in the host, as in "127.0.0.1:0".
> An example of such behaviour is in the "httptest" package of the
> standard library:
>
> https://github.com/golang/go/blob/master/src/net/http/httptest/server.go#L65
>
> As such, it is necessary to read from the listener itself to retrieve
> the actually listening port, as in
>
> https://github.com/golang/go/blob/master/src/net/http/httptest/server.go#L107
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)