You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/07/07 01:47:05 UTC
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3213: ARTEMIS-2797 Fixing redeploy mechanism
clebertsuconic commented on a change in pull request #3213:
URL: https://github.com/apache/activemq-artemis/pull/3213#discussion_r450566421
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
##########
@@ -701,7 +701,7 @@ public QueueBinding updateQueue(QueueConfiguration queueConfiguration, boolean f
final SimpleString empty = new SimpleString("");
Filter oldFilter = FilterImpl.createFilter(queue.getFilter() == null ? empty : queue.getFilter().getFilterString());
Filter newFilter = FilterImpl.createFilter(queueConfiguration.getFilterString() == null ? empty : queueConfiguration.getFilterString());
- if ((forceUpdate || newFilter != null) && !Objects.equals(oldFilter, newFilter)) {
+ if ((forceUpdate || newFilter != oldFilter) && !Objects.equals(oldFilter, newFilter)) {
Review comment:
@jsmucr here is the change that should fix the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org