You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/27 06:44:46 UTC
[GitHub] [doris] TsubameKoyasu opened a new pull request, #13723: Fix the extension mysql_to_doris BUG
TsubameKoyasu opened a new pull request, #13723:
URL: https://github.com/apache/doris/pull/13723
e_mysql_to_doris.sh: command error,This error causes script execution errors. :ERROR 1103 (42000) at line 1: Incorrect table name ''.
` ` symbol position error.
Issue Number: close #13722
## Problem summary
Using extension mysql_to_doris ,there was an error executing the e_mysql_to_doris.sh script.
ERROR 1103 (42000) at line 1: Incorrect table name ''.
Describe your changes.
fix ` ` symbol position error.
1. Does it affect the original behavior:
- [√ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ √] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ √] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ √] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ √] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13723: [Fix]Fix the extension mysql_to_doris BUG
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13723:
URL: https://github.com/apache/doris/pull/13723#issuecomment-1293157275
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.18 seconds
load time: 569 seconds
storage size: 17154709829 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027161417_clickbench_pr_34668.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13723: [Fix]Fix the extension mysql_to_doris bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13723:
URL: https://github.com/apache/doris/pull/13723#issuecomment-1294360029
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] TsubameKoyasu commented on a diff in pull request #13723: [Fix]Fix the extension mysql_to_doris bug
Posted by GitBox <gi...@apache.org>.
TsubameKoyasu commented on code in PR #13723:
URL: https://github.com/apache/doris/pull/13723#discussion_r1007529206
##########
extension/mysql_to_doris/bin/e_mysql_to_doris.sh:
##########
@@ -31,8 +31,8 @@ rm -f $path
#get create table sql for mysql
for table in $(cat ../conf/mysql_tables |grep -v '#' | awk -F '\n' '{print $1}')
do
- d_d=`echo $table` |awk -F '.' '{print $1}'
- d_t=`echo $table` |awk -F '.' '{print $2}'
+ d_d=`echo $table |awk -F '.' '{print $1}'`
+ d_t=`echo $table |awk -F '.' '{print $2}'`
Review Comment:
OK,That's right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13723: [Fix]Fix the extension mysql_to_doris bug
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13723:
URL: https://github.com/apache/doris/pull/13723#issuecomment-1294360007
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13723: [Fix]Fix the extension mysql_to_doris BUG
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13723:
URL: https://github.com/apache/doris/pull/13723#discussion_r1006620151
##########
extension/mysql_to_doris/bin/e_mysql_to_doris.sh:
##########
@@ -31,8 +31,8 @@ rm -f $path
#get create table sql for mysql
for table in $(cat ../conf/mysql_tables |grep -v '#' | awk -F '\n' '{print $1}')
do
- d_d=`echo $table` |awk -F '.' '{print $1}'
- d_t=`echo $table` |awk -F '.' '{print $2}'
+ d_d=`echo $table |awk -F '.' '{print $1}'`
+ d_t=`echo $table |awk -F '.' '{print $2}'`
Review Comment:
It is better to use this syntax.
```suggestion
d_d=$(echo $table |awk -F '.' '{print $1}')
d_t=$(echo $table |awk -F '.' '{print $2}')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #13723: [Fix]Fix the extension mysql_to_doris BUG
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #13723:
URL: https://github.com/apache/doris/pull/13723#discussion_r1006622810
##########
extension/mysql_to_doris/bin/e_mysql_to_doris.sh:
##########
@@ -31,8 +31,8 @@ rm -f $path
#get create table sql for mysql
for table in $(cat ../conf/mysql_tables |grep -v '#' | awk -F '\n' '{print $1}')
do
- d_d=`echo $table` |awk -F '.' '{print $1}'
- d_t=`echo $table` |awk -F '.' '{print $2}'
+ d_d=`echo $table |awk -F '.' '{print $1}'`
+ d_t=`echo $table |awk -F '.' '{print $2}'`
Review Comment:
BTW, some checks failed. Please rebase the code to trigger them again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #13723: [Fix]Fix the extension mysql_to_doris bug
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13723:
URL: https://github.com/apache/doris/pull/13723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13723: [Fix]Fix the extension mysql_to_doris bug
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13723:
URL: https://github.com/apache/doris/pull/13723#issuecomment-1294357984
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.9 seconds
load time: 590 seconds
storage size: 17154810757 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221028021619_clickbench_pr_35018.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org