You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by Andre Tadeu de Carvalho <an...@gmail.com> on 2019/01/17 15:02:38 UTC

Help with maven-jmod-plugin issues

Hello people!

Thank you all for being supportive. Could someone help me reviewing the
following PRs?

MJMOD-8: https://github.com/apache/maven-jmod-plugin/pull/2
MJMOD-20: https://github.com/apache/maven-jmod-plugin/pull/1

I could use these fixes successfully to build the following demos:

   - https://github.com/andretadeu/maven-jigsaw-examples
   - https://github.com/andretadeu/args4j/tree/jpms-support, branch
   jpms-support

I am available to make all the adjustments needed.

Thanks in advance,

André Tadeu de Carvalho

Re: Help with maven-jmod-plugin issues

Posted by Robert Scholte <rf...@apache.org>.

I've added review comments for both PRs.

I would expect a better solution for MJMOD-8, I can help with that.
The rest is mostly a matter of cleaning up: removing things from the pom  
that don't add anything to the IT and write Groovy as Groovy ;)

Robert

On Thu, 17 Jan 2019 16:02:38 +0100, Andre Tadeu de Carvalho  
<an...@gmail.com> wrote:

> Hello people!
>
> Thank you all for being supportive. Could someone help me reviewing the
> following PRs?
>
> MJMOD-8: https://github.com/apache/maven-jmod-plugin/pull/2
> MJMOD-20: https://github.com/apache/maven-jmod-plugin/pull/1
>
> I could use these fixes successfully to build the following demos:
>
>    - https://github.com/andretadeu/maven-jigsaw-examples
>    - https://github.com/andretadeu/args4j/tree/jpms-support, branch
>    jpms-support
>
> I am available to make all the adjustments needed.
>
> Thanks in advance,
>
> André Tadeu de Carvalho

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org