You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/29 06:18:24 UTC
[GitHub] dongjoon-hyun commented on a change in pull request #23628:
[SPARK-26702][SQL][TEST] Create a test trait for Parquet and Orc test
dongjoon-hyun commented on a change in pull request #23628: [SPARK-26702][SQL][TEST] Create a test trait for Parquet and Orc test
URL: https://github.com/apache/spark/pull/23628#discussion_r251703803
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetTest.scala
##########
@@ -31,8 +31,8 @@ import org.apache.parquet.hadoop.metadata.{BlockMetaData, FileMetaData, ParquetM
import org.apache.parquet.schema.MessageType
import org.apache.spark.sql.{DataFrame, SaveMode}
Review comment:
Shall we remove the unused `SaveMode`?
```scala
-import org.apache.spark.sql.{DataFrame, SaveMode}
+import org.apache.spark.sql.DataFrame
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org