You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/06/20 05:18:17 UTC

[GitHub] [bookkeeper] dlg99 commented on pull request #2742: [WIP] Abstract the FileChannel in the JournalChannel

dlg99 commented on pull request #2742:
URL: https://github.com/apache/bookkeeper/pull/2742#issuecomment-864501198


   @zymap change broke most of the test, I see stuff like 
   ```
   Error:    Run 1: LedgerStorageCheckpointTest.testCheckPointForEntryLoggerWithMultipleActiveEntryLogs:613->lambda$testCheckPointForEntryLoggerWithMultipleActiveEntryLogs$2:614->lambda$null$1:616 NullPointer
   ```
   
   pmemstore is not apache licensed, its addition should be discussed with the community along with the expected outcome, Reading from the Journal is not a bottleneck normally. Can you start a thread in a dev maillist to initiate the discussion?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org