You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by agrieve <gi...@git.apache.org> on 2014/11/18 08:51:26 UTC
[GitHub] cordova-plugin-splashscreen pull request: CB-3679 Break Android sp...
GitHub user agrieve opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32
CB-3679 Break Android splashscreen logic into splascreen plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agrieve/cordova-plugin-splashscreen splash-break
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit ab8a3fada7687a2dab3f0264dbb78027fa8f6c2d
Author: Andrew Grieve <ag...@chromium.org>
Date: 2014-11-18T07:48:45Z
CB-3679 Break Android splashscreen logic into splascreen plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3679 Break Android sp...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-90591245
This was merged. Will be applicable for cordova-android@4.0.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3679 Break Android sp...
Posted by cgwyllie <gi...@git.apache.org>.
Github user cgwyllie commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-73274586
@agrieve @jbavari Hey, been looking into this for a while this afternoon and was wondering how it's possible to use the version of Cordova that doesn't have the splash code bundled on Android. Any pointer would be appreciated!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3679 Break Android sp...
Posted by jbavari <gi...@git.apache.org>.
Github user jbavari commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-65865043
Works great. :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-3679 Break Android sp...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org