You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Ellis <er...@apache.org> on 2019/03/04 08:49:47 UTC
[VOTE] Cordova-Electron 1.0.1 Patch Release
Please review and vote on this Electron Release v1.0.1
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://github.com/apache/cordova/issues/10
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/GH-10
The package was published from its corresponding git tag:
cordova-electron: 1.0.1 (a8c677ed8b)
Note that you can test it out via:
cordova platform add https://github.com/apache/cordova-electron#1.0.1
Upon a successful vote I will upload the archive to dist/, publish it to npm, and post the blog post.
Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Test
Re: [VOTE] Cordova-Electron 1.0.1 Patch Release
Posted by Tim Brust <ti...@sinnerschrader.com.INVALID>.
+1
* coho verify-archive OK
* CI is green
On Tue, Mar 5, 2019 at 1:18 PM Jan Piotrowski <pi...@gmail.com> wrote:
> +1
>
> * CI is green
> * changes make sense
>
> Am Di., 5. März 2019 um 07:14 Uhr schrieb Ken Naito <ke...@monaca.io>:
> >
> > +1
> >
> > * coho verify-archive OK
> > * coho verify-tags OK (except for confirming signature owner)
> > * The last commit 8649e607d605f8c705b983d7042aa73ba7da1c4f passes CI
> tests.
> >
> >
> > Note that I added
> > {
> > title: 'Electron',
> > versions: ['1.0'],
> > id: 'electron',
> > repoName: 'cordova-electron',
> > jiraComponentName: 'cordova-electron'
> > }
> > in repoutils.js in cordova-coho to use coho commands for
> cordova-electron.
> >
> >
> >
> > On 2019/03/04 17:49, Bryan Ellis wrote:
> > > cordova-electron: 1.0.1 (a8c677ed8b)
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
--
Tim Brust, Product Engineer
tim.brust@sinnerschrader.com
T +49 40 398855 315
SinnerSchrader Deutschland GmbH | SinnerSchrader Group
Völckersstraße 38, 22765 Hamburg, Germany
Amtsgericht Hamburg HRB-Nr. 63663
Geschäftsführer: Matthias Schrader (Sprecher),
Jürgen Alker, Dr. Axel Averdung, Holger Blank,
Thomas Dyckhoff, Dr. Lars Finke, Martin Gassner, Peggy Hutchinson
Büros: Berlin, Hamburg, Frankfurt a. M., München, Prag
https://www.sinnerschrader.com | NEXT AGENCY
Re: [VOTE] Cordova-Electron 1.0.1 Patch Release
Posted by Jan Piotrowski <pi...@gmail.com>.
+1
* CI is green
* changes make sense
Am Di., 5. März 2019 um 07:14 Uhr schrieb Ken Naito <ke...@monaca.io>:
>
> +1
>
> * coho verify-archive OK
> * coho verify-tags OK (except for confirming signature owner)
> * The last commit 8649e607d605f8c705b983d7042aa73ba7da1c4f passes CI tests.
>
>
> Note that I added
> {
> title: 'Electron',
> versions: ['1.0'],
> id: 'electron',
> repoName: 'cordova-electron',
> jiraComponentName: 'cordova-electron'
> }
> in repoutils.js in cordova-coho to use coho commands for cordova-electron.
>
>
>
> On 2019/03/04 17:49, Bryan Ellis wrote:
> > cordova-electron: 1.0.1 (a8c677ed8b)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [VOTE] Cordova-Electron 1.0.1 Patch Release
Posted by Bryan Ellis <er...@apache.org>.
The vote has now closed. The results are:
Positive Binding Votes: (4)
* Bryan Ellis
* Ken Naito
* Jan Piotrowski
* Jesse
Negative Binding Votes: 0
Positive Non-Binding Votes: (1)
* Tim Brust
The vote has passed.
From: Jesse <pu...@gmail.com>
Reply: dev@cordova.apache.org <de...@cordova.apache.org>
Date: March 6, 2019 at 3:27:23
To: dev@cordova.apache.org <de...@cordova.apache.org>, ken@monaca.io <ke...@monaca.io>
Subject: Re: [VOTE] Cordova-Electron 1.0.1 Patch Release
+1
* coho verify-archive OK
* ci is green
@purplecabbage
risingj.com
On Mon, Mar 4, 2019 at 10:14 PM Ken Naito <ke...@monaca.io> wrote:
> +1
>
> * coho verify-archive OK
> * coho verify-tags OK (except for confirming signature owner)
> * The last commit 8649e607d605f8c705b983d7042aa73ba7da1c4f passes CI tests.
>
>
> Note that I added
> {
> title: 'Electron',
> versions: ['1.0'],
> id: 'electron',
> repoName: 'cordova-electron',
> jiraComponentName: 'cordova-electron'
> }
> in repoutils.js in cordova-coho to use coho commands for cordova-electron.
>
>
>
> On 2019/03/04 17:49, Bryan Ellis wrote:
> > cordova-electron: 1.0.1 (a8c677ed8b)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [VOTE] Cordova-Electron 1.0.1 Patch Release
Posted by Jesse <pu...@gmail.com>.
+1
* coho verify-archive OK
* ci is green
@purplecabbage
risingj.com
On Mon, Mar 4, 2019 at 10:14 PM Ken Naito <ke...@monaca.io> wrote:
> +1
>
> * coho verify-archive OK
> * coho verify-tags OK (except for confirming signature owner)
> * The last commit 8649e607d605f8c705b983d7042aa73ba7da1c4f passes CI tests.
>
>
> Note that I added
> {
> title: 'Electron',
> versions: ['1.0'],
> id: 'electron',
> repoName: 'cordova-electron',
> jiraComponentName: 'cordova-electron'
> }
> in repoutils.js in cordova-coho to use coho commands for cordova-electron.
>
>
>
> On 2019/03/04 17:49, Bryan Ellis wrote:
> > cordova-electron: 1.0.1 (a8c677ed8b)
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
Re: [VOTE] Cordova-Electron 1.0.1 Patch Release
Posted by Ken Naito <ke...@monaca.io>.
+1
* coho verify-archive OK
* coho verify-tags OK (except for confirming signature owner)
* The last commit 8649e607d605f8c705b983d7042aa73ba7da1c4f passes CI tests.
Note that I added
{
title: 'Electron',
versions: ['1.0'],
id: 'electron',
repoName: 'cordova-electron',
jiraComponentName: 'cordova-electron'
}
in repoutils.js in cordova-coho to use coho commands for cordova-electron.
On 2019/03/04 17:49, Bryan Ellis wrote:
> cordova-electron: 1.0.1 (a8c677ed8b)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org