You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/12 17:52:12 UTC
Review Request 64551: Integrated the status update manager into SLRP.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/
-----------------------------------------------------------
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
This patch uses the status update manager to send status updates and
recover operations that are checkpointed as completed in the status
update manager but still in the pending list in SLRP. It also forwards
the acknowledgements to the status update manager, and garbage collect
the metadata for offer operations.
Diffs
-----
src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
src/slave/paths.hpp d645d871c36bbe8e766a98650f6aa23b6eab65d8
src/slave/paths.cpp b8004e76964abc210820368a89dbfa6928ef7bfd
Diff: https://reviews.apache.org/r/64551/diff/1/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64551: Integrated the status update manager into
SLRP.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/#review193596
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64517', '64472', '64473', '64509', '64521', '64550', '64475', '64551']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64551
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64551/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2283 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2305 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2266 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2289 ms total)
[----------] Global test environment tear-down
[==========] 830 tests from 84 test cases ran. (301567 ms total)
[ PASSED ] 819 tests.
[ FAILED ] 11 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending
[ FAILED ] SlaveTest.ResourceProviderPublishAll
11 FAILED TESTS
YOU HAVE 204 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64551/logs/mesos-tests-stderr.log):
```
I1212 19:37:06.878981 9156 master.cpp:10146] Updating the state of task 649405f8-356f-435b-ab7a-d412c08c11e9 of framework 14ee5ed0-9a4a-43a8-886b-91025859d73b-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1212 19:37:06.878981 3548 slave.cpp:3400] Shutting down framework 14ee5ed0-9a4a-43a8-886b-91025859d73b-0000
I1212 19:37:06.878981 3548 slave.cpp:6091] Shutting down executor '649405f8-356f-435b-ab7a-d412c08c11e9' of framework 14ee5ed0-9a4a-43a8-886b-91025859d73b-0000 at executor(1)@10.I1212 19:37:06.221943 5104 exec.cpp:162] Version: 1.5.0
I1212 19:37:06.244920 4568 exec.cpp:237] Executor registered on agent 14ee5ed0-9a4a-43a8-886b-91025859d73b-S0
I1212 19:37:06.247920 8728 executor.cpp:171] Received SUBSCRIBED event
I1212 19:37:06.251940 8728 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1212 19:37:06.252938 8728 executor.cpp:171] Received LAUNCH event
I1212 19:37:06.255962 8728 executor.cpp:637] Starting task 649405f8-356f-435b-ab7a-d412c08c11e9
I1212 19:37:06.329921 8728 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1212 19:37:06.853941 8728 executor.cpp:650] Forked command at 6188
I1212 19:37:06.880908 3324 exec.cpp:435] Executor asked to shutdown
I1212 19:37:06.880908 8252 executor.cpp:171] Received SHUTDOWN event
I1212 19:37:06.880908 8252 executor.cpp:747] Shutting down
I1212 19:37:06.881907 8252 executor.cpp:854] Sending SIGTERM to process tree at pid 63.1.5:64835
I1212 19:37:06.879907 3548 slave.cpp:909] Agent terminating
W1212 19:37:06.879907 3548 slave.cpp:3396] Ignoring shutdown framework 14ee5ed0-9a4a-43a8-886b-91025859d73b-0000 because it is terminating
I1212 19:37:06.880908 9156 master.cpp:10252] Removing task 649405f8-356f-435b-ab7a-d412c08c11e9 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 14ee5ed0-9a4a-43a8-886b-91025859d73b-0000 on agent 14ee5ed0-9a4a-43a8-886b-91025859d73b-S0 at slave(326)@10.3.1.5:64814 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 19:37:06.883906 9156 master.cpp:1305] Agent 14ee5ed0-9a4a-43a8-886b-91025859d73b-S0 at slave(326)@10.3.1.5:64814 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1212 19:37:06.883906 9156 master.cpp:3364] Disconnecting agent 14ee5ed0-9a4a-43a8-886b-91025859d73b-S0 at slave(326)@10.3.1.5:64814 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 19:37:06.883906 8108 containerizer.cpp:2328] Destroying container 8668a73c-bff4-42a6-9ea7-ec25cce69e52 in RUNNING state
I1212 19:37:06.883906 8848 hierarchical.cpp:344] Removed framework 14ee5ed0-9a4a-43a8-886b-91025859d73b-0000
I1212 19:37:06.883906 8108 containerizer.cpp:2930] Transitioning the state of container 8668a73c-bff4-42a6-9ea7-ec25cce69e52 from RUNNING to DESTROYING
I1212 19:37:06.883906 9156 master.cpp:3383] Deactivating agent 14ee5ed0-9a4a-43a8-886b-91025859d73b-S0 at slave(326)@10.3.1.5:64814 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1212 19:37:06.883906 3548 hierarchical.cpp:766] Agent 14ee5ed0-9a4a-43a8-886b-91025859d73b-S0 deactivated
I1212 19:37:06.884907 8108 launcher.cpp:156] Asked to destroy container 8668a73c-bff4-42a6-9ea7-ec25cce69e52
I1212 19:37:06.930049 9156 containerizer.cpp:2779] Container 8668a73c-bff4-42a6-9ea7-ec25cce69e52 has exited
I1212 19:37:06.958079 1760 master.cpp:1147] Master terminating
I1212 19:37:06.960093 1432 hierarchical.cpp:609] Removed agent 14ee5ed0-9a4a-43a8-886b-91025859d73b-S0
I1212 19:37:07.273900 2148 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 12, 2017, 5:52 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64551/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 5:52 p.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch uses the status update manager to send status updates and
> recover operations that are checkpointed as completed in the status
> update manager but still in the pending list in SLRP. It also forwards
> the acknowledgements to the status update manager, and garbage collect
> the metadata for offer operations.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
> src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
> src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
> src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
> src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
> src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
> src/slave/paths.hpp d645d871c36bbe8e766a98650f6aa23b6eab65d8
> src/slave/paths.cpp b8004e76964abc210820368a89dbfa6928ef7bfd
>
>
> Diff: https://reviews.apache.org/r/64551/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64551: Integrated the status update manager into
SLRP.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/#review193594
-----------------------------------------------------------
In the commit message: `s/and garbage collect/and garbage collects/`
src/resource_provider/storage/provider.cpp
Lines 904-905 (patched)
<https://reviews.apache.org/r/64551/#comment272162>
Why can't we reconstruct them?
The list of status returned by the SUM will contain a terminal update, but `terminated` will be `false`.
src/resource_provider/storage/provider.cpp
Lines 2538 (patched)
<https://reviews.apache.org/r/64551/#comment272163>
s/refactor/refactoring/
- Gaston Kleiman
On Dec. 12, 2017, 9:52 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64551/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2017, 9:52 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch uses the status update manager to send status updates and
> recover operations that are checkpointed as completed in the status
> update manager but still in the pending list in SLRP. It also forwards
> the acknowledgements to the status update manager, and garbage collect
> the metadata for offer operations.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
> src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
> src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
> src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
> src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
> src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
> src/slave/paths.hpp d645d871c36bbe8e766a98650f6aa23b6eab65d8
> src/slave/paths.cpp b8004e76964abc210820368a89dbfa6928ef7bfd
>
>
> Diff: https://reviews.apache.org/r/64551/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64551: Integrated the status update manager into
SLRP.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/#review193857
-----------------------------------------------------------
src/resource_provider/storage/provider.cpp
Lines 1381 (patched)
<https://reviews.apache.org/r/64551/#comment272515>
The RP doesn't know about this operation, so it wouldn't know how to recover it if checkpointed.
That means that this line should be:
` statusUpdateManager.update(std::move(update), false)`
- Gaston Kleiman
On Dec. 13, 2017, 5:18 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64551/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 5:18 p.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch uses the status update manager to send status updates and
> recover operations that are checkpointed as completed in the status
> update manager but still in the pending list in SLRP. It also forwards
> the acknowledgements to the status update manager, and garbage collect
> the metadata for offer operations.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
> src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
> src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
> src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
> src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
> src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
>
>
> Diff: https://reviews.apache.org/r/64551/diff/5/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64551: Integrated the status update manager into
SLRP.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/
-----------------------------------------------------------
(Updated Dec. 14, 2017, 1:18 a.m.)
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Changes
-------
Addressed Jie's comments.
Repository: mesos
Description
-------
This patch uses the status update manager to send status updates and
recover operations that are checkpointed as completed in the status
update manager but still in the pending list in SLRP. It also forwards
the acknowledgements to the status update manager, and garbage collect
the metadata for offer operations.
Diffs (updated)
-----
src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
Diff: https://reviews.apache.org/r/64551/diff/5/
Changes: https://reviews.apache.org/r/64551/diff/4-5/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64551: Integrated the status update manager into
SLRP.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/#review193746
-----------------------------------------------------------
Fix it, then Ship it!
src/resource_provider/storage/provider.cpp
Lines 956 (patched)
<https://reviews.apache.org/r/64551/#comment272380>
Let's move the terminal check here.
src/resource_provider/storage/provider.cpp
Lines 1364 (patched)
<https://reviews.apache.org/r/64551/#comment272384>
Do you need to generate a status uuid for the DROPPED status?
- Jie Yu
On Dec. 13, 2017, 11:55 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64551/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 11:55 p.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch uses the status update manager to send status updates and
> recover operations that are checkpointed as completed in the status
> update manager but still in the pending list in SLRP. It also forwards
> the acknowledgements to the status update manager, and garbage collect
> the metadata for offer operations.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
> src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
> src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
> src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
> src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
> src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
>
>
> Diff: https://reviews.apache.org/r/64551/diff/4/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64551: Integrated the status update manager into
SLRP.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/
-----------------------------------------------------------
(Updated Dec. 13, 2017, 11:55 p.m.)
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Changes
-------
Addressed a race condition that may trigger a CHECK failure.
Repository: mesos
Description
-------
This patch uses the status update manager to send status updates and
recover operations that are checkpointed as completed in the status
update manager but still in the pending list in SLRP. It also forwards
the acknowledgements to the status update manager, and garbage collect
the metadata for offer operations.
Diffs (updated)
-----
src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
Diff: https://reviews.apache.org/r/64551/diff/4/
Changes: https://reviews.apache.org/r/64551/diff/3-4/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao
Re: Review Request 64551: Integrated the status update manager into
SLRP.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/#review193645
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64521', '64475', '64559', '64551']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64551
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64551/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2325 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2346 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2268 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2290 ms total)
[----------] Global test environment tear-down
[==========] 830 tests from 84 test cases ran. (304861 ms total)
[ PASSED ] 819 tests.
[ FAILED ] 11 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending
[ FAILED ] SlaveTest.ResourceProviderPublishAll
11 FAILED TESTS
YOU HAVE 204 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64551/logs/mesos-tests-stderr.log):
```
I1213 05:00:35.168634 4056 slave.cpp:3400] Shutting down framework 10eaf617-8e77-4711-92ae-f97267c755dc-0000
I1213 05:00:35.168634 4948 master.cpp:10158] Updating the state of task e998c345-6629-43c0-bad6-7d5b81830efe of framework 10eaf617-8e77-4711-92ae-f97267c755dc-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1213 05:00:35.168634 4056 slave.cpp:6114] ShuttingI1213 05:00:34.505656 2112 exec.cpp:162] Version: 1.5.0
I1213 05:00:34.529639 3796 exec.cpp:237] Executor registered on agent 10eaf617-8e77-4711-92ae-f97267c755dc-S0
I1213 05:00:34.532636 5168 executor.cpp:171] Received SUBSCRIBED event
I1213 05:00:34.536660 5168 executor.cpp:175] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1213 05:00:34.536660 5168 executor.cpp:171] Received LAUNCH event
I1213 05:00:34.540634 5168 executor.cpp:637] Starting task e998c345-6629-43c0-bad6-7d5b81830efe
I1213 05:00:34.617655 5168 executor.cpp:477] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1213 05:00:35.144623 5168 executor.cpp:650] Forked command at 5304
I1213 05:00:35.170622 7000 exec.cpp:435] Executor asked to shutdown
I1213 05:00:35.170622 96 executor.cpp:171] Received SHUTDOWN event
I1213 05:00:35.171622 96 executor.cpp:747] Shutting down
I1213 05:00:35.171622 96 executor.cpp:854] Sending SIGTERM to process tree at pid 5 down executor 'e998c345-6629-43c0-bad6-7d5b81830efe' of framework 10eaf617-8e77-4711-92ae-f97267c755dc-0000 at executor(1)@10.3.1.5:61661
I1213 05:00:35.169622 4056 slave.cpp:909] Agent terminating
W1213 05:00:35.170622 4056 slave.cpp:3396] Ignoring shutdown framework 10eaf617-8e77-4711-92ae-f97267c755dc-0000 because it is terminating
I1213 05:00:35.171622 4948 master.cpp:10264] Removing task e998c345-6629-43c0-bad6-7d5b81830efe with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 10eaf617-8e77-4711-92ae-f97267c755dc-0000 on agent 10eaf617-8e77-4711-92ae-f97267c755dc-S0 at slave(326)@10.3.1.5:61639 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 05:00:35.173622 1100 containerizer.cpp:2328] Destroying container 4c540913-06d7-481c-b7b8-4db94e2219be in RUNNING state
I1213 05:00:35.173622 1100 containerizer.cpp:2930] Transitioning the state of container 4c540913-06d7-481c-b7b8-4db94e2219be from RUNNING to DESTROYING
I1213 05:00:35.173622 4948 master.cpp:1305] Agent 10eaf617-8e77-4711-92ae-f97267c755dc-S0 at slave(326)@10.3.1.5:61639 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1213 05:00:35.173622 4948 master.cpp:3364] Disconnecting agent 10eaf617-8e77-4711-92ae-f97267c755dc-S0 at slave(326)@10.3.1.5:61639 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 05:00:35.173622 4948 master.cpp:3383] Deactivating agent 10eaf617-8e77-4711-92ae-f97267c755dc-S0 at slave(326)@10.3.1.5:61639 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 05:00:35.173622 4056 hierarchical.cpp:344] Removed framework 10eaf617-8e77-4711-92ae-f97267c755dc-0000
I1213 05:00:35.174623 4056 hierarchical.cpp:766] Agent 10eaf617-8e77-4711-92ae-f97267c755dc-S0 deactivated
I1213 05:00:35.174623 1100 launcher.cpp:156] Asked to destroy container 4c540913-06d7-481c-b7b8-4db94e2219be
I1213 05:00:35.214681 4948 containerizer.cpp:2779] Container 4c540913-06d7-481c-b7b8-4db94e2219be has exited
I1213 05:00:35.242089 2144 master.cpp:1147] Master terminating
I1213 05:00:35.244088 8340 hierarchical.cpp:609] Removed agent 10eaf617-8e77-4711-92ae-f97267c755dc-S0
I1213 05:00:35.528595 2676 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 13, 2017, 2:59 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64551/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 2:59 a.m.)
>
>
> Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch uses the status update manager to send status updates and
> recover operations that are checkpointed as completed in the status
> update manager but still in the pending list in SLRP. It also forwards
> the acknowledgements to the status update manager, and garbage collect
> the metadata for offer operations.
>
>
> Diffs
> -----
>
> src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
> src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
> src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
> src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
> src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
> src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
>
>
> Diff: https://reviews.apache.org/r/64551/diff/3/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64551: Integrated the status update manager into
SLRP.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64551/
-----------------------------------------------------------
(Updated Dec. 13, 2017, 2:59 a.m.)
Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu.
Repository: mesos
Description
-------
This patch uses the status update manager to send status updates and
recover operations that are checkpointed as completed in the status
update manager but still in the pending list in SLRP. It also forwards
the acknowledgements to the status update manager, and garbage collect
the metadata for offer operations.
Diffs (updated)
-----
src/resource_provider/daemon.hpp 7c513a2b7c7ca958f9ea57326493f74df5b67c8f
src/resource_provider/daemon.cpp 7c783e309672a2d93532fb17f13afcb96d5a7006
src/resource_provider/local.hpp 46111d9f8969ea47e695d08832cb5a9ea60d1971
src/resource_provider/local.cpp d1d683534d186e77a2beb32c978f2aaea289b086
src/resource_provider/storage/provider.hpp 374f837ad693820afffb86bd1e54915f6796d088
src/resource_provider/storage/provider.cpp e806f44ef33405d4a2b133576c60be56e9fe3435
Diff: https://reviews.apache.org/r/64551/diff/2/
Changes: https://reviews.apache.org/r/64551/diff/1-2/
Testing
-------
sudo make check
Thanks,
Chun-Hung Hsiao