You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ji...@apache.org on 2019/01/02 05:44:33 UTC

[flink] branch release-1.7 updated: [FLINK-11246][table] Fix distinct AGG visibility issue

This is an automated email from the ASF dual-hosted git repository.

jincheng pushed a commit to branch release-1.7
in repository https://gitbox.apache.org/repos/asf/flink.git


The following commit(s) were added to refs/heads/release-1.7 by this push:
     new d323373  [FLINK-11246][table] Fix distinct AGG visibility issue
d323373 is described below

commit d3233738c9dccad12c5526d648d30d7f66743e41
Author: Dian Fu <fu...@alibaba-inc.com>
AuthorDate: Wed Jan 2 11:06:31 2019 +0800

    [FLINK-11246][table] Fix distinct AGG visibility issue
    
    This closes #7394
---
 .../main/scala/org/apache/flink/table/expressions/aggregations.scala    | 2 +-
 .../org/apache/flink/table/functions/DistinctAggregateFunction.scala    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/aggregations.scala b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/aggregations.scala
index c77bd7a..f6ea4bd 100644
--- a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/aggregations.scala
+++ b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/aggregations.scala
@@ -56,7 +56,7 @@ abstract sealed class Aggregation extends Expression {
 
 case class DistinctAgg(child: Expression) extends Aggregation {
 
-  private[flink] def distinct: Expression = DistinctAgg(child)
+  def distinct: Expression = DistinctAgg(child)
 
   override private[flink] def resultType: TypeInformation[_] = child.resultType
 
diff --git a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/DistinctAggregateFunction.scala b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/DistinctAggregateFunction.scala
index c75e6fa..bd221c2 100644
--- a/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/DistinctAggregateFunction.scala
+++ b/flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/DistinctAggregateFunction.scala
@@ -28,7 +28,7 @@ import org.apache.flink.table.functions.utils.UserDefinedFunctionUtils.{getAccum
 private[flink] case class DistinctAggregateFunction[T: TypeInformation, ACC: TypeInformation]
     (aggFunction: AggregateFunction[T, ACC]) {
 
-  private[flink] def distinct(params: Expression*): Expression = {
+  def distinct(params: Expression*): Expression = {
     val resultTypeInfo: TypeInformation[_] = getResultTypeOfAggregateFunction(
       aggFunction,
       implicitly[TypeInformation[T]])