[jira] [Commented] (HDFS-4590) Add more Unit Test Case for HDFS-3701 HDFS Miss Final Block Reading when File is Open for Write

["Suresh Srinivas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622449#comment-13622449 ] 

Suresh Srinivas commented on HDFS-4590:
---------------------------------------

Comments:
# Nit: typo trting
# Some changes you could do in that part of the code, unrelated to your patch:
#* verifyNNIsInSafeMode method declares throwing unnecessary IOException
#* "NN might not started" -> "NN might not be started"

                
> Add more Unit Test Case for HDFS-3701 HDFS Miss Final Block Reading when File is Open for Write
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4590
>                 URL: https://issues.apache.org/jira/browse/HDFS-4590
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: hdfs-client
>    Affects Versions: 1.2.0
>         Environment: Java Unit Test Case
>            Reporter: Huned Lokhandwala
>            Assignee: Huned Lokhandwala
>            Priority: Minor
>         Attachments: HDFS-4590.b1.001.patch
>
>
> Add more Java Unit Test Coverage for the feature HDFS-3701 where the file is opened for writing, the DFSClient calls one of the datanode owning the last block to get its size, and if this datanode is dead then test for if socket IO Exception is thrown. Add a unit test case to write to a file, shutdown the datanodes, and then try to read from the file and expect an IO Exception. On branch 1 it should throw the IO Exception as expected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira