You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/06/03 11:12:00 UTC

[jira] [Commented] (AIRFLOW-4572) Rename prepare_classpath() to prepare_syspath() in settings.py

    [ https://issues.apache.org/jira/browse/AIRFLOW-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854477#comment-16854477 ] 

ASF GitHub Bot commented on AIRFLOW-4572:
-----------------------------------------

ashb commented on pull request #5328: [AIRFLOW-4572] Rename prepare_classpath to prepare_syspath
URL: https://github.com/apache/airflow/pull/5328
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Rename prepare_classpath() to prepare_syspath() in settings.py
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-4572
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4572
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.10.3
>            Reporter: Philippe Gagnon
>            Assignee: Philippe Gagnon
>            Priority: Trivial
>             Fix For: 1.10.4
>
>
> {{settings.py}} currently defines a {{prepare_classpath()}} function that ensures that certain subfolders in {{$AIRFLOW_HOME}} are added to {{sys.path}}. The function's naming seems borrowed from Java, and thus could be improved by renaming it to {{prepare_syspath()}} which is the equivalent Python concept.
> This appears to be an internal API that is only used in {{settings.py}} itself, so the change shouldn't have any impact.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)