You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/08/05 23:25:35 UTC
Review Request 37144: Resources: moving calculation methods from
Resources
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37144/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Bugs: AURORA-1415
https://issues.apache.org/jira/browse/AURORA-1415
Repository: aurora
Description
-------
May not apply cleanly as it branched off of 37139.
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/Offers.java e40db747047792fedf237e9e22139e84264bcb95
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ecadb3ee70236a61dedbcd15f6897f1bc27b1680
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 554a380bdb4ef69561259cdbfbc361694041571e
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java ea7ce24969171a04ebee2419ad7d5111a12d3538
src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 325f55640648151ae19e0c18c6961aeff10bfac3
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 4562b3b8546be152e697412e9b9ed5e3b18aba16
src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java a93fa228b8822449faa8387f3c4f9cd24fcc29cb
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0e32990e3c8776d505b58b3e0ff54fa190897ecc
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java b96c84cbec083df5907b8c4293ac0f6fb77d3758
src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java b4dbab77ec0f8e843dd5248655b10fc7b7794398
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java cd0f98160d4f59e86596e8053390a6ec04080897
src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 115dc085ec953dde19614fc7d073c6ca5fc7b07d
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 7f18bbc4359306d2a2bb68b13d9853686714e441
src/test/java/org/apache/aurora/scheduler/mesos/Offers.java c10d5b6a80c01998f2189900eee089de3aa21094
src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java ebd81775c5c9f0ef5c309869df1d12dca3ddbdd7
src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 997d3261656f1912968a09c5982ce3786bda0231
Diff: https://reviews.apache.org/r/37144/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37144: Resources: moving calculation methods from
Resources
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37144/#review94320
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Aug. 5, 2015, 9:25 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37144/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 9:25 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1415
> https://issues.apache.org/jira/browse/AURORA-1415
>
>
> Repository: aurora
>
>
> Description
> -------
>
> May not apply cleanly as it branched off of 37139.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java e40db747047792fedf237e9e22139e84264bcb95
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ecadb3ee70236a61dedbcd15f6897f1bc27b1680
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 554a380bdb4ef69561259cdbfbc361694041571e
> src/main/java/org/apache/aurora/scheduler/configuration/Resources.java ea7ce24969171a04ebee2419ad7d5111a12d3538
> src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 325f55640648151ae19e0c18c6961aeff10bfac3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 4562b3b8546be152e697412e9b9ed5e3b18aba16
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java a93fa228b8822449faa8387f3c4f9cd24fcc29cb
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0e32990e3c8776d505b58b3e0ff54fa190897ecc
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java b96c84cbec083df5907b8c4293ac0f6fb77d3758
> src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java b4dbab77ec0f8e843dd5248655b10fc7b7794398
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java cd0f98160d4f59e86596e8053390a6ec04080897
> src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 115dc085ec953dde19614fc7d073c6ca5fc7b07d
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 7f18bbc4359306d2a2bb68b13d9853686714e441
> src/test/java/org/apache/aurora/scheduler/mesos/Offers.java c10d5b6a80c01998f2189900eee089de3aa21094
> src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java ebd81775c5c9f0ef5c309869df1d12dca3ddbdd7
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 997d3261656f1912968a09c5982ce3786bda0231
>
> Diff: https://reviews.apache.org/r/37144/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37144: Resources: moving calculation methods from
Resources
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37144/#review94319
-----------------------------------------------------------
Ship it!
Master (8adc9bd) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 5, 2015, 9:25 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37144/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2015, 9:25 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1415
> https://issues.apache.org/jira/browse/AURORA-1415
>
>
> Repository: aurora
>
>
> Description
> -------
>
> May not apply cleanly as it branched off of 37139.
>
>
> Diffs
> -----
>
> src/jmh/java/org/apache/aurora/benchmark/Offers.java e40db747047792fedf237e9e22139e84264bcb95
> src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ecadb3ee70236a61dedbcd15f6897f1bc27b1680
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 554a380bdb4ef69561259cdbfbc361694041571e
> src/main/java/org/apache/aurora/scheduler/configuration/Resources.java ea7ce24969171a04ebee2419ad7d5111a12d3538
> src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 325f55640648151ae19e0c18c6961aeff10bfac3
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 4562b3b8546be152e697412e9b9ed5e3b18aba16
> src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java a93fa228b8822449faa8387f3c4f9cd24fcc29cb
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0e32990e3c8776d505b58b3e0ff54fa190897ecc
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java b96c84cbec083df5907b8c4293ac0f6fb77d3758
> src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java b4dbab77ec0f8e843dd5248655b10fc7b7794398
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java cd0f98160d4f59e86596e8053390a6ec04080897
> src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 115dc085ec953dde19614fc7d073c6ca5fc7b07d
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 7f18bbc4359306d2a2bb68b13d9853686714e441
> src/test/java/org/apache/aurora/scheduler/mesos/Offers.java c10d5b6a80c01998f2189900eee089de3aa21094
> src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java ebd81775c5c9f0ef5c309869df1d12dca3ddbdd7
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 997d3261656f1912968a09c5982ce3786bda0231
>
> Diff: https://reviews.apache.org/r/37144/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37144: Resources: moving Resources to scheduler
package.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37144/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 8:08 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Fixing summary.
Summary (updated)
-----------------
Resources: moving Resources to scheduler package.
Bugs: AURORA-1415
https://issues.apache.org/jira/browse/AURORA-1415
Repository: aurora
Description
-------
May not apply cleanly as it branched off of 37139.
Diffs
-----
src/jmh/java/org/apache/aurora/benchmark/Offers.java e40db747047792fedf237e9e22139e84264bcb95
src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ecadb3ee70236a61dedbcd15f6897f1bc27b1680
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 554a380bdb4ef69561259cdbfbc361694041571e
src/main/java/org/apache/aurora/scheduler/configuration/Resources.java ea7ce24969171a04ebee2419ad7d5111a12d3538
src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java 325f55640648151ae19e0c18c6961aeff10bfac3
src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 4562b3b8546be152e697412e9b9ed5e3b18aba16
src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java a93fa228b8822449faa8387f3c4f9cd24fcc29cb
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 0e32990e3c8776d505b58b3e0ff54fa190897ecc
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java b96c84cbec083df5907b8c4293ac0f6fb77d3758
src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java b4dbab77ec0f8e843dd5248655b10fc7b7794398
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java cd0f98160d4f59e86596e8053390a6ec04080897
src/test/java/org/apache/aurora/scheduler/configuration/ResourcesTest.java 115dc085ec953dde19614fc7d073c6ca5fc7b07d
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 7f18bbc4359306d2a2bb68b13d9853686714e441
src/test/java/org/apache/aurora/scheduler/mesos/Offers.java c10d5b6a80c01998f2189900eee089de3aa21094
src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java ebd81775c5c9f0ef5c309869df1d12dca3ddbdd7
src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 997d3261656f1912968a09c5982ce3786bda0231
Diff: https://reviews.apache.org/r/37144/diff/
Testing
-------
Thanks,
Maxim Khutornenko